From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 367CBA0548; Wed, 1 Jun 2022 10:32:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF91B40A89; Wed, 1 Jun 2022 10:32:50 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BD97D40A87 for ; Wed, 1 Jun 2022 10:32:49 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.81.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E3338AE; Wed, 1 Jun 2022 11:32:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E3338AE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1654072369; bh=SIIX8SEHRsf+t6ykemCB9YjpfSRhy0jHumLcY4UA95A=; h=Date:Subject:To:References:From:In-Reply-To:From; b=uQNodPE/KHFtOOZVHBpNZfUL9yuzWXCaQ+FEs+PG9KTfunDEEEvRI7IupxVGXFQzJ O7wE77svLEjSEnnYTYOID8vGrNhQ+Y+O/edFNo5f8dBRc2xq/9JSiyicECljsCnQ3n iRNhmaap2BiJnwkCevyhTEwrsSJzdcKHCXfJgWWE= Message-ID: <8746557a-44c6-bde4-ee96-c73a921c1d9b@oktetlabs.ru> Date: Wed, 1 Jun 2022 11:32:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck Content-Language: en-US To: "Min Hu (Connor)" , dev@dpdk.org References: <20220519122917.2334-1-humin29@huawei.com> <20220601035251.16408-1-humin29@huawei.com> <20220601035251.16408-7-humin29@huawei.com> From: Andrew Rybchenko In-Reply-To: <20220601035251.16408-7-humin29@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/1/22 06:52, Min Hu (Connor) wrote: > In bitwise operation, "val" should be an unsigned type. This patch > fixed it. > > Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") > Cc: stable@dpdk.org Please, let me know coverity ID. No necessity to resend. I'll add it on applying. > > Signed-off-by: Min Hu (Connor) > --- > drivers/net/hns3/hns3_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/hns3/hns3_ptp.c b/drivers/net/hns3/hns3_ptp.c > index 1442241a4e..0b0061bba5 100644 > --- a/drivers/net/hns3/hns3_ptp.c > +++ b/drivers/net/hns3/hns3_ptp.c > @@ -81,7 +81,7 @@ hns3_timesync_configure(struct hns3_adapter *hns, bool en) > struct hns3_hw *hw = &hns->hw; > struct hns3_pf *pf = &hns->pf; > struct hns3_cmd_desc desc; > - int val; > + uint32_t val; > int ret; > > hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_CFG_PTP_MODE, false);