From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3952C6D45 for ; Fri, 22 Sep 2017 00:03:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E633520CD8; Thu, 21 Sep 2017 18:03:32 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 21 Sep 2017 18:03:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UJ/DLXzUt1SNcDM DOCMBMXp/4DwEIXwcCjCWYZQ0n08=; b=lfQ72GQTkKClICQyDl/wKso5wn7NXkz ZsqSAUKXtFemJG1tEg6epUq9fRS7/Fe9dmFbmFZeMOYoDd0/AWyQKQeN/plhmNQO hSvnxt0o7H6hjrlQEPYLO4/QZKscmLZuu4Vu+BFP87Ai/Mudx4lU59UWcScTRlAu h1BslZahzrgs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=UJ/DLXzUt1SNcDMDOCMBMXp/4DwEIXwcCjCWYZQ0n08=; b=rRso+uLZ kFwcMtyGXQ4up1cGxqh0alJCMfYg2r6RfziZrfqxFG9k1EWFJtpXK4htf6XJn/by O1CDOGL2eox/bbMpQU/SdVb9Wzuy78HkNaXCvNHmAHj0rqRDwzc4R3GDxLm8kD5o xiCt35j7GG3V3dUpiwvOktXOD2IEVNly7DRNiGJ+IS10ShqZJKxZRwiaPcrxlydm JE8B5DlX+Z6zwWOz9xDsMO44E2l5nBzXtWVP7U0YZgDUpmjSEP3BaULp+HY2dc3S EU6Nw75opAWYdxCc/l59gZdpxySfEr90Giive5pV7nAkFX/qAS/Q4+yzV5b+N6dG 9BcAkYzd2jTV0Q== X-ME-Sender: X-Sasl-enc: S5TGUWoc/NsKGmrUqFMelKgIYYchrOCVX2X781tksY6A 1506031412 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 98232240F4; Thu, 21 Sep 2017 18:03:32 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, ferruh.yigit@intel.com, hemant.agrawal@nxp.com Date: Fri, 22 Sep 2017 00:03:31 +0200 Message-ID: <8761789.OGcidtGilR@xps> In-Reply-To: <20170823141213.25476-25-shreyansh.jain@nxp.com> References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170823141213.25476-25-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 24/40] config: enable NXP DPAA PMD compilation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 22:03:34 -0000 23/08/2017 16:11, Shreyansh Jain: > --- a/config/defconfig_arm64-dpaa-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa-linuxapp-gcc > +# > +# Compile Environment Abstraction Layer > +# > +CONFIG_RTE_MAX_LCORE=4 > +CONFIG_RTE_MAX_NUMA_NODES=1 > +CONFIG_RTE_CACHE_LINE_SIZE=64 > +CONFIG_RTE_PKTMBUF_HEADROOM=128 This should be part of the SoC introduction. The rest of this patch can be squashed with PMD skeleton. [...] > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -116,6 +116,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lrte_pmd_bnx2x -lz > _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += -lrte_pmd_bnxt > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > _LDLIBS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += -lrte_pmd_cxgbe > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_pmd_dpaa > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_pmd_dpaa2 > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000 > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena > @@ -182,6 +183,10 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_bus_fslmc > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_mempool_dpaa2 > endif # CONFIG_RTE_LIBRTE_DPAA2_PMD > > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_bus_dpaa > +endif It does not make sense. Please read it carefully. The same config condition is used twice. And the dependency should be on the same line as the PMD link above. The same mistake was done for DPAA2. Please fix it separately.