DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fix trailing whitespace.
Date: Wed, 11 Jun 2014 12:03:48 +0200	[thread overview]
Message-ID: <87655757.0nh8hPpYoP@xps13> (raw)
In-Reply-To: <20140606105032.GA1671@hmsreliant.think-freely.org>

> > This commit removes trailing whitespace from lines in files. Almost all
> > files are affected, as the BSD license copyright header had trailing
> > whitespace on 4 lines in it [hence the number of files reporting 8 lines
> > changed in the diffstat].
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

I've completed it with these changes:
	- remove spaces before tabs in libs
	- remove more trailing spaces in non-C files

Applied for version 1.7.0.

Some whitespaces and indentation errors are remaining, especially in examples.
But it can be fixed when examples will be updated.
I'm not a big fan of such patch. I prefer to take care of not adding new
spacing errors. So from now, trailing whitespaces, spaces before tabs
and wrong indentation should be tracked carefully in new patches.

Thanks
-- 
Thomas

  reply	other threads:[~2014-06-11 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03 23:42 Bruce Richardson
2014-06-06 10:50 ` Neil Horman
2014-06-11 10:03   ` Thomas Monjalon [this message]
2014-06-11 15:24     ` Richardson, Bruce
2014-06-11 15:46       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87655757.0nh8hPpYoP@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).