DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: dev@dpdk.org
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: [dpdk-dev] [PATCH 1/3] net/mlx5: use flow API default masks
Date: Tue, 31 Jan 2017 17:02:46 +0100	[thread overview]
Message-ID: <8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com> (raw)

Default masks were introduced in the API after its implementation in this
PMD.

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 drivers/net/mlx5/mlx5_flow.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 42a12e8..4917f79 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -164,6 +164,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 			.dst.addr_bytes = "\xff\xff\xff\xff\xff\xff",
 			.src.addr_bytes = "\xff\xff\xff\xff\xff\xff",
 		},
+		.default_mask = &rte_flow_item_eth_mask,
 		.mask_sz = sizeof(struct rte_flow_item_eth),
 		.convert = mlx5_flow_create_eth,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_eth),
@@ -175,6 +176,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 		.mask = &(const struct rte_flow_item_vlan){
 			.tci = -1,
 		},
+		.default_mask = &rte_flow_item_vlan_mask,
 		.mask_sz = sizeof(struct rte_flow_item_vlan),
 		.convert = mlx5_flow_create_vlan,
 		.dst_sz = 0,
@@ -191,12 +193,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 				.next_proto_id = -1,
 			},
 		},
-		.default_mask = &(const struct rte_flow_item_ipv4){
-			.hdr = {
-				.src_addr = -1,
-				.dst_addr = -1,
-			},
-		},
+		.default_mask = &rte_flow_item_ipv4_mask,
 		.mask_sz = sizeof(struct rte_flow_item_ipv4),
 		.convert = mlx5_flow_create_ipv4,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_ipv4_ext),
@@ -221,6 +218,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 				},
 			},
 		},
+		.default_mask = &rte_flow_item_ipv6_mask,
 		.mask_sz = sizeof(struct rte_flow_item_ipv6),
 		.convert = mlx5_flow_create_ipv6,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_ipv6),
@@ -234,6 +232,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 				.dst_port = -1,
 			},
 		},
+		.default_mask = &rte_flow_item_udp_mask,
 		.mask_sz = sizeof(struct rte_flow_item_udp),
 		.convert = mlx5_flow_create_udp,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_tcp_udp),
@@ -246,6 +245,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 				.dst_port = -1,
 			},
 		},
+		.default_mask = &rte_flow_item_tcp_mask,
 		.mask_sz = sizeof(struct rte_flow_item_tcp),
 		.convert = mlx5_flow_create_tcp,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_tcp_udp),
@@ -256,6 +256,7 @@ static const struct mlx5_flow_items mlx5_flow_items[] = {
 		.mask = &(const struct rte_flow_item_vxlan){
 			.vni = "\xff\xff\xff",
 		},
+		.default_mask = &rte_flow_item_vxlan_mask,
 		.mask_sz = sizeof(struct rte_flow_item_vxlan),
 		.convert = mlx5_flow_create_vxlan,
 		.dst_sz = sizeof(struct ibv_exp_flow_spec_tunnel),
-- 
2.1.4

             reply	other threads:[~2017-01-31 16:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 16:02 Nelio Laranjeiro [this message]
2017-01-31 16:02 ` [dpdk-dev] [PATCH 2/3] net/mlx5: fix verification of mark action Nelio Laranjeiro
2017-01-31 16:02 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix flow rule creation if ports are stopped Nelio Laranjeiro
2017-02-01 11:04 ` [dpdk-dev] [PATCH 1/3] net/mlx5: use flow API default masks Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8772a5838ed3733da6749b333375e2a6aa6ea2ad.1485878361.git.nelio.laranjeiro@6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).