* [PATCH] argparse: fix parser callback type name
@ 2024-03-07 16:14 David Marchand
2024-03-07 17:50 ` Tyler Retzlaff
2024-03-08 0:49 ` fengchengwen
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2024-03-07 16:14 UTC (permalink / raw)
To: dev; +Cc: Chengwen Feng
All types exposed in a public header must be prefixed with rte_.
Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/argparse/rte_argparse.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/argparse/rte_argparse.h b/lib/argparse/rte_argparse.h
index 47e231bef9..5e5936f96c 100644
--- a/lib/argparse/rte_argparse.h
+++ b/lib/argparse/rte_argparse.h
@@ -144,7 +144,7 @@ struct rte_argparse_arg {
* @return
* 0 on success. Otherwise negative value is returned.
*/
-typedef int (*arg_parser_t)(uint32_t index, const char *value, void *opaque);
+typedef int (*rte_arg_parser_t)(uint32_t index, const char *value, void *opaque);
/**
* A structure used to hold argparse's configuration.
@@ -161,7 +161,7 @@ struct rte_argparse {
/** Whether exit when error. */
bool exit_on_error;
/** User callback for parsing arguments. */
- arg_parser_t callback;
+ rte_arg_parser_t callback;
/** Opaque which used to invoke callback. */
void *opaque;
/** Reserved field used for future extension. */
--
2.44.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] argparse: fix parser callback type name
2024-03-07 16:14 [PATCH] argparse: fix parser callback type name David Marchand
@ 2024-03-07 17:50 ` Tyler Retzlaff
2024-03-21 17:20 ` Thomas Monjalon
2024-03-08 0:49 ` fengchengwen
1 sibling, 1 reply; 4+ messages in thread
From: Tyler Retzlaff @ 2024-03-07 17:50 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Chengwen Feng
On Thu, Mar 07, 2024 at 05:14:02PM +0100, David Marchand wrote:
> All types exposed in a public header must be prefixed with rte_.
>
> Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] argparse: fix parser callback type name
2024-03-07 17:50 ` Tyler Retzlaff
@ 2024-03-21 17:20 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2024-03-21 17:20 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Chengwen Feng, Tyler Retzlaff
07/03/2024 18:50, Tyler Retzlaff:
> On Thu, Mar 07, 2024 at 05:14:02PM +0100, David Marchand wrote:
> > All types exposed in a public header must be prefixed with rte_.
> >
> > Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] argparse: fix parser callback type name
2024-03-07 16:14 [PATCH] argparse: fix parser callback type name David Marchand
2024-03-07 17:50 ` Tyler Retzlaff
@ 2024-03-08 0:49 ` fengchengwen
1 sibling, 0 replies; 4+ messages in thread
From: fengchengwen @ 2024-03-08 0:49 UTC (permalink / raw)
To: David Marchand, dev
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/3/8 0:14, David Marchand wrote:
> All types exposed in a public header must be prefixed with rte_.
>
> Fixes: e3e579f5bab5 ("argparse: introduce argparse library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/argparse/rte_argparse.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/argparse/rte_argparse.h b/lib/argparse/rte_argparse.h
> index 47e231bef9..5e5936f96c 100644
> --- a/lib/argparse/rte_argparse.h
> +++ b/lib/argparse/rte_argparse.h
> @@ -144,7 +144,7 @@ struct rte_argparse_arg {
> * @return
> * 0 on success. Otherwise negative value is returned.
> */
> -typedef int (*arg_parser_t)(uint32_t index, const char *value, void *opaque);
> +typedef int (*rte_arg_parser_t)(uint32_t index, const char *value, void *opaque);
>
> /**
> * A structure used to hold argparse's configuration.
> @@ -161,7 +161,7 @@ struct rte_argparse {
> /** Whether exit when error. */
> bool exit_on_error;
> /** User callback for parsing arguments. */
> - arg_parser_t callback;
> + rte_arg_parser_t callback;
> /** Opaque which used to invoke callback. */
> void *opaque;
> /** Reserved field used for future extension. */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-21 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 16:14 [PATCH] argparse: fix parser callback type name David Marchand
2024-03-07 17:50 ` Tyler Retzlaff
2024-03-21 17:20 ` Thomas Monjalon
2024-03-08 0:49 ` fengchengwen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).