From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1832A0C4D; Wed, 1 Sep 2021 13:42:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50C5740140; Wed, 1 Sep 2021 13:42:55 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4E9B64013F for ; Wed, 1 Sep 2021 13:42:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="205948815" X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="205948815" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2021 04:42:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="645710160" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 01 Sep 2021 04:42:52 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 1 Sep 2021 04:42:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 1 Sep 2021 04:42:52 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 1 Sep 2021 04:42:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kyqmtMqDFMJIusfUow2Erh0bm4izmKphNPGL4u2XU1ji+Eo4AgduNN8Cfpewlk0VxDUZt/Fl+TjB2Wy2fE3s9tI1A01Ui5MEG8vKYDe6BjEMg0RYPc+yMud35prOaSj9JIONnLguwv/cQ1IEY8A/RTXML5+H4n/xyYJYWh2uAVY/1D/VTa9GJBd/3PYqkCDVk+GqVWixdgbfKRfMP0EEAGaiSniGnZAJnNnwlfV5bMgag0M7DzpfUTXh85fA/GiXvtgMmR+b7gNdPrJgBTn2V09JaXIBg0NNbFYbVT9zGCkSZQa6hBkKmR6d9NBOVpd9/vHR2zlAZ306OXujYG/OtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bzJ50IdPpVagFEv1Tm4fiEBk/RmQCJeVgJsX0EcZbI=; b=P8vFQGvJhG/P8lmlfMKIrQD3NjZlYS0U1CiPZOJaT1CS52fSenRu/+WMJ5n2imlc0fhTTl2sL+KYy15J4MII9El6T7oIREjRUG1H0zE+E7MRo/tU2lUo7oWrNMbGXu2s+kKqMlk5SWKTPMQ/CzXiVCBKlDjOQ2sONFIWeRPpksQXQ+QhlBAI6Fs23IL6k/K3HXuncrTeC3YxQj8rMGsXkfsShY2w759Giv0XjcjuzkZWkJPiDr+UoDsrEFd6s5AViCV0ghlJtk6mZnE3gIStfZcjjwjSSWuhGfbamtR/Kk6OepU6ctfKTPEmS/pzg/zBrK3T+HTAXKtt6d5HtyZTTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bzJ50IdPpVagFEv1Tm4fiEBk/RmQCJeVgJsX0EcZbI=; b=ary1WlXFltOzffqlyl5L+xJUikGz0Ox8iqvXT7jE/WKPQdKVqb69tsOL7CVretypFneNo+vn52E15WEL+rYdP/vQoWwzj5rBv2bgB1gXCTloo9TQ3Wycm1ZDP2MDQ8cjpF2t8+g3YnIRSiAptIdX2DiWddfxIdlYfhy2Xa/3/fA= Authentication-Results: ashroe.eu; dkim=none (message not signed) header.d=none;ashroe.eu; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4952.namprd11.prod.outlook.com (2603:10b6:510:40::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.19; Wed, 1 Sep 2021 11:42:37 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.020; Wed, 1 Sep 2021 11:42:37 +0000 To: "Burakov, Anatoly" , "Ding, Xuan" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Hu, Jiayu" , "Richardson, Bruce" , Thomas Monjalon , "Ray Kinsella" References: <20210831131039.29964-1-xuan.ding@intel.com> <2c9fc397-df61-2ef6-0cce-db5dbbb1c952@intel.com> <926d7065-481f-b84e-1d05-bdeebd31d6ea@intel.com> <032e666a-9ada-f4c0-36bc-ad9b5fac4359@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8779d165-6e98-a294-9f4b-a6ce76d9c77a@intel.com> Date: Wed, 1 Sep 2021 12:42:31 +0100 In-Reply-To: <032e666a-9ada-f4c0-36bc-ad9b5fac4359@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR05CA0002.eurprd05.prod.outlook.com (2603:10a6:10:1da::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR05CA0002.eurprd05.prod.outlook.com (2603:10a6:10:1da::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 11:42:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 096d57a6-ff06-4f7f-c740-08d96d3d98c8 X-MS-TrafficTypeDiagnostic: PH0PR11MB4952: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nTJEl7LSAolcM8yPCnfyTWCmuLj/gVGbf+rio6hUq9oAMvzrRSJoLY/MRzVi8AofEaPONSd7pvBv6DVdEuVtXuDfJuEEEZh93T4aKJgICAcDrF++5uPDVfTSSL3zny5kkAB+e2S8D9qKt3Ftc8ZxoZjtPVwO6ZLohuwAsbCpSmoUFYduicGzvHDSYioX3CAyACzFOxx5kI6quH4Iur9wZmkDT7TawlWwcXgFDXJiml7s4AC5pWBqhYu866DePhfAGWkgEU7qp4Y4UMJlKia98ItGGx1FBZLjn7adoDDijdxSdJN70CZEPpobUz1huhVJeVyVkU8GkpP4TmUDP234Bo6DlI3z/mi1KauehTtBjvL9PDgP7LOuSQRi1NLtm3RbOnHULjW0x3QFh+1k8p8F0I98+fqRaRaIkW9rKj3O5LKCZ7za5bAnXbFUfDfttI6+eDhFHfAffzVgdPSQzfd8jdTJ3YYw7FK68ZnEHS7fCnGkRQf9ZAaezknMtTvLUyfs+MmO/z6dCRwdksgpbyz8p01u0hU3w4ULUxzIaLyRsEA9Upfn3fPSupreDR+4ttS3IcPEnv7INp2B8tXGX3HFjYh0Q2tO5+MiGMIc3AUFZE4aM0/uzAp8IOXgIBfJEjIycyLNbGu/EPFH/Khzklyz3D4MOsZotV08RsCz3RQMkereb5kvCy6O/NYzlicrGwHn89Gj9HH+jIv9pKOfIJELWmk+pyKVxrkt5weHswK+A7YJzRsf4a27NKFdykG3934rcdri1X/a/NUju2b8L3t0Hh52Yf1D9VU0awKfI8h1pJU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(4326008)(2906002)(8676002)(8936002)(26005)(83380400001)(5660300002)(53546011)(44832011)(6486002)(31686004)(66476007)(66556008)(38100700002)(956004)(66946007)(31696002)(2616005)(478600001)(86362001)(36756003)(316002)(54906003)(16576012)(186003)(966005)(110136005)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRrUmV4YUNHQ2s4UHhPMlNWQ0Fkclc1dW9pL2hHOG5hWUJOcGpucFV0Tnlx?= =?utf-8?B?eVcvMEd0RDhqRE0yRW5PN3JUY2RWcHRnVkxCOHNxOFlXYTdORWpaRmIvVHFG?= =?utf-8?B?aTBLdEp5cldRNEJYY0xFRlY1YXEwc2trWkZldDk4Z1JvcUJ5NnJFbU5mOUdO?= =?utf-8?B?eDlnbHBHKzFmbFEza25vWitRT1I1dllMWnR5Y1NXbGloSXMxQU0yemJjTCt3?= =?utf-8?B?MnAxLzRyMHdvNEZXYW40NWdOUlJSV0IzRWw1dFNJZnJyVEU2VS9GZ3NtMlZl?= =?utf-8?B?SkFkTjhqRkhSZFZSU2gwSnk3bjdjWkt2UVEzZjk4b3NFSmVsNStBY294Vzhp?= =?utf-8?B?ZmdEbGZScFBXQ2I0Z0ZFNWpoNHdscmhkU3ZRaFZWSVI3WDZOOFNIQ01Lbkg4?= =?utf-8?B?MWxFOHAwdVRFVGlSZ2VSUmU2MHF2WnI2MklWNHozaEhzc0x6ZktSeGF6TUR4?= =?utf-8?B?MmZVKy9saEFJL2I3L2Zsb1pvdGZTZStNUWN2MEdtVUtLa3JPNkJNY3FISmQ2?= =?utf-8?B?YlRJTTd2czgweTBSemtPaUk4UkxpT01OUGVGL0pPODgzazF2dWVvclVBQmdI?= =?utf-8?B?RDhXR3BHVk1nUkREZEtFQ2I0MTZXbDFxTHpXdllIcThRKzhNRUVYTDJ1Z1Jt?= =?utf-8?B?R1pxRGRkL0pZZ1BpSElsN3dlcXpJb0t6MDByajh5VEZXTFEweHJWcFN5bEMx?= =?utf-8?B?TFFiWHZ6TFNUWHluYTVSaTM4bHBtY0lvclloNmJMK1BhNDAxSGxjazcrSWRO?= =?utf-8?B?UFhOcXNXMG9OeG9jUTFmVGdzM0pxUFBwZEtlM2w5alhwbVFVRUpVVXpIQnZD?= =?utf-8?B?VW02RTBFTWVQRUYvc3NBSEdjYzNmYllyNlZjOGVYMmwwZTg2eWthZllmN016?= =?utf-8?B?bVk5bWJZb3FNQlYrL2wvR0ExbkRzRXJod3QxMzdlRGlqMTVXcEg5S29pTy9o?= =?utf-8?B?T2lMaGk5SThFbGpaVDJYNW42WlAzQ1lIRlRySmRucXFDYy9xS0RGTEdCM2V4?= =?utf-8?B?L0FvdkVqejNIMXR0azZia3ZEZ05Tb0pOWGZYOGI0S2xKZkR3b3lkYWVoK3pI?= =?utf-8?B?ckhMaERleFBzZCthVHh5ZkpPMGJvdEdnQlZ3L1hJT1pEdUxkWVNNRThmWTVV?= =?utf-8?B?YUdoSWhyZWFiU2xCVlJ1S1B1cDVXaVpVN0JLN1crTDYvWlNHL3JrY2VSSVZD?= =?utf-8?B?M3ZDWnM5L1hjKzBPWm1BL1UxbEREbHlqTHpVNlQ1eWdyaXlRYTNWUnYzTFla?= =?utf-8?B?TGVOQkhkVVdmU3hnVDVoUm5rVzNEUGM5Vis2ODFLb0FuK1h6OFFqUkVvbVd6?= =?utf-8?B?cVJ0K3hjRWFCV1lzNk05Tkl5ZWdVZmtmWU5kOWNHZDFselRpY0lnMG9iNmRn?= =?utf-8?B?c2I5RlZvY2FMc0xxNTNoY2RQVENaSk8rYlptZy9OMElZQ1EzWUJPVWxSU2hX?= =?utf-8?B?M2t4S283VGJJaFBmSGwvbGNkYytJV0dGM095RWlsMDJxV21vNEh4Y2ZHQmRi?= =?utf-8?B?a0VQMWFMQ21tbzNZeDhMOWViWVY2UWhRZm1UMGV5cTdXMzZGQkxWcm1tVFBQ?= =?utf-8?B?bEI5S3laRzBERUpXMWpteWRwNjZvdWtJNlJ2cW9SYklqSi9ZdEZEaEtobmhx?= =?utf-8?B?Qkhzd0wwN3BjVmpoM2JBUW5xQkVaU25DbFZlSHR0YnYxeXZCYk9xOEh5ZzJK?= =?utf-8?B?d3FGNXJVMDNqT3VnRE1Ca3h2WHBab3paYTRZZFIzWGdnUTFleHRFaDY4T2NN?= =?utf-8?Q?k603yZv7Hl5aQRDXscqSWYp+7sq6TyEuk4t05R2?= X-MS-Exchange-CrossTenant-Network-Message-Id: 096d57a6-ff06-4f7f-c740-08d96d3d98c8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 11:42:37.4478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iyEFAqXNudzrF6EbjqxdGVocNx6G8MPLLjgup4EVWLnxjHOr8cciO+miMdY4n7aVhoOdliqXVp19agVy3dXNGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4952 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/1/2021 12:01 PM, Burakov, Anatoly wrote: > On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: >> On 9/1/2021 2:41 AM, Ding, Xuan wrote: >>> Hi Ferruh, >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Wednesday, September 1, 2021 12:01 AM >>>> To: Ding, Xuan ; dev@dpdk.org; Burakov, Anatoly >>>> >>>> Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Hu, >>>> Jiayu ; Richardson, Bruce >>>> Subject: Re: [PATCH] doc: announce change in vfio dma mapping >>>> >>>> On 8/31/2021 2:10 PM, Xuan Ding wrote: >>>>> Currently, the VFIO subsystem will compact adjacent DMA regions for the >>>>> purposes of saving space in the internal list of mappings. This has a >>>>> side effect of compacting two separate mappings that just happen to be >>>>> adjacent in memory. Since VFIO implementation on IA platforms also does >>>>> not allow partial unmapping of memory mapped for DMA, the current >>>> DPDK >>>>> VFIO implementation will prevent unmapping of accidentally adjacent >>>>> maps even though it could have been unmapped [1]. >>>>> >>>>> The proper fix for this issue is to change the VFIO DMA mapping API to >>>>> also include page size, and always map memory page-by-page. >>>>> >>>>> [1] https://mails.dpdk.org/archives/dev/2021-July/213493.html >>>>> >>>>> Signed-off-by: Xuan Ding >>>>> --- >>>>>   doc/guides/rel_notes/deprecation.rst | 3 +++ >>>>>   1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>> b/doc/guides/rel_notes/deprecation.rst >>>>> index 76a4abfd6b..1234420caf 100644 >>>>> --- a/doc/guides/rel_notes/deprecation.rst >>>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>>> @@ -287,3 +287,6 @@ Deprecation Notices >>>>>     reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and >>>> other >>>>>     information from the crypto/security operation. This field will be used to >>>>>     communicate events such as soft expiry with IPsec in lookaside mode. >>>>> + >>>>> +* vfio: the functions `rte_vfio_container_dma_map` will be amended to >>>>> +  include page size. This change is targeted for DPDK 22.02. >>>>> >>>> >>>> Is this means adding a new parameter to API? >>>> If so this is an ABI/API break and we can't do this change in the 22.02. >>> >>> Our original plan is add a new parameter in order not to use a new function >>> name, so you mean, any changes to the API can only be done in the LTS version? >>> If so, we can only add a new API and retire the old one in 22.11. >>> >> >> We can add a new API anytime. Adding new parameter to an existing API can be >> done on the ABI break release. > > So, 22.11 then? > Yes. >> >> You can add the new API in this release, and start using it. >> And mark the old API as deprecated in this release. This lets existing binaries >> to keep using it, but app needs to switch to new API for compilation. >> Old API can be removed on 22.11, and you will need a deprecation notice before >> 22.11 for it. >> >> Is above plan works for you? >> > > We have slightly rethought our approach, and the functionality that Xuan > requires does not rely on this API. They can, for all intents and purposes, be > considered unrelated issues. > > I still think it's a good idea to update the API that way, so I would like to do > that, and if we have to wait until 22.11 to fix it, I'm OK with that. Since > there no longer is any urgency here, it's acceptable to wait for the next LTS to > break it. > Got it. As far as I understand, main motivation in techboard decision was to prevent the ABI break as much as possible (main reason of decision wasn't deprecation notice being late). But if the correct thing to do is to rename the API (and break the ABI), I don't see the benefit to wait one more year, it is just delaying the impact and adding overhead to us. I am for being pragmatic and doing the change in this release if API rename is better option, perhaps we can visit the issue again in techboard. Can you please describe why renaming API is better option, comparing to adding new API with new parameter? Thanks, ferruh