DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Betts, Ian" <ian.betts@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread
Date: Thu, 3 Dec 2015 17:18:42 +0000	[thread overview]
Message-ID: <877C1F8553E92F43898365570816082F35C0BA07@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20151203083230.605c9d1e@xeon-e3>



-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org] 
Sent: Thursday, December 3, 2015 4:33 PM
To: Betts, Ian
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread

On Thu,  3 Dec 2015 09:28:24 +0000
ibetts <ian.betts@intel.com> wrote:

>> +#define NB_MBUF RTE_MAX(\
>> +		(nb_ports*nb_rx_queue*RTE_TEST_RX_DESC_DEFAULT +       \
>> +		nb_ports*nb_lcores*MAX_PKT_BURST +                     \
>> +		nb_ports*n_tx_queue*RTE_TEST_TX_DESC_DEFAULT +         \
>> +		nb_lcores*MEMPOOL_CACHE_SIZE),                         \
>> +		(unsigned)8192)

> function or at least add white space.

This is code inherited from the legacy l3fwd app from which this app  is derived.
I would prefer to leave it as is for consistencies sake.

  reply	other threads:[~2015-12-03 17:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03  9:28 [dpdk-dev] [PATCH v5 0/4] examples: add performance-thread ibetts
2015-12-03  9:28 ` [dpdk-dev] [PATCH v5 1/4] doc: add sample application guide for performance-thread ibetts
2015-12-03  9:28 ` [dpdk-dev] [PATCH v5 2/4] examples: add lthread subsystem " ibetts
2015-12-03 16:31   ` Stephen Hemminger
2015-12-03 16:46     ` Bruce Richardson
2015-12-03 17:15       ` Betts, Ian
2015-12-03  9:28 ` [dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread ibetts
2015-12-03 16:32   ` Stephen Hemminger
2015-12-03 17:18     ` Betts, Ian [this message]
2015-12-03  9:28 ` [dpdk-dev] [PATCH v5 4/4] examples: add pthread_shim example to performance thread ibetts
2015-12-03  9:48 ` [dpdk-dev] [PATCH v5 0/4] examples: add performance-thread Kulasek, TomaszX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877C1F8553E92F43898365570816082F35C0BA07@IRSMSX103.ger.corp.intel.com \
    --to=ian.betts@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).