From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 397DD91C8 for ; Fri, 4 Dec 2015 23:26:05 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 04 Dec 2015 14:26:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,382,1444719600"; d="scan'208";a="7755578" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga004.fm.intel.com with ESMTP; 04 Dec 2015 14:26:04 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX153.ger.corp.intel.com ([169.254.9.208]) with mapi id 14.03.0248.002; Fri, 4 Dec 2015 22:26:02 +0000 From: "Betts, Ian" To: "dev@dpdk.org" Thread-Topic: dev Digest, Vol 69, Issue 101 Thread-Index: AQHRLsVbqJA/q8O/oUO6UFfX8ixu9567Z1Dw Date: Fri, 4 Dec 2015 22:26:00 +0000 Message-ID: <877C1F8553E92F43898365570816082F35C0BD2D@IRSMSX103.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI1OTk3YzExMS04MmVjLTQzMmMtYmJlMC0yM2M5NDhlZjAyYWQiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJabVJOVFY5bDZ6aEVsZHFyRThYYjBMK2hLc0F6anJsQmdUKzZBaEc0QUtRPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] dev Digest, Vol 69, Issue 101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 22:26:06 -0000 Message: 1 Date: Fri, 04 Dec 2015 19:33:47 +0100 From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Ian Betts Subject: Re: [dpdk-dev] [PATCH v8 0/4] examples: add performance-thread Message-ID: <1850494.rdblc2vbpm@xps13> Content-Type: text/plain; charset=3D"us-ascii" > Yes, sure it is too late to have enough discussions in 2.2 timeframe. Please see my response to Stephens questions/concerns ------------------------------ Message: 2 Date: Fri, 4 Dec 2015 19:36:09 +0100 From: Andriy Berestovskyy To: Stephen Hemminger Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH 6/8] bond: handle slaves with fewer queues than bonding device Message-ID: Content-Type: text/plain; charset=3DUTF-8 Hi guys, I'm not quite sure if we can support less TX queues on a slave that easy: > queue_id =3D bond_slave_txqid(internals, i, bd_tx_q->queue_id);=20 > num_tx_slave =3D rte_eth_tx_burst(slaves[i], queue_id, > slave_bufs[i], slave_nb_pkts[i]); It seems that two different lcores might end up writing to the same slave q= ueue at the same time, isn't it? Regards, Andriy On Fri, Dec 4, 2015 at 6:14 PM, Stephen Hemminger wrote: > From: Eric Kinzie > > In the event that the bonding device has a greater number of tx and/or=20 > rx queues than the slave being added, track the queue limits of the slave= . > On receive, ignore queue identifiers beyond what the slave interface=20 > can support. During transmit, pick a different queue id to use if the=20 > intended queue is not available on the slave. > > Signed-off-by: Eric Kinzie > Signed-off-by: Stephen Hemminger > --- > drivers/net/bonding/rte_eth_bond_api.c | 6 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 141 +++++++++++++++++++++++= ++---- > drivers/net/bonding/rte_eth_bond_private.h | 5 +- > 3 files changed, 129 insertions(+), 23 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_api.c=20 > b/drivers/net/bonding/rte_eth_bond_api.c > index 630a461..64058ff 100644 > --- a/drivers/net/bonding/rte_eth_bond_api.c > +++ b/drivers/net/bonding/rte_eth_bond_api.c > @@ -340,11 +340,11 @@ __eth_bond_slave_add_lock_free(uint8_t=20 > bonded_port_id, uint8_t slave_port_id) > > slave_eth_dev =3D &rte_eth_devices[slave_port_id]; > > - /* Add slave details to bonded device */ > - slave_add(internals, slave_eth_dev); > - > rte_eth_dev_info_get(slave_port_id, &dev_info); > > + /* Add slave details to bonded device */ > + slave_add(internals, slave_eth_dev, &dev_info); > + > /* We need to store slaves reta_size to be able to synchronize RE= TA for all > * slave devices even if its sizes are different. > */ > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c=20 > b/drivers/net/bonding/rte_eth_bond_pmd.c > index 77582dd..868e66b 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -76,6 +76,47 @@ get_vlan_offset(struct ether_hdr *eth_hdr, uint16_t *p= roto) > return vlan_offset; > } > > +static uint8_t > +bond_active_slaves_by_rxqid(struct bond_dev_private *internals, int queu= e_id, > + uint8_t slaves[]) > +{ > + struct bond_slave_details *slave_details; > + uint8_t num_of_slaves; > + uint8_t i =3D 0; > + > + num_of_slaves =3D internals->active_slave_count; > + memcpy(slaves, internals->active_slaves, > + sizeof(internals->active_slaves[0]) *=20 > + num_of_slaves); > + > + if (num_of_slaves < 1 || internals->kvlist) > + return num_of_slaves; > + > + /* remove slaves that don't have a queue numbered "queue_id" */ > + while (i < num_of_slaves) { > + slave_details =3D &internals->slaves[i]; > + if (unlikely(queue_id >=3D slave_details->nb_rx_queues)) = { > + slaves[i] =3D slaves[num_of_slaves-1]; > + num_of_slaves--; > + } else > + i++; > + } > + > + return num_of_slaves; > +} > + > +static int > +bond_slave_txqid(struct bond_dev_private *internals, uint8_t slave_id, > + int queue_id) > +{ > + struct bond_slave_details *slave_details; > + > + if (internals->kvlist) > + return queue_id; > + > + slave_details =3D &internals->slaves[slave_id]; > + return queue_id % slave_details->nb_tx_queues; } > + > static uint16_t > bond_ethdev_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t=20 > nb_pkts) { @@ -83,6 +124,8 @@ bond_ethdev_rx_burst(void *queue,=20 > struct rte_mbuf **bufs, uint16_t nb_pkts) > > uint16_t num_rx_slave =3D 0; > uint16_t num_rx_total =3D 0; > + uint8_t slaves[RTE_MAX_ETHPORTS]; > + uint8_t num_of_slaves; > > int i; > > @@ -91,11 +134,13 @@ bond_ethdev_rx_burst(void *queue, struct rte_mbuf=20 > **bufs, uint16_t nb_pkts) > > internals =3D bd_rx_q->dev_private; > > + num_of_slaves =3D bond_active_slaves_by_rxqid(internals, bd_rx_q-= >queue_id, > + slaves); > > - for (i =3D 0; i < internals->active_slave_count && nb_pkts; i++) = { > + for (i =3D 0; i < num_of_slaves && nb_pkts; i++) { > /* Offset of pointer to *bufs increases as packets are re= ceived > * from other slaves */ > - num_rx_slave =3D rte_eth_rx_burst(internals->active_slave= s[i], > + num_rx_slave =3D rte_eth_rx_burst(slaves[i], > bd_rx_q->queue_id, bufs + num_rx_total, n= b_pkts); > if (num_rx_slave) { > num_rx_total +=3D num_rx_slave; @@ -117,8=20 > +162,13 @@ bond_ethdev_rx_burst_active_backup(void *queue, struct=20 > rte_mbuf **bufs, > > internals =3D bd_rx_q->dev_private; > > - return rte_eth_rx_burst(internals->current_primary_port, > - bd_rx_q->queue_id, bufs, nb_pkts); > + uint8_t active_slave =3D internals->current_primary_port; > + struct rte_eth_dev *dev =3D &rte_eth_devices[active_slave]; > + > + if (bd_rx_q->queue_id >=3D dev->data->nb_rx_queues) > + return 0; > + > + return rte_eth_rx_burst(active_slave, bd_rx_q->queue_id, bufs,=20 > + nb_pkts); > } > > static uint16_t > @@ -144,9 +194,9 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_m= buf **bufs, > rte_eth_macaddr_get(internals->port_id, &bond_mac); > /* Copy slave list to protect against slave up/down changes durin= g tx > * bursting */ > - slave_count =3D internals->active_slave_count; > - memcpy(slaves, internals->active_slaves, > - sizeof(internals->active_slaves[0]) * slave_count= ); > + > + slave_count =3D bond_active_slaves_by_rxqid(internals, bd_rx_q->q= ueue_id, > + slaves); > > for (i =3D 0; i < slave_count && num_rx_total < nb_pkts; i++) { > j =3D num_rx_total; > @@ -401,6 +451,7 @@ bond_ethdev_tx_burst_round_robin(void *queue,=20 > struct rte_mbuf **bufs, > > static int slave_idx =3D 0; > int i, cslave_idx =3D 0, tx_fail_total =3D 0; > + int queue_id; > > bd_tx_q =3D (struct bond_tx_queue *)queue; > internals =3D bd_tx_q->dev_private; @@ -427,7 +478,9 @@=20 > bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs, > /* Send packet burst on each slave device */ > for (i =3D 0; i < num_of_slaves; i++) { > if (slave_nb_pkts[i] > 0) { > - num_tx_slave =3D rte_eth_tx_burst(slaves[i], bd_t= x_q->queue_id, > + queue_id =3D bond_slave_txqid(internals, i, > + bd_tx_q->queue_id); > + num_tx_slave =3D rte_eth_tx_burst(slaves[i],=20 > + queue_id, > slave_bufs[i],=20 > slave_nb_pkts[i]); > > /* if tx burst fails move packets to end of=20 > bufs */ @@ -453,14 +506,27 @@ bond_ethdev_tx_burst_active_backup(void=20 > *queue, { > struct bond_dev_private *internals; > struct bond_tx_queue *bd_tx_q; > + int queue_id; > + int i; > + uint8_t num_of_slaves; > + uint8_t slaves[RTE_MAX_ETHPORTS]; > > bd_tx_q =3D (struct bond_tx_queue *)queue; > internals =3D bd_tx_q->dev_private; > > - if (internals->active_slave_count < 1) > + num_of_slaves =3D internals->active_slave_count; > + memcpy(slaves, internals->active_slaves, > + sizeof(internals->active_slaves[0]) *=20 > + num_of_slaves); > + > + if (num_of_slaves < 1) > return 0; > > - return rte_eth_tx_burst(internals->current_primary_port, bd_tx_q-= >queue_id, > + for (i =3D 0; i < num_of_slaves; i++) > + if (slaves[i] =3D=3D internals->current_primary_port) > + break; > + > + queue_id =3D bond_slave_txqid(internals, i, bd_tx_q->queue_id); > + return rte_eth_tx_burst(internals->current_primary_port,=20 > + queue_id, > bufs, nb_pkts); } > > @@ -696,6 +762,7 @@ bond_ethdev_tx_burst_tlb(void *queue, struct rte_mbuf= **bufs, uint16_t nb_pkts) > struct ether_hdr *ether_hdr; > struct ether_addr primary_slave_addr; > struct ether_addr active_slave_addr; > + int queue_id; > > if (num_of_slaves < 1) > return num_tx_total; > @@ -725,7 +792,8 @@ bond_ethdev_tx_burst_tlb(void *queue, struct=20 > rte_mbuf **bufs, uint16_t nb_pkts) #endif > } > > - num_tx_total +=3D rte_eth_tx_burst(slaves[i], bd_tx_q->qu= eue_id, > + queue_id =3D bond_slave_txqid(internals, i, bd_tx_q->queu= e_id); > + num_tx_total +=3D rte_eth_tx_burst(slaves[i], queue_id, > bufs + num_tx_total, nb_pkts -=20 > num_tx_total); > > if (num_tx_total =3D=3D nb_pkts) @@ -903,6 +971,7 @@=20 > bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bufs, > uint16_t num_tx_total =3D 0, num_tx_slave =3D 0, tx_fail_total = =3D=20 > 0; > > int i, op_slave_id; > + int queue_id; > > struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts]; > uint16_t slave_nb_pkts[RTE_MAX_ETHPORTS] =3D { 0 }; @@ -931,7=20 > +1000,9 @@ bond_ethdev_tx_burst_balance(void *queue, struct rte_mbuf **bu= fs, > /* Send packet burst on each slave device */ > for (i =3D 0; i < num_of_slaves; i++) { > if (slave_nb_pkts[i] > 0) { > - num_tx_slave =3D rte_eth_tx_burst(slaves[i], bd_t= x_q->queue_id, > + queue_id =3D bond_slave_txqid(internals, i, > + bd_tx_q->queue_id); > + num_tx_slave =3D rte_eth_tx_burst(slaves[i],=20 > + queue_id, > slave_bufs[i],=20 > slave_nb_pkts[i]); > > /* if tx burst fails move packets to end of=20 > bufs */ @@ -977,6 +1048,8 @@ bond_ethdev_tx_burst_8023ad(void *queue, str= uct rte_mbuf **bufs, > /* Slow packets placed in each slave */ > uint8_t slave_slow_nb_pkts[RTE_MAX_ETHPORTS] =3D { 0 }; > > + int queue_id; > + > bd_tx_q =3D (struct bond_tx_queue *)queue; > internals =3D bd_tx_q->dev_private; > > @@ -1022,7 +1095,8 @@ bond_ethdev_tx_burst_8023ad(void *queue, struct rte= _mbuf **bufs, > if (slave_nb_pkts[i] =3D=3D 0) > continue; > > - num_tx_slave =3D rte_eth_tx_burst(slaves[i], bd_tx_q->que= ue_id, > + queue_id =3D bond_slave_txqid(internals, i, bd_tx_q->queu= e_id); > + num_tx_slave =3D rte_eth_tx_burst(slaves[i], queue_id, > slave_bufs[i], slave_nb_pkts[i]); > > /* If tx burst fails drop slow packets */ @@ -1057,6=20 > +1131,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf=20 > **bufs, > > int slave_tx_total[RTE_MAX_ETHPORTS]; > int i, most_successful_tx_slave =3D -1; > + int queue_id; > > bd_tx_q =3D (struct bond_tx_queue *)queue; > internals =3D bd_tx_q->dev_private; @@ -1076,7 +1151,8 @@=20 > bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs, > > /* Transmit burst on each active slave */ > for (i =3D 0; i < num_of_slaves; i++) { > - slave_tx_total[i] =3D rte_eth_tx_burst(slaves[i], bd_tx_q= ->queue_id, > + queue_id =3D bond_slave_txqid(internals, i, bd_tx_q->queu= e_id); > + slave_tx_total[i] =3D rte_eth_tx_burst(slaves[i],=20 > + queue_id, > bufs, nb_pkts); > > if (unlikely(slave_tx_total[i] < nb_pkts)) @@ -1298,9=20 > +1374,22 @@ int slave_configure(struct rte_eth_dev *bonded_eth_dev, > struct rte_eth_dev *slave_eth_dev) { > + struct bond_dev_private *internals; > struct bond_rx_queue *bd_rx_q; > struct bond_tx_queue *bd_tx_q; > + int slave_id; > + > + internals =3D bonded_eth_dev->data->dev_private; > > + for (slave_id =3D 0; slave_id < internals->slave_count; slave_id+= +) > + if (internals->slaves[slave_id].port_id =3D=3D > + slave_eth_dev->data->port_id) > + break; > + > + RTE_VERIFY(slave_id !=3D internals->slave_count); > + > + uint16_t nb_rx_queues =3D internals->slaves[slave_id].nb_rx_queue= s; > + uint16_t nb_tx_queues =3D=20 > + internals->slaves[slave_id].nb_tx_queues; > int errval; > uint16_t q_id; > > @@ -1331,8 +1420,7 @@ slave_configure(struct rte_eth_dev=20 > *bonded_eth_dev, > > /* Configure device */ > errval =3D rte_eth_dev_configure(slave_eth_dev->data->port_id, > - bonded_eth_dev->data->nb_rx_queues, > - bonded_eth_dev->data->nb_tx_queues, > + nb_rx_queues, nb_tx_queues, > &(slave_eth_dev->data->dev_conf)); > if (errval !=3D 0) { > RTE_BOND_LOG(ERR, "Cannot configure slave device: port=20 > %u , err (%d)", @@ -1343,7 +1431,7 @@ slave_configure(struct rte_eth_dev = *bonded_eth_dev, > /* Setup Rx Queues */ > /* Use existing queues, if any */ > for (q_id =3D slave_eth_dev->data->nb_rx_queues; > - q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { > + q_id < nb_rx_queues ; q_id++) { > bd_rx_q =3D (struct bond_rx_queue=20 > *)bonded_eth_dev->data->rx_queues[q_id]; > > errval =3D=20 > rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id, @@ -1361,7 +14= 49,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > /* Setup Tx Queues */ > /* Use existing queues, if any */ > for (q_id =3D slave_eth_dev->data->nb_tx_queues; > - q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { > + q_id < nb_tx_queues ; q_id++) { > bd_tx_q =3D (struct bond_tx_queue=20 > *)bonded_eth_dev->data->tx_queues[q_id]; > > errval =3D=20 > rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id, @@ -1440,7=20 > +1528,8 @@ bond_ethdev_slave_link_status_change_monitor(void *cb_arg); > > void > slave_add(struct bond_dev_private *internals, > - struct rte_eth_dev *slave_eth_dev) > + struct rte_eth_dev *slave_eth_dev, > + const struct rte_eth_dev_info *slave_dev_info) > { > struct bond_slave_details *slave_details =3D > &internals->slaves[internals->slave_count]; > @@ -1448,6 +1537,20 @@ slave_add(struct bond_dev_private *internals, > slave_details->port_id =3D slave_eth_dev->data->port_id; > slave_details->last_link_status =3D 0; > > + uint16_t bond_nb_rx_queues =3D > + rte_eth_devices[internals->port_id].data->nb_rx_queues; > + uint16_t bond_nb_tx_queues =3D > + =20 > + rte_eth_devices[internals->port_id].data->nb_tx_queues; > + > + slave_details->nb_rx_queues =3D > + bond_nb_rx_queues > slave_dev_info->max_rx_queues > + ? slave_dev_info->max_rx_queues > + : bond_nb_rx_queues; > + slave_details->nb_tx_queues =3D > + bond_nb_tx_queues > slave_dev_info->max_tx_queues > + ? slave_dev_info->max_tx_queues > + : bond_nb_tx_queues; > + > /* If slave device doesn't support interrupts then we need to ena= bled > * polling to monitor link status */ > if (!(slave_eth_dev->data->dev_flags & RTE_PCI_DRV_INTR_LSC))=20 > { diff --git a/drivers/net/bonding/rte_eth_bond_private.h=20 > b/drivers/net/bonding/rte_eth_bond_private.h > index 6c47a29..02f6de1 100644 > --- a/drivers/net/bonding/rte_eth_bond_private.h > +++ b/drivers/net/bonding/rte_eth_bond_private.h > @@ -101,6 +101,8 @@ struct bond_slave_details { > uint8_t link_status_poll_enabled; > uint8_t link_status_wait_to_complete; > uint8_t last_link_status; > + uint16_t nb_rx_queues; > + uint16_t nb_tx_queues; > /**< Port Id of slave eth_dev */ > struct ether_addr persisted_mac_addr; > > @@ -240,7 +242,8 @@ slave_remove(struct bond_dev_private *internals, > > void > slave_add(struct bond_dev_private *internals, > - struct rte_eth_dev *slave_eth_dev); > + struct rte_eth_dev *slave_eth_dev, > + const struct rte_eth_dev_info *slave_dev_info); > > uint16_t > xmit_l2_hash(const struct rte_mbuf *buf, uint8_t slave_count); > -- > 2.1.4 > -- Andriy Berestovskyy ------------------------------ Message: 3 Date: Fri, 04 Dec 2015 19:43:30 +0100 From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: fix objects/library order when linking Message-ID: <2454571.EZpaR9m7WP@xps13> Content-Type: text/plain; charset=3D"us-ascii" 2015-12-04 18:31, Adrien Mazarguil: > On Fri, Dec 04, 2015 at 06:11:03PM +0100, David Marchand wrote: > > The initial problem has been seen while building mlx4 pmd as a shared l= ibrary > > on Ubuntu 14.04 (gcc 4.8.4-2ubuntu1~14.04). > >=20 > > Resulting .so will lack the DT_NEEDED entry for libibverbs: > >=20 > > marchand@ubuntu1404:~/dpdk$ ldd ./build/lib/librte_pmd_mlx4.so > > linux-vdso.so.1 =3D> (0x00007fff87ebb000) > > libc.so.6 =3D> /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2ced21a000) > > /lib64/ld-linux-x86-64.so.2 (0x00007f2ced821000) > >=20 > > And trying to load it in testpmd triggers this error: > >=20 > > [...] > > EAL: librte_pmd_mlx4.so: undefined symbol: ibv_query_port > > [...] > >=20 > > After some strace, the problem comes from the --as-needed option passed= to the > > linker. > >=20 > > It is safer to specify libraries we depend on after the objects we are = linking > > into a shared library, especially when the linker is invoked with optio= ns like > > --as-needed. > >=20 > > Fixes: bef06a8a0655 ("mk: set library dependencies in shared object fil= e") > >=20 > > Signed-off-by: David Marchand > > --- > >=20 > > Changes since v1: > > - added some details in commitlog since Thomas does not like "safer" > > argument :-) Yes, that's better justified with these details :) > Obvious issue that did not show up in our tests under Debian. >=20 > Acked-by: Adrien Mazarguil Applied, thanks ------------------------------ Message: 4 Date: Fri, 04 Dec 2015 19:53:57 +0100 From: Thomas Monjalon To: Simon K?gstr?m Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications Message-ID: <4623746.AUJoGgWqRB@xps13> Content-Type: text/plain; charset=3D"us-ascii" > >> We have encountered a CPU where the AES-NI instruction set is disabled > >> due to export restrictions. Since the build machine and target machine > >> is different, using -native configs doesn't work, and on this CPU, the > >> application refuses to run due to the AES CPU flags being amiss. > >> > >> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper, > >> which allows us to add -mno-aes to the compile flags and resolve this > >> problem. > >> > >> Signed-off-by: Simon Kagstrom >=20 > Acked-by: Olivier Matz Applied, thanks End of dev Digest, Vol 69, Issue 101 ************************************