From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4F889282 for ; Tue, 8 Dec 2015 02:54:25 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 07 Dec 2015 17:54:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,397,1444719600"; d="scan'208";a="868791383" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga002.fm.intel.com with ESMTP; 07 Dec 2015 17:54:24 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.13]) by IRSMSX108.ger.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0248.002; Tue, 8 Dec 2015 01:54:22 +0000 From: "Betts, Ian" To: Thomas Monjalon Thread-Topic: [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread Thread-Index: AQHRMRjxBG5lI9rfMEW5a6Cqt+UDuJ7AT0+AgAAEFiA= Date: Tue, 8 Dec 2015 01:54:21 +0000 Message-ID: <877C1F8553E92F43898365570816082F35C0C401@IRSMSX103.ger.corp.intel.com> References: <1449225265-14480-2-git-send-email-ian.betts@intel.com> <1449511120-16899-1-git-send-email-ian.betts@intel.com> <1449511120-16899-4-git-send-email-ian.betts@intel.com> <1915132.14VGSMCEh2@xps13> In-Reply-To: <1915132.14VGSMCEh2@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-inteldataclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsIiwiaWQiOiI4NGM4MjgzNi04OTMzLTQxMmQtYjVlOC1lNmYxZDlmZGEzZGQiLCJwcm9wcyI6W3sibiI6IkludGVsRGF0YUNsYXNzaWZpY2F0aW9uIiwidmFscyI6W3sidmFsdWUiOiJDVFBfSUMifV19XX0sIlN1YmplY3RMYWJlbHMiOltdLCJUTUNWZXJzaW9uIjoiMTUuNC4xMC4xOSIsIlRydXN0ZWRMYWJlbEhhc2giOiJYb2NESmpFMXJTTCtONHlxTlpYVitBQ1VlUkM1KzJGaUkxejlla1h5am5jPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v9 3/4] examples: add l3fwd-thread example in performance-thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 01:54:25 -0000 -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Tuesday, December 8, 2015 1:36 AM To: Betts, Ian Cc: dev@dpdk.org; stephen@networkplumber.org; Richardson, Bruce Subject: Re: [PATCH v9 3/4] examples: add l3fwd-thread example in performan= ce-thread > +M: Ian Betts > +M: John McNamara > +F: doc/guides/sample_app_ug/performance_thread.rst > Why doing 2 sections? > John is already the doc maintainer. You don't need to add him here. I just copy most of the other examples which also do this. I also thought it was odd. I will remove him. > --- a/examples/Makefile > +++ b/examples/Makefile > @@ -77,5 +77,9 @@ DIRS-y +=3D vmdq > DIRS-y +=3D vmdq_dcb > DIRS-$(CONFIG_RTE_LIBRTE_POWER) +=3D vm_power_manager > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) +=3D l2fwd-crypto > - > +ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),) > +ifneq ($(CONFIG_RTE_ARCH_X86_64),) > +DIRS-y +=3D performance-thread > +endif > +endif > Matter of taste, I would prefer DIRS-$(CONFIG_RTE_ARCH_X86_64) I need to combine CONFIG_RTE_EXEC_ENV_LINUXAPP ( the two clauses )