From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0304A0542; Wed, 5 Oct 2022 16:30:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54E0942670; Wed, 5 Oct 2022 16:30:44 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2045.outbound.protection.outlook.com [40.107.92.45]) by mails.dpdk.org (Postfix) with ESMTP id 0AA5540143; Wed, 5 Oct 2022 16:30:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vs2DLgjBVM3z8eQnHfi2mbOG/m9K0BaDd0yd/mNtDw/wEKU3t8xMgLqutbokaWx4/YGZgplOKIwyu9PUmhKUl/+GRoq7uayj8wmVEezldZdeFkUyS0TscswLKWBBp4MXq2IMY8ZDFN8xyUC5wmjzXn+lhCz1gb7og/WtwjtORHomhhbDdosVknFlQyTeLGrFpmv1M5EHWDlU7nqDmJmTMJwqG/ErG5nwoEWzym9rm5w2Qrv0HVS5TOlvl6rL46ityZf4aqy0wbmLoh2/dAzCsKCmem+nTnymg/mcM+VHBlRJeQO+Vt42NyEfz5Pr5YsQ27dw4q20oLDKDIwLzrzOHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cYKozpYUspH8HHsxm69QSuomcXOH9F/4iB6A9IrwaMA=; b=N9O4Og7wVYYjrUhEgtrCdw2mfk6cbdWpvE2id0JT4/7ND90qeHf5z3U8DnGUvFFRT6DiR/XfzjyP7zRlFITQPl5q+2kWrDh0klN+IKEfroC8rZtbHu7cxiDlIBxPQqGQcUUxYcXFg8oUKIjNIt5VZslm8NL6Y6H6H0Adm5OkJ6N2zNEwvpNyvnjlwdtrdAPDA5g9nwfEa8FL/V/aavULrYc76kDz7zZ5QpapEWNHgdZVM43QsQQGT22hMrlxpsx4anjoFIV95DKNioK/rZAWU4BaLDCXi1j14RCh3GFbfEbH4gsDpT82cxH1lxmXzE7FW2PT1RDOOMSN0VH32zzMkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cYKozpYUspH8HHsxm69QSuomcXOH9F/4iB6A9IrwaMA=; b=dNOPY2b6meS4tWcp62xt1IuvTgJGladJbo58l6XcUtMriSEq5XG3POEYY3E03U1G3J9hram0QJRKKr/Cvx4S9D6KnEE5RUF2lcDr+1YSizp5ffazPRuYyRMP/oXm2DsoBHPzChvhJN+a6opcZpKr2n/HvSW5/UPrW2sweq6vLh0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB6023.namprd12.prod.outlook.com (2603:10b6:8:85::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Wed, 5 Oct 2022 14:30:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 14:30:41 +0000 Message-ID: <877f3e10-9f0d-9281-de45-386970a44bed@amd.com> Date: Wed, 5 Oct 2022 15:30:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 05/15] net/dpaa2: check free enqueue descriptors before Tx Content-Language: en-US To: Gagandeep Singh , dev@dpdk.org Cc: brick , stable@dpdk.org, Rohit Raj References: <20220928052516.1279442-1-g.singh@nxp.com> <20220928052516.1279442-6-g.singh@nxp.com> From: Ferruh Yigit In-Reply-To: <20220928052516.1279442-6-g.singh@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0243.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB6023:EE_ X-MS-Office365-Filtering-Correlation-Id: 44881286-32fd-4ba1-1246-08daa6de2dd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tRbo8EsOZZjenTLn8ChqCSw16HdrAM5tLbLvf+hQs/SY1OTocoRfq1/qZf77GOme3k1h64Ec8i1/hDDLv9VhJfTdObU/P4eg6133IeBqrSV6lpFID8/bBsXPGw3GmvSszJKkQO9fGWzDhVRargHezVmC13jhESOWXAIQt3oECLIfviKnzpxvsZmXVBuhzDpluCa57Oxv6YFGu4RP5Pq89pDRMjQQF4pUWt+95JEzTRNdrLSf/xLzL5pnIm9KuRp2Py8s1HPlOvEMQMRb9V7lLFPpmhlfEvuISdJAl9fdtqAGoqmKB3uVgYAimm7vUNogWmjaezpLVHKOTxZWxzozCBbOaVU9v9t/v9gsCNvc0tlbJTqoHOooFVytxPo4peSWe0m+a4G1DNgseXf26XL4LTdAWO4sU9/hF2/v4umxEh+wepz0Mro1OC+KTka1yKEX2D9BdHIq8B35r5ypGu6ptp+eUITVAWNUA3zgFLbZ7I7O2+DrIzwuOt9mMnVB4h3jEoShEM2bI9kQZiGzde6fVGLdLg6IN7g7tf9yqv5AxwMQAYxfv6fAvTwdU+OSjzjpd4sKic8f+tSdN+mPT+JiAOz/AiNNiFQYVjudaWJaB/7peCSjCvDoLTC4N8PRAIIJZFiDzqhsfXFYRtyaKHCUfNH5VzRCAG5CTS3UIopoMVCiCsm+Dql1nW+Vt4A7Of6Vup30kfJeOAu0dzVprBIWpInMs7F79rEIMgnY4Ityn/Buw8ZCkAh03sGZDZjqXudhzIDjeJi7JBolFfR4t8K84azZmjxTNVMxIJ4nwEIq22M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(366004)(136003)(451199015)(4744005)(5660300002)(8936002)(41300700001)(2906002)(44832011)(53546011)(6506007)(26005)(38100700002)(86362001)(2616005)(6666004)(6512007)(8676002)(4326008)(66476007)(66556008)(66946007)(31686004)(186003)(6486002)(36756003)(478600001)(83380400001)(31696002)(54906003)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3F3aSt3VGVJOHVjc3d5UDFFcmpxeGtTNUtDaGovOE82NEx4VWM1SkRDOHZQ?= =?utf-8?B?aGJTOEk0OWdLM1A1TndaU2xxQmtUUXBrc0t1aFJ4VEorcElyaTI4RVpGdnhr?= =?utf-8?B?TmtKcldReTJ5U2dZeUNjcmZXVG9vMEovSXA1N3oxcE1HeEJ4aFRuQUM3OEdv?= =?utf-8?B?K2NnRm95MitRRkZMM211blh0cWZRNXJHMldWUEFIZVZjYXQ0RU5PSzlvVUZF?= =?utf-8?B?VEl1U1BRZ1FHajEwYVM3V2hURThpMThYeVB5aXIzUjkyOXlLNWlGdFJtVXFt?= =?utf-8?B?NGJFaWFjR2RkVkVKVFRKQm1zK1BSdXpWTTZVakVIOHFxVDk0Mkt3RklhdUd2?= =?utf-8?B?RjZQUG5IdVBDbFRsb2o1TU02UFh1Qm14NTQ1YUd1NEY2cUZzRXFFbzU0U3RU?= =?utf-8?B?NVpmcFZIUEpXYTQyYUNwak9UWEcyT1A2WjlQTVYxS0I5R1MxTDJOcHp1OUZy?= =?utf-8?B?akRmbXhoakR4RVRrcForUHBWdkwrTVl6b3p4eTIwYytoV012bW5tcEUzTGxO?= =?utf-8?B?UUh5L1IyRlllRUhxSDE1TTFpcWJMWk5DYkRUV0Y1NHdPM0lsdzdJZHR1dUNB?= =?utf-8?B?L0gxUG9keitYQTVJTGI4dlFZSlEwNk9ManlHbituRlZTUURQTks3Ty9iK3lI?= =?utf-8?B?cCtTYXRGMTdvc0tGNjlXR1k2U1RPdDRIMmYxSHpYcjhlL2tTS3F0aTJhRTZr?= =?utf-8?B?LzJLeFEyV01jcVJKaWRvZVA1dG5Hajd5YnVEeDQ1ME95dnRqYUgwRlJiSFh1?= =?utf-8?B?THBVNk5ibUJ3VlN1ZXZ6NFcxdjNUUHpINW5mOXlzZGpsOVRFaFV1MDN0dlRi?= =?utf-8?B?OE9ZSktnZm1STUgvcExKaC9WWlVnVUtxS0ZxZzFkQmlYKzlVakM2a3F0ZWJS?= =?utf-8?B?eU1FYVc1MU9VYncxREZwalBWWFFIMWl4YzhzeDlwYUNoT0wyWFNIK1lsZ0VL?= =?utf-8?B?NXRqd2FTVU44dllRR25tMUlFRTJPQlE3R3J6eUlUaEk0N3gybXc1akNKMlNK?= =?utf-8?B?UitEVXFxRkRmU29oWXk5eVpkSk5jbWp5aTc4S0MwQTNBQndzQ3c2QS9MTHBV?= =?utf-8?B?Rnp6RUUveE9iR0VWcllFNnAvbng2YUFOTmlCbVVOamZ0R1hhL2dyWCtqWUdt?= =?utf-8?B?eHVjQisxZXNaRHlCOVhNV1YvaHYvQ1luc0R0djJIY3ZpTDhDMTFaUWpNUVZX?= =?utf-8?B?Z3M5VUdnT3EvNU9paHR4YUxYMnBwV0JsbG5XNUFDNHhaa2ZOUm9IZjNteUNv?= =?utf-8?B?ODRrWU5WdzhzSEJIQVJGaHFIdzUxcExlQ2x0SFNwdjA4U240UUg5S29Zc0Nk?= =?utf-8?B?NFBzV1dyOG1ERjdCV3VmdXNFRTVqZ25mcVBPQm1xUjZqM2dpMVFHTDVBWVow?= =?utf-8?B?SVFFaXIreTJBK2NwbVZMMk50RUFlUDJuSHJzTlFUOHFkd0IweG1oc0VTanhn?= =?utf-8?B?bTA5N2hxTGJoRnBTUlZzS3J5bzVadHp3M1hHbzZVa0NxQlhiN25PcjZjY2Rm?= =?utf-8?B?Q2tlN2k2TUR5ekhzOFAvSXBoRXZUaEZtYkU5dEwrL3Jwa1BmdkpWblpralpI?= =?utf-8?B?QlBmTUtlY2tudDZxNGlUWEphV0lidndoZkdHYmhXR25jNS91bnN0LzdWdXJi?= =?utf-8?B?WG1DOTZFZVZ0bERwQXcvNmVncjIxazVOT3ZHdytJMmxDa0NsVDIzRTVxRXB4?= =?utf-8?B?ZU9idzdpUXo1WTJ0OFlwSXJ2aUZQaUZJaHNRVXR3dW9oUTZEOFN2dDJJM2JF?= =?utf-8?B?QUttMHFLTEt5eGJoaWd5RldmU3IyNlNlUDhxWUV1bzVoaUFrVEJtRmFjSnZT?= =?utf-8?B?SzBFUU5ZdzhSYTg2QmxUb0M4TXp3Tk8xTGN6NzZRc3VkYXFhMXQvNE5TQ1Zx?= =?utf-8?B?UEx6RmV5RkdQWHo1ZDJ2M3ZQL1hzcnJyVTNIRkNYNmJBdkl0dVhvSmY4VEph?= =?utf-8?B?VGplNVZPOHFHNVdZbm9kUDZrT081d1FkcVRyUmxlN3lGaEJ4UDVqYzNlUjdr?= =?utf-8?B?OGZ0THRXZEw5dm4wWlJ5Z0h6U3Z2c1NmelhFM3FReTEycW9rOTRZTTMydUtI?= =?utf-8?B?cWZ4dTRZcStzSTNIRlJEN3JsWjJXZm9DQTlJQUU5clRxbWtpS3BPRlh5aTJ6?= =?utf-8?Q?4HA1rM8Qhw0S8edxwHQ0ngTPP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44881286-32fd-4ba1-1246-08daa6de2dd9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 14:30:41.0528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yBKtDACXGPLbl55YFFKFXwE6+4w21YWVE5i3YYoEOt9u52oQsG44WeqDOYeIuS0a X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6023 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > From: brick > > Check if there exists free enqueue descriptors before enqueuing Tx > packet. Also try to free enqueue descriptors in case they are not > free. > > Fixes: ed1cdbed6a15 ("net/dpaa2: support multiple Tx queues enqueue for ordered") > Cc: stable@dpdk.org > > Signed-off-by: brick Can you please use name tag as "Name Surname ", like Signed-off-by: Brick Yang <...> > + DPAA2_PMD_DP_DEBUG("===> eth_data =%p, fqid =%d\n", > + eth_data, dpaa2_q[loop]->fqid); > + > + /*Check if the queue is congested*/ syntax, more common to put space before/after '/* ' & ' */' > + retry_count = 0; > + while (qbman_result_SCN_state(dpaa2_q[loop]->cscn)) { > + retry_count++; > + /* Retry for some time before giving up */ > + if (retry_count > CONG_RETRY_COUNT) > + goto send_frames; > + } > + > + /*Prepare enqueue descriptor*/ ditto