From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 7D6495938
 for <dev@dpdk.org>; Sun,  9 Aug 2015 19:53:40 +0200 (CEST)
Received: by wijp15 with SMTP id p15so110709571wij.0
 for <dev@dpdk.org>; Sun, 09 Aug 2015 10:53:40 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=PdFxzS38TVwMPNg5BQ067e1EM/Edz3DtdWEg0Ckgzvc=;
 b=hHbSFQY0lNZ1id+ihOY+hcjXs869IiYniMQuCwSNZRbny9j3XNv6AixeBylDnjymg4
 /4cz7rq5/5yQsfrg7iUZuL2Zk9p/XKwDiERzVGDSrK9cnUVnFSzJF0FAkYIigvTRw/np
 T7mJxSs2b+hmz2/41Qdf88gQCQcdoS3avHBKWi4eM4mchPAnCidJOe2nofKFRPvBwCgq
 HLfXa8Ys2nR42TvOyJLZI8sAAPhcf2a2CsVhviW+/XchQmxU9Pu1g6pSlHT+0TNxcVOq
 TRv07Fvn0Vom3KkWDF+ZVoJBT+I1bGRr9YnlHq8QzDl2PBB/vb9+o9jGeNrlanSaK3p4
 ihyA==
X-Gm-Message-State: ALoCoQkDZUdj7dZ1Mh+gIx+U1pbc4ohWi7tnb/EuiZ2sR/IOJic+As9sBmmuzSXZf82dl3esXxvc
X-Received: by 10.194.88.102 with SMTP id bf6mr34673765wjb.99.1439142820343;
 Sun, 09 Aug 2015 10:53:40 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id hn2sm25321641wjc.45.2015.08.09.10.53.38
 (version=TLSv1/SSLv3 cipher=OTHER);
 Sun, 09 Aug 2015 10:53:39 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Date: Sun, 09 Aug 2015 19:52:26 +0200
Message-ID: <8782411.dT7R7qIIRI@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F377C1@IRSMSX108.ger.corp.intel.com>
References: <1438939286-19641-1-git-send-email-mukawa@igel.co.jp>
 <8CEF83825BEC744B83065625E567D7C219F377C1@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: Fix illegal access
	of	rte_eth_dev_is_detachable()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Aug 2015 17:53:40 -0000

> > To obtain detachable flag, pci_drv is accessed in
> > rte_eth_dev_is_detachable().
> > But pci_drv is only valid if port is enabled. Not to cause illegal access, add
> > rte_eth_dev_is_valid_port() before accessing.
> > 
> > Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> 
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>

Applied, thanks