* [PATCH v1 1/1] app/mldev: report device not found as error
@ 2023-08-30 15:51 Srikanth Yalavarthi
2023-10-03 6:00 ` Anup Prabhu
2023-10-05 14:21 ` Shivah Shankar Shankar Narayan Rao
0 siblings, 2 replies; 4+ messages in thread
From: Srikanth Yalavarthi @ 2023-08-30 15:51 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: dev, sshankarnara, aprabhu, ptakkar
Report ML device not found as error, instead of panic.
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
app/test-mldev/ml_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-mldev/ml_main.c b/app/test-mldev/ml_main.c
index 940e609c9a8..56941b1afb0 100644
--- a/app/test-mldev/ml_main.c
+++ b/app/test-mldev/ml_main.c
@@ -25,8 +25,10 @@ main(int argc, char **argv)
argv += ret;
mldevs = rte_ml_dev_count();
- if (!mldevs)
- rte_panic("no mldev devices found\n");
+ if (!mldevs) {
+ ml_err("no mldev devices found\n");
+ goto error;
+ }
/* set default values for options */
ml_options_default(&opt);
--
2.41.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] app/mldev: report device not found as error
2023-08-30 15:51 [PATCH v1 1/1] app/mldev: report device not found as error Srikanth Yalavarthi
@ 2023-10-03 6:00 ` Anup Prabhu
2023-10-05 14:21 ` Shivah Shankar Shankar Narayan Rao
1 sibling, 0 replies; 4+ messages in thread
From: Anup Prabhu @ 2023-10-03 6:00 UTC (permalink / raw)
To: Srikanth Yalavarthi, Srikanth Yalavarthi
Cc: dev, Shivah Shankar Shankar Narayan Rao, Prince Takkar
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
> -----Original Message-----
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Sent: Wednesday, August 30, 2023 9:21 PM
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Anup Prabhu <aprabhu@marvell.com>;
> Prince Takkar <ptakkar@marvell.com>
> Subject: [PATCH v1 1/1] app/mldev: report device not found as error
>
> Report ML device not found as error, instead of panic.
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
> app/test-mldev/ml_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
Acked-by: Anup Prabhu <aprabhu@marvell.com>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 35159 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1 1/1] app/mldev: report device not found as error
2023-08-30 15:51 [PATCH v1 1/1] app/mldev: report device not found as error Srikanth Yalavarthi
2023-10-03 6:00 ` Anup Prabhu
@ 2023-10-05 14:21 ` Shivah Shankar Shankar Narayan Rao
2023-11-14 19:44 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Shivah Shankar Shankar Narayan Rao @ 2023-10-05 14:21 UTC (permalink / raw)
To: Srikanth Yalavarthi, Srikanth Yalavarthi; +Cc: dev, Anup Prabhu, Prince Takkar
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
> -----Original Message-----
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Sent: Wednesday, August 30, 2023 9:21 PM
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Anup Prabhu <aprabhu@marvell.com>;
> Prince Takkar <ptakkar@marvell.com>
> Subject: [PATCH v1 1/1] app/mldev: report device not found as error
>
> Report ML device not found as error, instead of panic.
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Acked-by: Shivah Shankar S <sshankarnara@marvell.com>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 35691 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] app/mldev: report device not found as error
2023-10-05 14:21 ` Shivah Shankar Shankar Narayan Rao
@ 2023-11-14 19:44 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2023-11-14 19:44 UTC (permalink / raw)
To: Srikanth Yalavarthi
Cc: dev, Anup Prabhu, Prince Takkar, Shivah Shankar Shankar Narayan Rao
05/10/2023 16:21, Shivah Shankar Shankar Narayan Rao:
> From: Srikanth Yalavarthi <syalavarthi@marvell.com>
> >
> > Report ML device not found as error, instead of panic.
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Acked-by: Shivah Shankar S <sshankarnara@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-14 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 15:51 [PATCH v1 1/1] app/mldev: report device not found as error Srikanth Yalavarthi
2023-10-03 6:00 ` Anup Prabhu
2023-10-05 14:21 ` Shivah Shankar Shankar Narayan Rao
2023-11-14 19:44 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).