From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 43F11727A for ; Thu, 25 Jan 2018 11:06:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6BF2820CBB; Thu, 25 Jan 2018 05:06:04 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 25 Jan 2018 05:06:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5QNliFyYHbBud4kSzIKcINTmzO cQST+WFj/YJn7jpaI=; b=V+kul++m2S2nbCz/O5Mb56asnQYG2FLhrqYUz3H4xH QhL/7GzydSqKPoaPkc0n80w3elLDVUf11iQF+zg3Uemc4jbRMjCMZE74M9j9k+dj 4/Z+o7RZGbLXMhHujDNn+IqiwqTir5UO9io5Qr0lt6Zd//ObBSj+yEg4jjNxL+TI I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5QNliF yYHbBud4kSzIKcINTmzOcQST+WFj/YJn7jpaI=; b=XJ3pYC7LuCcXVYygwaZxhJ lSWnVAsyf0ZlWOvo5UJhZw+8LX8bzIKR/yqgC7hFU6IeAm/XpEPTRdz4vHG3wkqp G3zItEejjZr2sUVJmeqGeA5hYINSehnCIDBakW0XT3+JNsFGsYIe5KbbOcXOEf29 UovuEStGag/MMzgmOeoraHDHc0/T8igtO+9JACDxqE4EG/s++XCWbpn7Dpyafg9/ cL1nT/307oxd6oGGwm2K1X0hgzqcaAxqs3/FNzJKPREvpHvFNdoTWavG3VHiGN6q M9KHFjcPJaEMBNQAxlD5g/2TQkVSjwvc/HSL1JWw7pDP14d4DSlhMCDzGkJDRAqg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30EAC7E12E; Thu, 25 Jan 2018 05:06:04 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , "Ananyev, Konstantin" , "Wu, Jingjing" , dev@dpdk.org, Neil Horman , "Richardson, Bruce" Date: Thu, 25 Jan 2018 11:05:22 +0100 Message-ID: <8784959.KALqi1c4OM@xps> In-Reply-To: References: <1516293317-30748-8-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 10:06:05 -0000 25/01/2018 10:36, Matan Azrad: > Gaetan, Konstantin, Thomas > > Any response to my suggestion below? > > From: Matan Azrad > > Suggestion: > > > > 2 system owners. > > APP_OWNER - 1. > > NO_OWNER - 0. > > > > And allowing for more owners as now. > > > > 1. Every port creation will set the owner for NO_OWNER (as now). > > 2. There is option for all dpdk entities to take owner of NO_OWNER ports all > > the time(as now). > > 3. In some point in the end of EAL init: set all the NO_OWNER to > > APP_OWNER(for V6). > > 4. Change the old iterator to iterate over APP_OWNER ports(for V6). > > > > What do you think? Reminder for everybody: there is no issue if no hotplug. There is a race condition with hotplug. Hotplug is not managed by EAL yet, but there is a temporary hotplug management in failsafe. So until now, the issue is seen only with hotplug in failsafe. Your suggestion makes no change for applications, and fix the ownership issue for failsafe. And later, if an application wants to support generic hotplug properly (when it will be generally available in DPDK), the application should use the ownership API. Right? I think it is a good compromise.