From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rongqiang XIE <xie.rongqiang@zte.com.cn>, wenzhuo.lu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe:fix some bugs about rte zmalloc memory may NULL
Date: Wed, 23 Aug 2017 11:36:36 +0100 [thread overview]
Message-ID: <878e1a4e-1101-12d7-bad4-511f75f7e91b@intel.com> (raw)
In-Reply-To: <201708230037.v7N0bnek046622@mse01.zte.com.cn>
On 8/22/2017 12:49 PM, Rongqiang XIE wrote:
> In the function ixgbe_flow_create(), the value ntuple_filter_ptr,
> ethertype_filter_ptr,syn_filter_ptr,fdir_rule_ptr and l2_tn_filter_ptr
> use rte_zmalloc() malloc memory may return NULL,so, we should
> add judge the return is NULL or success.
>
> Signed-off-by: Rongqiang XIE <xie.rongqiang@zte.com.cn>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index d679608..c8645f0 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2707,6 +2707,10 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> if (!ret) {
> ntuple_filter_ptr = rte_zmalloc("ixgbe_ntuple_filter",
> sizeof(struct ixgbe_ntuple_filter_ele), 0);
> + if (!ntuple_filter_ptr) {
> + PMD_DRV_LOG(ERR, "failed to allocate memory");
> + goto out;
> + }
> (void)rte_memcpy(&ntuple_filter_ptr->filter_info,
> &ntuple_filter,
> sizeof(struct rte_eth_ntuple_filter));
> @@ -2729,6 +2733,10 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> ethertype_filter_ptr = rte_zmalloc(
> "ixgbe_ethertype_filter",
> sizeof(struct ixgbe_ethertype_filter_ele), 0);
> + if (!ethertype_filter_ptr) {
> + PMD_DRV_LOG(ERR, "failed to allocate memory");
> + goto out;
In out path, these variables should be freed which seems missing, would
you mind another patch to fix this?
> + }
> (void)rte_memcpy(ðertype_filter_ptr->filter_info,
> ðertype_filter,
> sizeof(struct rte_eth_ethertype_filter));
<...>
next prev parent reply other threads:[~2017-08-23 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 11:49 Rongqiang XIE
2017-08-23 10:36 ` Ferruh Yigit [this message]
2017-08-23 10:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878e1a4e-1101-12d7-bad4-511f75f7e91b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
--cc=xie.rongqiang@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).