From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10073.outbound.protection.outlook.com [40.107.1.73]) by dpdk.org (Postfix) with ESMTP id 24BDD5689 for ; Fri, 1 Mar 2019 02:15:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/vPMoHSrawbuEBPGMDJ02jdrf5ZdMq7ZBfIH/Dcn8Lg=; b=kE51vAqecK2YiU+D5n2NBPLadJzow2Uuj85+88qjB+UNY5bjASgBExMnUy01gdioRPGcXzefpDduLiNdliz5mkOxmPE1N8FoS5OEeVVx0ISkOYr6wDqUs0kGQwNO8rB+SRf3+/riBQLSWc1m9NOQWnLGJ7P5FpQPqHGXSM/CKhQ= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3979.eurprd05.prod.outlook.com (52.134.67.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.15; Fri, 1 Mar 2019 01:15:07 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::580c:ae7b:8278:cc50%3]) with mapi id 15.20.1665.015; Fri, 1 Mar 2019 01:15:07 +0000 From: Yongseok Koh To: Shahaf Shuler CC: dev Thread-Topic: [RFC] net/mlx5: improve out of box performance Thread-Index: AQHUz8w1EccTpaJrrU+u/UH7tkszVQ== Date: Fri, 1 Mar 2019 01:15:07 +0000 Message-ID: <87C54B37-6A66-4530-A086-50090A11E626@mellanox.com> References: <573D7DCB-6E17-4843-9EA1-C00352998BE8@mellanox.com> In-Reply-To: <573D7DCB-6E17-4843-9EA1-C00352998BE8@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e38265e8-2df6-4455-73a7-08d69de357c7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3979; x-ms-traffictypediagnostic: DB3PR0502MB3979: x-microsoft-exchange-diagnostics: =?us-ascii?Q?1; DB3PR0502MB3979; 23:hzur6UKdfmlA9w9M4QcFAwS50CEXI3hz1qgCPRr?= =?us-ascii?Q?VQ1ZW5rp8JX0kxHoycuHunDOVHoqBVpnk4lxb64ha9CnEm1dgBfYdpdDTgl7?= =?us-ascii?Q?czC6dnyv/ar0h89lhjP4cbmZgdV7gZp5MUlHlUykGRD6pqQSy3yM8SIMLLl3?= =?us-ascii?Q?IOTgRu9l1zCngrZqXNHP6hMi0dSs7bkb5GTDLCuuLUvNqo5Hb6AXr7+lJKxL?= =?us-ascii?Q?2qEQEGxf1+GayVRUbB7xNhdJx/mLjCR4GulYJBqSLRjwe9mb2NbSJDydAdbP?= =?us-ascii?Q?PAG/yNmgWW2lUGZVScvHa7sMYNDC4SnjbSE3OnaMPyI0nRNcmcF27puTKHjo?= =?us-ascii?Q?sqv91Fa4N8ml2H3CnyJKL79iETpzMZzOB0fjLFvljmaKoTtos+7Obt+jj1Il?= =?us-ascii?Q?+pZiqgvHhvupPQB7HWvk957rzNmXOqzd6RrLLR1Powz0bwrqL17FCoiTaiah?= =?us-ascii?Q?xlaHSFBSJ8Cyk5hUEknTyVjvmL10KdsRzrcaoPDGcehflTk+5Cjh0rX8DicX?= =?us-ascii?Q?mTKz5Zx/lIv6sxtouZ01t3Sn8rnFbS9+HT+/BjxE21CmdCIQiEz3zRN+uIlB?= =?us-ascii?Q?Rk2scOL501QZZ/Y7CTSuW8yKT0favCNkD/keeocNvB/l/zt+D7yN9Tpfc/eE?= =?us-ascii?Q?rzgW8VpS/tVUOudXQltHfLDCvtMeRD47gEnNm0RM5OcdClTF1xZjaTXOYoaW?= =?us-ascii?Q?eBJ8dCtXSVGqudD2Tj+rYrI3xizx9jaqHYsoLr2jjolYVJMhehkHapkLN5v5?= =?us-ascii?Q?scqaL2S5ev1W5E5yS6tCm1CbfAmQmJhTJBl10/Vl392nmzereILfdYFj9Tb/?= =?us-ascii?Q?MY9axMl9rEiDWrCX79WeXiKgocBHbNuKFDzgbTzTk4FKrEo21LGPAZHupQhG?= =?us-ascii?Q?zZ2x3/k9zZM4mKZcfUHV6VWgZFakfWF4H3UMSIRG/TiA3jcWG/jkguSc096l?= =?us-ascii?Q?4Tv5hLQc+O/xqF6Mq91OsVH6oU9C7LEda89R9Raae6oxYvTg5p2nkm9ckmiy?= =?us-ascii?Q?PRYyMpL7y8lhIeMRs1JXJw60Fk/cNhYyU20JBU2bO1RQCebaKbe2j1+U8MaL?= =?us-ascii?Q?QXeIX78YRxp0C2YUOMkUs+Q4Kh1uMr5nU2O0Eyhzqq99BXSI9DNivrp0YRhS?= =?us-ascii?Q?Yc+YF4NXjeNvXKkNT+48xejcrPZU7j2eW8pOu3Cpkd6on02DdCEJT1lH/z3/?= =?us-ascii?Q?k3wfcK099Il/jqXiL28qzlm8p+Y7jSQEF8tFqDd2Pz+kYEUO3O4vlrbYoaiu?= =?us-ascii?Q?mvSOOHXaL0QyGnP0T5V8=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09634B1196 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(366004)(39860400002)(376002)(396003)(199004)(189003)(6506007)(81156014)(81166006)(99286004)(97736004)(8936002)(36756003)(25786009)(76176011)(68736007)(71200400001)(71190400001)(8676002)(53936002)(83716004)(53546011)(82746002)(106356001)(66066001)(86362001)(6512007)(105586002)(37006003)(11346002)(478600001)(446003)(305945005)(14454004)(102836004)(7736002)(486006)(5660300002)(316002)(476003)(6636002)(2616005)(256004)(14444005)(186003)(6116002)(26005)(2906002)(3846002)(6436002)(6862004)(33656002)(6486002)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3979; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: rqxcptQXyGD/SfeMJ5DgeeOGeYaJ9OgRKugY+AjlcEtOH1cLcqK6Nh99LWpacsFSx3fpmXc+baloqLBoGSXTzFhZIScJwxpb1Ebs+/57q//Za4KgjN6zVbyVSnKk7OS8CzhjQvNNOR2LdHo5v2hs5g7BHzCc5opqnDylyZ9cUkkCKH31xb2US9ii18FWnno5py04sAA3ocXjJfdlGPRLuGc68o3okHEPKIWBaTX8wQ+pXyxMCA8qNCjP+4fuKYBxY2ygpr8cjs5COwtcN0XaZQmV9ipETYk7G+7fwGx1RfW8KaeLqY0RAKUevVSRzPMQF1k8zP2yMmC0XEhdOSOAAnDny3y7bkbKRMMoi72xMT4hFi8rH8MRIxgSmiqS3Not8WIqCmDdDCoIpszIbJdJafBXyG3+1LJ5PdXx9cFRsxg= Content-Type: text/plain; charset="us-ascii" Content-ID: <0233962CCD9FED4C82BA7528B6B79C2E@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38265e8-2df6-4455-73a7-08d69de357c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2019 01:15:07.3618 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3979 Subject: [dpdk-dev] [RFC] net/mlx5: improve out of box performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 01:15:10 -0000 Hi, This one could never be done last time, but this will be tried again for v19.05. Thanks, Yongseok > On Jun 7, 2018, at 5:38 PM, Yongseok Koh wrote: >=20 > In mlx5 PMD, there are multiple Tx burst functions, > mlx5_tx_burst() > mlx5_tx_burst_mpw() > mlx5_tx_burst_mpw_inline() > mlx5_tx_burst_burst_empw() > mlx5_tx_burst_raw_vec() > mlx5_tx_burst_vec() >=20 > To provide better user experience and the best out-of-box performance, > those will need to be consolidated. There will be only one non-vector > function. As mlx5_tx_burst_vec() calls mlx5_tx_burst_raw_vec(), there'll = be > no change with vector fuctions. >=20 > The reason for multiple Tx burst functions was because newer device has > enhanced features to improve throughput by further saving PCIe BW. For t= he > new features (e.g. Tx packet inlining), new Tx burst functions had been > added incrementally. Such new functions were to support new type of Tx > descriptors. However, problem with selecting a Tx burst statically is, > although newer devices support all the descriptor types including legacy > ones, the new function doesn't fall back to the old modes. >=20 > Another issue is that it is very hard to introduce a new feature on Tx > path. For example, mlx5 supports TSO but currently it is only supported b= y > the basic mlx5_tx_burst(). We could've added TSO support to other Tx > bursts but it is so much painful to add the same code in multiple > locations. And it isn't even a good idea from maintenance perspective. As= a > result, even though a user wants to enjoy Mellanox's best-in-class > performance, if TSO is required, mlx5 PMD can't satisfy the user. >=20 > The consolidated Tx burst function will be all-inclusive. This will suppo= rt > all types of Tx descriptors (WQE) and HW offloads. WQE type for a > transmitting packet would be determined dynamically. Decision for packet > inline will be made by sensing PCIe bottleneck. >=20 > And selection between the consolidated function and the existing vector > function will still be done during configuration. But CPU architecture wi= ll > also be taken into account. >=20 > Signed-off-by: Yongseok Koh