DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers
Date: Wed, 02 Mar 2022 05:16:40 -0500	[thread overview]
Message-ID: <87a6e8hd6f.fsf@mdr78.vserver.site> (raw)
In-Reply-To: <20220301165404.18936-2-david.marchand@redhat.com>


David Marchand <david.marchand@redhat.com> writes:

> Convert the existing exception in the ABI script into a libabigail
> suppression rule.
>
> Note: file_name_regexp could be used to achive the same with versions of
> libabigail < 1.7 but soname_regexp has been preferred here since it is
> already used with a recent change on common/mlx5.
>
> While at it, fix indent from a recent change.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  devtools/check-abi.sh        | 7 -------
>  devtools/libabigail.abignore | 8 ++++++--
>  2 files changed, 6 insertions(+), 9 deletions(-)
>

Minor niggle that changes to the check-abi.sh script should have been in
the first patch?

Acked-by: Ray Kinsella <mdr@ashroe.eu>
-- 
Regards, Ray K

  reply	other threads:[~2022-03-02 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 16:54 [PATCH 1/2] devtools: remove event/dlb exception in ABI check David Marchand
2022-03-01 16:54 ` [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers David Marchand
2022-03-02 10:16   ` Ray Kinsella [this message]
2022-03-08 14:04     ` Thomas Monjalon
2022-03-02 10:13 ` [PATCH 1/2] devtools: remove event/dlb exception in ABI check Ray Kinsella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6e8hd6f.fsf@mdr78.vserver.site \
    --to=mdr@ashroe.eu \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).