From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8301A04A4; Wed, 2 Mar 2022 11:16:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD0C942715; Wed, 2 Mar 2022 11:16:46 +0100 (CET) Received: from mail-108-mta98.mxroute.com (mail-108-mta98.mxroute.com [136.175.108.98]) by mails.dpdk.org (Postfix) with ESMTP id D1F8340141 for ; Wed, 2 Mar 2022 11:16:45 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta98.mxroute.com (ZoneMTA) with ESMTPSA id 17f4a21cc48000763e.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 02 Mar 2022 10:16:43 +0000 X-Zone-Loop: 7290b4a80c11698fb24bfbd28db9f6e8dfc566381638 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2hWQ0C02m1Ku+qm49k83XFpXt2o6E2voglHqBsWQxvU=; b=VLH79MJrkV+s5eOyVMo2FvEwGt w4jLI0Jk7R7zrNK77T/mm3sv21oZSJG+kegQ848VS6qgGBdVO9VibNxZiu/d9NBTRzbQ7merQaRp1 MhbxcdjfzzLJbRVKnYCyoQLo6fKfBBYvknj3sxpV+WDO/V1oHte1AnLmtiJFhVoSD/jUz4+qyUUSp 09GUIBxk9nzW9Ape748edN9Qu6cXci/cd8EkkpEElNFUqX/n+MaE6+8gIZxXiqSWd/o9+rifRkF0c gXDDqDoew3Wld32zYEfl8YMYHHygDBJWuipYz9ux5cOg+/b2HPYW+bkXGV9P0HZ2LBi0MSkuzqink KK90cIrQ==; References: <20220301165404.18936-1-david.marchand@redhat.com> <20220301165404.18936-2-david.marchand@redhat.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net Subject: Re: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers In-reply-to: <20220301165404.18936-2-david.marchand@redhat.com> Date: Wed, 02 Mar 2022 05:16:40 -0500 Message-ID: <87a6e8hd6f.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > Convert the existing exception in the ABI script into a libabigail > suppression rule. > > Note: file_name_regexp could be used to achive the same with versions of > libabigail < 1.7 but soname_regexp has been preferred here since it is > already used with a recent change on common/mlx5. > > While at it, fix indent from a recent change. > > Signed-off-by: David Marchand > --- > devtools/check-abi.sh | 7 ------- > devtools/libabigail.abignore | 8 ++++++-- > 2 files changed, 6 insertions(+), 9 deletions(-) > Minor niggle that changes to the check-abi.sh script should have been in the first patch? Acked-by: Ray Kinsella -- Regards, Ray K