From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4531A04DB; Thu, 15 Oct 2020 13:37:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 79D671C231; Thu, 15 Oct 2020 13:36:59 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 5AE971C20B for ; Thu, 15 Oct 2020 13:36:57 +0200 (CEST) IronPort-SDR: 6rNrW1do03zZ3BTmhXTITQXbNqbm2k2FWjCM5TfN/CdoPLWrdSdREhRL4L/N05NNHi3jqNHJJL 3PtryCvYxv7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="145634757" X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="145634757" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 04:36:53 -0700 IronPort-SDR: b0gyTEy2yYFmirL7uGkNOr1WPrKGYf2KpJAFVYIhkk7ne5WK1kHvv9P+cIgEjngIDlctz4v3No WGufri2+5ZEA== X-IronPort-AV: E=Sophos;i="5.77,378,1596524400"; d="scan'208";a="464264218" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.84.112]) ([10.251.84.112]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 04:36:51 -0700 To: Jerin Jacob , Slava Ovsiienko Cc: dpdk-dev , NBU-Contact-Thomas Monjalon , Stephen Hemminger , Olivier Matz , Maxime Coquelin , David Marchand , Andrew Rybchenko References: <1602699122-15737-1-git-send-email-viacheslavo@nvidia.com> <1602699122-15737-2-git-send-email-viacheslavo@nvidia.com> From: Ferruh Yigit Message-ID: <87d51011-14df-41cb-2601-ca2fd00de4e0@intel.com> Date: Thu, 15 Oct 2020 12:36:46 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 1/6] ethdev: introduce Rx buffer split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2020 12:26 PM, Jerin Jacob wrote: <...> >>>>> If we see some of the features of such kind or other PMDs adopts the >>>>> split feature - we'll try to find the common root and consider the way how >>> to report it. >>>> >>>> My only concern with that approach will be ABI break again if >>>> something needs to exposed over rte_eth_dev_info(). >> >> Let's reserve the pointer to struct rte_eth_rxseg_limitations >> in the rte_eth_dev_info to avoid ABI break? > > Works for me. If we add an additional reserved field. > > Due to RC1 time constraint, I am OK to leave it as a reserved filed and fill > meat when it is required if other ethdev maintainers are OK. > I will be required for feature complete. > Sounds good to me.