DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Michał Krawczyk" <mk@semihalf.com>
Cc: dev <dev@dpdk.org>, "Dagan, Noam" <ndagan@amazon.com>,
	"Tzalik, Guy" <gtzalik@amazon.com>,
	"Chauskin, Igor" <igorch@amazon.com>,
	upstream@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0
Date: Mon, 10 May 2021 13:27:33 +0100	[thread overview]
Message-ID: <87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com> (raw)
In-Reply-To: <CAJMMOfNmKPpt4_9K4=4XpvmcQs0nUo_H8Ja5r40KwTRnGamsGA@mail.gmail.com>

On 5/10/2021 1:02 PM, Michał Krawczyk wrote:
> pt., 7 maj 2021 o 16:59 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>>
>> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
>>> Hi,
>>>
>>> this version updates the driver to version 2.3.0, which fixes multiple
>>> bugs, contains part of the work on making the ENA PMD fully MP aware, and
>>> also updates HAL to the latest version.
>>>
>>> More detailed list of changes:
>>>   * memcpy mapping to the dpdk-optimized version.
>>>   * ena_com (HAL) update to the latest version.
>>>   * Bug fixes for the large LLQ headers and devargs parsing.
>>>   * Mbuf RSS hash presence indication.
>>>   * Bug fix for the default ring size.
>>>   * Various fixes for the SMP mode.
>>>
>>> v3:
>>> * Fix build of the PMD with the debug flags enabled.
>>> * Fix typo in the commit log of the version upgrade patch.
>>>
>>> v2:
>>> * Fix nested declaration of the rte_memcpy on arm64 architecture.
>>>
>>> Amit Bernstein (1):
>>>   net/ena/base: adjust changes to lastest ena-com
>>>
>>> Igor Chauskin (2):
>>>   net/ena: switch memcpy to dpdk-optimized version
>>>   net/ena: fix parsing of large_llq_hdr argument
>>>
>>> Michal Krawczyk (12):
>>>   net/ena/base: unify arg names for the functions
>>>   net/ena/base: add dev arg to the logging macros
>>>   net/ena/base: typos, style and comments improvements
>>>   net/ena/base: fix issues from the static code scan
>>>   net/ena/base: destroy multiple "wait events"
>>>   net/ena/base: remove indir table from ENA feat ctx
>>>   net/ena/base: remove mutable RSS from the host info
>>>   net/ena/base: update generation date and commit
>>>   net/ena/base: use rte_prefetch0_write
>>>   net/ena: terminate devargs allowed keys with NULL
>>>   net/ena: indicate Rx RSS hash presence
>>>   net/ena: update version to v2.3.0
>>>
>>> Stanislaw Kardach (7):
>>>   net/ena: remove endian swap functions
>>>   net/ena: handle spurious wakeups in ENA_WAIT_EVENT
>>>   net/ena: support SMP for mz alloc counter
>>>   net/ena: move default RSS key to shared mem
>>>   net/ena: make ethdev references smp safe
>>>   net/ena: disable dev_ops not supported in SMP
>>>   net/ena: report default ring size
>>>
>>
>> Hi Michal,
>>
>> There are some checkpatch and check-git-log.sh [1] warnings, can you please
>> check them?
>>
> 
> Hi Ferruh,
> 
> sure, I'll check them all and fix whatever is possible. The problem is
> with some of the HAL patches, which are just touching some lines on
> which the checkpatch returns a warning. Many of them aren't related to
> those patches, so I don't think we should fix them as part of those
> commits (like the one you listed below, the following patch just adds
> ena_dev as an extra input argument). Please let me know what you think
> about that.
> 

Hi Michal,

For the new code I think expectation is clear that it should fully comply the
coding convention, but for the base code we are more flexible, since it is
shared I understand that the small fixes may cause more maintenance cost.

Please try to fix as much as possible, at least please fix the obviously wrong
ones and fix the ones like below with best effort.

Thanks,
ferruh

> Thanks,
> Michal
> 
>>
>> You can see checkpatch warnings from patchwork:
>> https://patches.dpdk.org/project/dpdk/list/?series=16861
>> The ones with yellow marker in the warning column.
>>
>> Additionally I am getting following checkpatch warning, that is not seen in CI:
>> ### net/ena/base: add dev arg to the logging macros
>>
>>
>>
>> WARNING:UNNECESSARY_MODIFIER: Integer promotion: Using 'h' in '%hu' is
>> unnecessary
>> #331: FILE: drivers/net/ena/base/ena_com.c:861:
>>
>> +               ena_trc_err(ena_dev, "Reading reg failed for timeout. expected:
>> req id[%hu] offset[%hu] actual: req id[%hu] offset[%hu]\n",
>>                             mmio_read->seq_num,
>>
>>                             offset,
>>
>>                             read_resp->req_id,
>>
>> @@ -854,7 +868,7 @@ static u32 ena_com_reg_bar_read32(struct ena_com_dev
>> *ena_dev, u16 offset)
>>
>>
>>
>> [1]
>> ./devtools/check-git-log.sh -22


  reply	other threads:[~2021-05-10 12:27 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 12:57 [dpdk-dev] [PATCH " Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 01/22] net/ena: switch memcpy to dpdk-optimized version Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 02/22] net/ena/base: unify arg names for the functions Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 03/22] net/ena/base: add dev arg to the logging macros Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 04/22] net/ena/base: typos, style and comments improvements Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 05/22] net/ena/base: fix issues from the static code scan Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 06/22] net/ena/base: destroy multiple "wait events" Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 07/22] net/ena/base: remove indir table from ENA feat ctx Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 08/22] net/ena/base: remove mutable RSS from the host info Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 09/22] net/ena/base: update generation date and commit Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 10/22] net/ena/base: use rte_prefetch0_write Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 11/22] net/ena/base: adjust changes to lastest ena-com Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 12/22] net/ena: fix parsing of large_llq_hdr argument Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 13/22] net/ena: terminate devargs allowed keys with NULL Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 14/22] net/ena: indicate Rx RSS hash presence Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 15/22] net/ena: remove endian swap functions Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 16/22] net/ena: handle spurious wakeups in ENA_WAIT_EVENT Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 17/22] net/ena: support SMP for mz alloc counter Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 18/22] net/ena: move default RSS key to shared mem Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 19/22] net/ena: make ethdev references smp safe Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 20/22] net/ena: disable dev_ops not supported in SMP Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 21/22] net/ena: report default ring size Michal Krawczyk
2021-04-30 12:57 ` [dpdk-dev] [PATCH 22/22] net/ena: update version to v2.3.0 Michal Krawczyk
2021-05-05  7:33 ` [dpdk-dev] [PATCH v2 00/22] net/ena: update ENA PMD " Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 01/22] net/ena: switch memcpy to dpdk-optimized version Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 02/22] net/ena/base: unify arg names for the functions Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 03/22] net/ena/base: add dev arg to the logging macros Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 04/22] net/ena/base: typos, style and comments improvements Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 05/22] net/ena/base: fix issues from the static code scan Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 06/22] net/ena/base: destroy multiple "wait events" Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 07/22] net/ena/base: remove indir table from ENA feat ctx Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 08/22] net/ena/base: remove mutable RSS from the host info Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 09/22] net/ena/base: update generation date and commit Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 10/22] net/ena/base: use rte_prefetch0_write Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 11/22] net/ena/base: adjust changes to lastest ena-com Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 12/22] net/ena: fix parsing of large_llq_hdr argument Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 13/22] net/ena: terminate devargs allowed keys with NULL Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 14/22] net/ena: indicate Rx RSS hash presence Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 15/22] net/ena: remove endian swap functions Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 16/22] net/ena: handle spurious wakeups in ENA_WAIT_EVENT Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 17/22] net/ena: support SMP for mz alloc counter Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 18/22] net/ena: move default RSS key to shared mem Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 19/22] net/ena: make ethdev references smp safe Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 20/22] net/ena: disable dev_ops not supported in SMP Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 21/22] net/ena: report default ring size Michal Krawczyk
2021-05-05  7:33   ` [dpdk-dev] [PATCH v2 22/22] net/ena: update version to v2.3.0 Michal Krawczyk
2021-05-06 14:25   ` [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD " Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 01/22] net/ena: switch memcpy to dpdk-optimized version Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 02/22] net/ena/base: unify arg names for the functions Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 03/22] net/ena/base: add dev arg to the logging macros Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 04/22] net/ena/base: typos, style and comments improvements Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 05/22] net/ena/base: fix issues from the static code scan Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 06/22] net/ena/base: destroy multiple "wait events" Michal Krawczyk
2021-05-07 16:47       ` Ferruh Yigit
2021-05-09 14:17         ` Michał Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 07/22] net/ena/base: remove indir table from ENA feat ctx Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 08/22] net/ena/base: remove mutable RSS from the host info Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 09/22] net/ena/base: update generation date and commit Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 10/22] net/ena/base: use rte_prefetch0_write Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 11/22] net/ena/base: adjust changes to lastest ena-com Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 12/22] net/ena: fix parsing of large_llq_hdr argument Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 13/22] net/ena: terminate devargs allowed keys with NULL Michal Krawczyk
2021-05-07 16:47       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 14/22] net/ena: indicate Rx RSS hash presence Michal Krawczyk
2021-05-07 16:47       ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-05-09 14:20         ` Michał Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 15/22] net/ena: remove endian swap functions Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 16/22] net/ena: handle spurious wakeups in ENA_WAIT_EVENT Michal Krawczyk
2021-05-07 16:55       ` Ferruh Yigit
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 17/22] net/ena: support SMP for mz alloc counter Michal Krawczyk
2021-05-07 16:48       ` Ferruh Yigit
2021-05-07 17:18         ` Stanislaw Kardach
2021-05-09 13:41           ` Ferruh Yigit
2021-05-10  8:18             ` Stanislaw Kardach
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 18/22] net/ena: move default RSS key to shared mem Michal Krawczyk
2021-05-10  8:27       ` Stanislaw Kardach
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 19/22] net/ena: make ethdev references smp safe Michal Krawczyk
2021-05-07 16:49       ` Ferruh Yigit
2021-05-09 14:40         ` Michał Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 20/22] net/ena: disable dev_ops not supported in SMP Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 21/22] net/ena: report default ring size Michal Krawczyk
2021-05-06 14:25     ` [dpdk-dev] [PATCH v3 22/22] net/ena: update version to v2.3.0 Michal Krawczyk
2021-05-07 16:50       ` Ferruh Yigit
2021-05-09 14:33         ` Michał Krawczyk
2021-05-07 14:59     ` [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD " Ferruh Yigit
2021-05-07 15:07       ` Ferruh Yigit
2021-05-10 12:02       ` Michał Krawczyk
2021-05-10 12:27         ` Ferruh Yigit [this message]
2021-05-11  6:45           ` [dpdk-dev] [PATCH v4 00/19] " Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 01/19] net/ena: switch memcpy to dpdk-optimized version Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 02/19] net/ena/base: unify arg names for the functions Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 03/19] net/ena/base: add dev arg to the logging macros Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 04/19] net/ena/base: style and comments improvements Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 05/19] net/ena/base: fix issues from the static code scan Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 06/19] net/ena/base: destroy multiple "wait events" Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 07/19] net/ena/base: remove indir table from ENA feat ctx Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 08/19] net/ena/base: remove mutable RSS from the host info Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 09/19] net/ena/base: use rte prefetch0 write Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 10/19] net/ena/base: adjust changes to lastest ena-com Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 11/19] net/ena: fix parsing of large LLQ header devarg Michal Krawczyk
2021-05-12 17:48               ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 12/19] net/ena: terminate devargs allowed keys with null Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 13/19] net/ena: indicate Rx RSS hash presence Michal Krawczyk
2021-05-11 12:16               ` Ferruh Yigit
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 14/19] net/ena: remove endian swap functions Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 15/19] net/ena: handle spurious wakeups in ENA wait event Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 16/19] net/ena: make ethdev references SMP safe Michal Krawczyk
2021-05-11 12:22               ` Ferruh Yigit
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 17/19] net/ena: disable dev ops not supported in SMP Michal Krawczyk
2021-05-11 12:29               ` Ferruh Yigit
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 18/19] net/ena: report default ring size Michal Krawczyk
2021-05-11  6:45             ` [dpdk-dev] [PATCH v4 19/19] net/ena: update version to v2.3.0 Michal Krawczyk
2021-05-11 13:07             ` [dpdk-dev] [PATCH v4 00/19] net/ena: update ENA PMD " Ferruh Yigit
2021-05-11 13:34               ` Michał Krawczyk
2021-05-12 10:13                 ` [dpdk-dev] [PATCH v5 0/3] " Michal Krawczyk
2021-05-12 10:13                   ` [dpdk-dev] [PATCH v5 1/3] net/ena: indicate Rx RSS hash presence Michal Krawczyk
2021-05-12 10:13                   ` [dpdk-dev] [PATCH v5 2/3] net/ena: make ethdev references multiprocess safe Michal Krawczyk
2021-05-12 10:13                   ` [dpdk-dev] [PATCH v5 3/3] net/ena: disable dev ops not supported by secondary process Michal Krawczyk
2021-05-12 12:20                   ` [dpdk-dev] [PATCH v5 0/3] net/ena: update ENA PMD to v2.3.0 Ferruh Yigit
2021-05-07 15:52     ` [dpdk-dev] [PATCH v3 00/22] " Ferruh Yigit
2021-05-09 14:15       ` Michał Krawczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87e65a42-4ae5-1a81-8f8e-74759fc14999@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=gtzalik@amazon.com \
    --cc=igorch@amazon.com \
    --cc=mk@semihalf.com \
    --cc=ndagan@amazon.com \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).