Re: [EXTERNAL] Re: [v11 0/4] PCI Dev and SG copy support

[fengchengwen <fengchengwen@huawei.com>]

Hi Thomas,

On 2024/3/12 17:15, Thomas Monjalon wrote:
> 07/03/2024 14:55, Gowrishankar Muthukrishnan:
>> Hi Fengchengwen,
>>
>>>> Waiting for a confirmation that this series is good to go.
>>>
>>> In the discuss of thread [1], I hope this patchset continue take a step forward
>>> (means new version) to support bi-direction test just by modify config.ini file.
>>>
>>
>> This patch set already exposes all configuration via config.ini. I didn't follow what is missing. For bi-direction, we can better continue discussing on that patch.
> 
> Chengwen, please can you confirm whether you require a new version?
> Which change exactly is missing?

This patchset is OK with one sub-test only tackle one DMA direction.

But there is a later patch [1] which will support multiple DMA directions within one sub-test.
it will add a entry "xfer_mode", but I think it complicate the test, I prefer we do more in
this patchset to support some like bi-direction just by modify config.ini, some like this:

1. extend lcore_dma:
   current lcore_dma is: lcore10@0000:00:04.2
   extend it support: lcore10@0000:00:04.2,dir=m2d,coreid=1,pfid=2,vfid=3,raddr=0xXXXX
2. to fix one entry can't hold too many dma device, support entrys: lcore_dma_1, lcore_dma_2
   which value is same with lcore_dma.

So for bi-direction, we just define config.ini as:
lcore_dma=lcore10@0000:00:04.2,dir=m2d,coreid=1,pfid=2,vfid=3,raddr=0xXXXX, lcore10@0000:00:04.2,dir=d2m,coreid=1,pfid=2,vfid=3,raddr=0xXXXX

[1] https://patches.dpdk.org/project/dpdk/patch/20240229141426.4188428-1-amitprakashs@marvell.com/

>