From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA8C4A0550; Wed, 25 May 2022 13:48:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49A6340146; Wed, 25 May 2022 13:48:14 +0200 (CEST) Received: from mail-108-mta108.mxroute.com (mail-108-mta108.mxroute.com [136.175.108.108]) by mails.dpdk.org (Postfix) with ESMTP id 840C5400EF for ; Wed, 25 May 2022 13:48:12 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta108.mxroute.com (ZoneMTA) with ESMTPSA id 180fb0bb156000c327.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 25 May 2022 11:48:09 +0000 X-Zone-Loop: 101e17c8b6b815919122d1de59001129531a73658008 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=i3r+GutG6BqjCHo8GRMPNkiuINE8QBs76koqyWsMwzk=; b=JJXqKSeIBDK/BTR2cMu1SswIYC fycGfcwovguOowOikucoz9JkNqel8aMut+qvHyEN3qFnrbJx3e+34w6Sx5JjF7F8wkOMglP9WYj6H YXkfO+wYoPP7PyTcxJZu4Tu53DocNcwoKg7viOQb9bvNw4seRH3w2nweIeX6kLWOZmwqwle1W56Tx c+xTDc9BBOaI+MIREhiiDz5hRGVS48YNmK/8TMRqceAjavUUI74Sek43DzVh1hzHaJLkBGPDNdnNC to4Rc/nL8K7zVdsILhxEU6Q5UGQv62yy4kKCLRJemKLE44qVjvHRWAFnbJ86lvvGjqpIQ+Ya1WaV7 9YBb5msQ==; References: <20220525095307.675312-1-thomas@monjalon.net> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, techboard@dpdk.org, David Christensen Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector In-reply-to: <20220525095307.675312-1-thomas@monjalon.net> Date: Wed, 25 May 2022 12:48:05 +0100 Message-ID: <87ee0hzvd6.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas Monjalon writes: > The AltiVec header file is defining "vector", except in C++ build. > The keyword "vector" may conflict easily. > As a rule, it is better to use the alternative keyword "__vector". > > The DPDK header file rte_altivec.h takes care of undefining "vector", > so the applications and dependencies are free to define the name "vector". > > This is a compatibility breakage for applications which were using > the keyword "vector" for its AltiVec meaning. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/release_22_07.rst | 5 +++++ > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ > 2 files changed, 12 insertions(+) > Acked-by: Ray Kinsella