From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E233A00C5; Wed, 2 Feb 2022 12:51:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52CF840E28; Wed, 2 Feb 2022 12:51:20 +0100 (CET) Received: from mail-108-mta173.mxroute.com (mail-108-mta173.mxroute.com [136.175.108.173]) by mails.dpdk.org (Postfix) with ESMTP id 2896A40688 for ; Wed, 2 Feb 2022 12:51:19 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta173.mxroute.com (ZoneMTA) with ESMTPSA id 17eba464eb40005a20.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 02 Feb 2022 11:51:16 +0000 X-Zone-Loop: b882caf52c49e585d0747b1c117641d5a33119f52d04 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YtIdHAQO9fyw2K5HW0B4fRTz0NIyc/6RTRjx/wl9u3Q=; b=IEUu0Kj8ITntzTQZ5DfBvvZI0N V7lMjeVr7/RHMgHU1nNCOtyezWK7+nhejVsQTNG9lIbtJvCWf78liDoxhZFNL2pSCuKU7QuIYl7Tj aa6g6uqAIliRgaQ1RS521cGrdjt5orjG2eJIDZCN5SeQ1eWE756JlKiiDwwY61kfS4m0JSZaKgkoZ bgYCfPfAkg1LZuw4X8w5arQsGXlCMKchBaJcWcMpG9q8wXEUnA14i2ou2V6LV46iVdYTPwzP37/0/ 9B5RfO0uqbejV0IMsxVfIk4yAcWhEznFdUpzIkTeIhBeEjWG0n+NzCjW9IVuwMN6YdQVGdyV4AHsg LtjCfHbQ==; References: <20220201085002.320102-1-ivan.malov@oktetlabs.ru> <20220201085002.320102-6-ivan.malov@oktetlabs.ru> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Ivan Malov Cc: dev@dpdk.org, Andrew Rybchenko , Andy Moreton , Thomas Monjalon , ferruh.yigit@intel.com, David Marchand Subject: Re: [PATCH 5/8] common/sfc_efx/base: support selecting RSS table entry count In-reply-to: <20220201085002.320102-6-ivan.malov@oktetlabs.ru> Date: Wed, 02 Feb 2022 06:51:12 -0500 Message-ID: <87fsp11o7j.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ivan Malov writes: > On Riverhead boards, the client can control how many entries > to have in the indirection table of an exclusive RSS context. > > Provide the new parameter to clients and indicate its bounds. > Extend the API for writing the table to have the flexibility. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > drivers/common/sfc_efx/base/ef10_impl.h | 1 + > drivers/common/sfc_efx/base/ef10_nic.c | 13 +++ > drivers/common/sfc_efx/base/ef10_rx.c | 136 +++++++++++++++++++++-- > drivers/common/sfc_efx/base/efx.h | 18 +++ > drivers/common/sfc_efx/base/efx_impl.h | 3 +- > drivers/common/sfc_efx/base/efx_mcdi.h | 11 ++ > drivers/common/sfc_efx/base/efx_rx.c | 38 ++++++- > drivers/common/sfc_efx/base/rhead_impl.h | 1 + > drivers/common/sfc_efx/base/rhead_rx.c | 4 +- > drivers/common/sfc_efx/version.map | 1 + > 10 files changed, 212 insertions(+), 14 deletions(-) > > > diff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map > index 97dd943ec4..9510897b83 100644 > --- a/drivers/common/sfc_efx/version.map > +++ b/drivers/common/sfc_efx/version.map > @@ -216,6 +216,7 @@ INTERNAL { > efx_rx_qpost; > efx_rx_qpush; > efx_rx_scale_context_alloc; > + efx_rx_scale_context_alloc_v2; > efx_rx_scale_context_free; > efx_rx_scale_default_support_get; > efx_rx_scale_hash_flags_get; So this internal, so ordinarly I have little enough to do or say about it. In this case, I do have to ask is the _v2 version of the function avoidable? -- Regards, Ray K