From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 549A9A0563; Fri, 3 Jun 2022 16:30:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3C1340694; Fri, 3 Jun 2022 16:30:45 +0200 (CEST) Received: from mail-108-mta255.mxroute.com (mail-108-mta255.mxroute.com [136.175.108.255]) by mails.dpdk.org (Postfix) with ESMTP id 1C2F24021E for ; Fri, 3 Jun 2022 16:30:44 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta255.mxroute.com (ZoneMTA) with ESMTPSA id 18129f9b905000c327.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 03 Jun 2022 14:30:40 +0000 X-Zone-Loop: 60ccaec25d8dc5bfb0f762719c5e51cd80430978231c X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kX1Mf0Wzlxu51o38AUTMrsIRk2dOPrDUq+rWUB/AzVY=; b=BNEHaIdMEW4beSQclQlVEqjOKd BV0e9q3zrQNj93LoJSqYRMSXB9lCxZja5ToSDOl+2qP2lnxKUI0jlSBPfd1Ho1H2l8hG0dZCe9c/u BM+aRqXKhc+Is5mZ5EaeRYdKtl66aacg7Hg4wU+S8OVl2B47ctBxDceO/S+As9wfaSZVHhUS38yb+ Yk2DjADfaBxJ20aszaFltfSPnvl65G1TQorZlNPl28EAkT9ORWyCQsCerJemG7PTdVFKiZkVHuLAr E6cPz2EQ48xLXeR2t0GGgNkan0CVeMU2qf3Gx9kvwkbIfRuFz28KMPa5Sa2Rmhq4ajOOP6qwL/EmB DIiEfG8A==; References: <20220524152041.737154-1-spiked@nvidia.com> <20220603124821.1148119-1-spiked@nvidia.com> <20220603124821.1148119-3-spiked@nvidia.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Ray Kinsella To: Spike Du Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, Shahaf Shuler , Neil Horman , andrew.rybchenko@oktetlabs.ru, stephen@networkplumber.org, mb@smartsharesystems.com, dev@dpdk.org, rasland@nvidia.com Subject: Re: [PATCH v4 2/7] common/mlx5: share interrupt management Date: Fri, 03 Jun 2022 15:30:20 +0100 In-reply-to: <20220603124821.1148119-3-spiked@nvidia.com> Message-ID: <87h751q0ol.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Spike Du writes: > There are many duplicate code of creating and initializing rte_intr_handle. > Add a new mlx5_os API to do this, replace all PMD related code with this > API. > > Signed-off-by: Spike Du > --- > drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++++++++++++++++++++++++++ > drivers/common/mlx5/linux/mlx5_common_os.h | 11 +++ > drivers/common/mlx5/version.map | 2 + > drivers/common/mlx5/windows/mlx5_common_os.h | 24 +++++ > drivers/net/mlx5/linux/mlx5_ethdev_os.c | 71 -------------- > drivers/net/mlx5/linux/mlx5_os.c | 132 ++++++--------------------- > drivers/net/mlx5/linux/mlx5_socket.c | 53 ++--------- > drivers/net/mlx5/mlx5.h | 2 - > drivers/net/mlx5/mlx5_txpp.c | 28 ++---- > drivers/net/mlx5/windows/mlx5_ethdev_os.c | 22 ----- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 48 ++-------- > 11 files changed, 217 insertions(+), 307 deletions(-) > Acked-by: Ray Kinsella