From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E210A00BE; Mon, 20 Dec 2021 00:12:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2D8D40141; Mon, 20 Dec 2021 00:12:21 +0100 (CET) Received: from mail-108-mta25.mxroute.com (mail-108-mta25.mxroute.com [136.175.108.25]) by mails.dpdk.org (Postfix) with ESMTP id 84CDC40140 for ; Mon, 20 Dec 2021 00:12:19 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta25.mxroute.com (ZoneMTA) with ESMTPSA id 17dd4f78ec7000b7bf.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 19 Dec 2021 23:12:13 +0000 X-Zone-Loop: 5a5c52f163765e5b13474f049ce42b4ea13a62d5cb88 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Date:In-reply-to:Message-ID:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y5FJvhcVd/R+eCrpMWo7QY264ApMNpoLngp2GLywdsk=; b=iDbbz9D6r0CmojybLEvvphWlfc ORw9iWsNPcOV/xcIJ3pch2RYnMgHbfFWc75bqs6AXg3ZPKYSR9F0llrTokA5yBNbcL1b/WeSq0TRl R0fmmPyJC9lFUYMxP9O8wFWaTk8TKsc44QeWOY08er91FLrYZu+4vPkFOWEZbZ9u/VatqBMdTDNiI I5ar+EchjYUxiwFoWLIDvFoiitGbObbnMaiQWQ5P56oM9Yovb/7/X/S2Jczucay3uzONSu/yb6k5N FB1O3jHYsU42nzNbpwrVvbTe8cVBgTdvDtDQ3KHcCwHIe2NJcoMr9EpsbYnQNV9mOD1m3zb/p0372 ipLQM5Uw==; References: <20211213150402.3351032-1-ciara.power@intel.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: Ciara Power Cc: dev@dpdk.org, roy.fan.zhang@intel.com, gakhil@marvell.com, Declan Doherty , Ankur Dwivedi , Anoob Joseph , Tejasree Kondoj , John Griffin , Fiona Trahe , Deepak Kumar Jain Subject: Re: [PATCH] crypto: use single buffer for asymmetric session Message-ID: <87h7b4w620.fsf@mdr78.vserver.site> In-reply-to: <20211213150402.3351032-1-ciara.power@intel.com> Date: Sun, 19 Dec 2021 18:12:09 -0500 MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, RCPT_COUNT_SEVEN=0, FROM_HAS_DN=0, TO_DN_SOME=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, NEURAL_SPAM=0] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ciara, One minor niggle. Ciara Power writes: > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > index c50745fa8c..00b1c9ae35 100644 > --- a/lib/cryptodev/version.map > +++ b/lib/cryptodev/version.map > @@ -58,7 +58,6 @@ EXPERIMENTAL { > rte_cryptodev_asym_session_clear; > rte_cryptodev_asym_session_create; > rte_cryptodev_asym_session_free; > - rte_cryptodev_asym_session_init; > rte_cryptodev_asym_xform_capability_check_modlen; > rte_cryptodev_asym_xform_capability_check_optype; > rte_cryptodev_sym_cpu_crypto_process; > @@ -104,6 +103,11 @@ EXPERIMENTAL { > rte_cryptodev_remove_deq_callback; > rte_cryptodev_remove_enq_callback; > > + # added 22.03 rte_cryptodev_asym_session_get_user_data should be before rte_cryptodev_asym_session_pool_create, right? > + rte_cryptodev_asym_session_pool_create; > + rte_cryptodev_asym_session_get_user_data; > + rte_cryptodev_asym_session_set_user_data; > + __rte_cryptodev_trace_asym_session_pool_create; > }; > > INTERNAL { -- Regards, Ray K