From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26BD2A052A; Wed, 27 Jan 2021 22:35:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ABB8B140F79; Wed, 27 Jan 2021 22:35:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 05DF6140F71 for ; Wed, 27 Jan 2021 22:35:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611783343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=j+iwmA/i1AvBA3efOTMoFfS7Yewwfz6nMDZngmLh+e4=; b=GYkl/9K2jpcyA25b+aIbIyOQUX/V3Yd7YfdbmR+MjN6tpCERlMps92C/ZjpSWHbiB5I6vX 4YYiVY4ehUo9xJ/teF6mOnie46ThsW/IcpwVh1UGuerH470l40/yKdHXlWgASWHVCGZs9i mfRPfIiHc1ww9ubiUKNoG4MoOKGIe9U= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-1w2jSn1hP3C-5kiv7EfImQ-1; Wed, 27 Jan 2021 16:35:39 -0500 X-MC-Unique: 1w2jSn1hP3C-5kiv7EfImQ-1 Received: by mail-ed1-f70.google.com with SMTP id j12so2081336edq.10 for ; Wed, 27 Jan 2021 13:35:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:date :message-id:mime-version; bh=j+iwmA/i1AvBA3efOTMoFfS7Yewwfz6nMDZngmLh+e4=; b=ERumr3VnsUJ7i58dFG3H/y/OUmW9fmSHoOwlIn5b4dBobdRfs3UwLibQ+2w88rV5pZ 7SirDMx+3A6QUr80WkDT7UCsgji4ogBdOmYliorZAwTV7BwxRDcvStK5/18+duQyCbrY ylk1xS2JkPqh0wz5gNeTylSeMlEALs42gI8XP55Nt9KfP+TablKDkHxl1JOY40OrioJB odn3xk1easGcc2TSLlirWU2GZL4ESZ6s6+Trdd+iMPvsc1TzJRiyghbOZM6XsE9T6sTe 50EDNaJjrW0EdeI6rfRvMhm71szS3JxQC/EdgxFzssXZbyiI5hnFsKKHR1qp7RFR2VbU E07g== X-Gm-Message-State: AOAM531HJ4vO8otVeTHoz/3Xcw1lXCGueI5MOT8OfbbxeA253jsvkYkK rlcnK0Apnp51FLf405ohm9GdXEMWJAqdNIxq2zrfV1JtFcOPaVkQnijqZyOuaKvyjnqCUCPJoBi g/OM= X-Received: by 2002:a05:6402:1ad0:: with SMTP id ba16mr10873106edb.287.1611783338113; Wed, 27 Jan 2021 13:35:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtPeeB1+ZXkUKH6SjcRWU61RgP8ko6Z6NGZr5VTUf5tUC5BZIhyYzBj9HX32Jb+0lhkvOoag== X-Received: by 2002:a05:6402:1ad0:: with SMTP id ba16mr10873100edb.287.1611783337940; Wed, 27 Jan 2021 13:35:37 -0800 (PST) Received: from localhost (net-37-116-32-78.cust.vodafonedsl.it. [37.116.32.78]) by smtp.gmail.com with ESMTPSA id o13sm1956387edt.64.2021.01.27.13.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 13:35:37 -0800 (PST) From: Paolo Valerio To: "Wang, Haiyue" Cc: "Guo, Jia" , Aaron Conole , "dev@dpdk.org" Cc: In-Reply-To: Date: Wed, 27 Jan 2021 22:35:25 +0100 Message-ID: <87im7i12si.fsf@fed.void> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pvalerio@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" "Wang, Haiyue" writes: > Hi Paolo, > >> -----Original Message----- >> From: Paolo Valerio >> Sent: Wednesday, January 27, 2021 21:50 >> To: dev@dpdk.org >> Cc: Guo, Jia ; Wang, Haiyue ; Aaron Conole >> >> Subject: ixgbe and UDP with zero checksum >> >> Hi, >> >> performing some tests, I noticed that on ixgbe when receiving UDP >> packets with zero checksum (no checksum) over IPv4, the corresponding >> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD. >> >> In particular, this apparently has an impact on OvS using ct() action >> where UDP packets with zero checksum are not tracked because of that. > > >> >> [1] >> https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.1531.stgit@localhost.localdomai >> n/ > > About 12 years old patch, it is hardware errata. For fixing this, > have to always disable vector Rx path for 82599, it seems not a > good idea to bring in this workaround. :( > Thanks for the answer. Yes, as I mentioned, the patch is old although still meaningful. I linked it mostly because it mentions the hw errata. I would refer to Aaron's questions because they bring up the point. > + /* > + * 82599 errata, UDP frames with a 0 checksum can be marked as > + * checksum errors. > + */ > + if ((pkt_info & IXGBE_RXDADV_PKTTYPE_UDP) && > + (adapter->hw.mac.type == ixgbe_mac_82599EB)) > + return; > >> >> Regards, >> Paolo