From: Ray Kinsella <mdr@ashroe.eu>
To: peng1x.zhang@intel.com
Cc: dev@dpdk.org, Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] net/ice: promote dynflag API
Date: Tue, 19 Apr 2022 11:55:52 -0400 [thread overview]
Message-ID: <87k0blnk3b.fsf@mdr78.vserver.site> (raw)
In-Reply-To: <20220414062510.207983-1-peng1x.zhang@intel.com>
peng1x.zhang@intel.com writes:
> From: Peng Zhang <peng1x.zhang@intel.com>
>
> Promote dynflag APIs to be stable.
>
> Signed-off-by: Peng Zhang <peng1x.zhang@intel.com>
> ---
> drivers/net/ice/rte_pmd_ice.h | 1 -
> drivers/net/ice/version.map | 15 +++++++++------
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ice/rte_pmd_ice.h b/drivers/net/ice/rte_pmd_ice.h
> index 9a436a140b..13604bf9e2 100644
> --- a/drivers/net/ice/rte_pmd_ice.h
> +++ b/drivers/net/ice/rte_pmd_ice.h
> @@ -149,7 +149,6 @@ extern uint64_t rte_net_ice_dynflag_proto_xtr_ip_offset_mask;
> * @return
> * True if registered, false otherwise.
> */
> -__rte_experimental
> static __rte_always_inline int
> rte_net_ice_dynf_proto_xtr_metadata_avail(void)
> {
> diff --git a/drivers/net/ice/version.map b/drivers/net/ice/version.map
> index cc837f1c00..4cbe33a40d 100644
> --- a/drivers/net/ice/version.map
> +++ b/drivers/net/ice/version.map
> @@ -1,16 +1,19 @@
> DPDK_22 {
> - local: *;
> -};
> + global:
>
> -EXPERIMENTAL {
> - global:
> -
> - # added in 19.11
> rte_net_ice_dynfield_proto_xtr_metadata_offs;
> rte_net_ice_dynflag_proto_xtr_vlan_mask;
> rte_net_ice_dynflag_proto_xtr_ipv4_mask;
> rte_net_ice_dynflag_proto_xtr_ipv6_mask;
> rte_net_ice_dynflag_proto_xtr_ipv6_flow_mask;
> rte_net_ice_dynflag_proto_xtr_tcp_mask;
Folks, these are all exported variables, we should be removing these not
promoting these to stable. After looking at them closely, can't we just
make them local, do they need to be exported at all?
--
Regards, Ray K
next prev parent reply other threads:[~2022-04-19 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 6:25 peng1x.zhang
2022-04-19 15:55 ` Ray Kinsella [this message]
2022-04-20 13:42 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0blnk3b.fsf@mdr78.vserver.site \
--to=mdr@ashroe.eu \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=peng1x.zhang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).