From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ECF6A0528; Thu, 9 Jul 2020 17:52:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E92CE1E89B; Thu, 9 Jul 2020 17:52:19 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id D51561E894 for ; Thu, 9 Jul 2020 17:52:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594309938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JBC6YN/HJvZioNSIml9zdPDy3/jFHAUUUcCUJ9242uw=; b=EhU/4opqStNd7Dwy2OftXqHHHba6us5xdmVX0EF6rw47qEBX7KDvwMQkeFwJq5G7BRp+wr F+4sbwhwBXYyroQJzPj2/HYNji113+lKirQgP/tQYwuynp7YAQSadW+IkeVQ1tdMGc9c+H XupNiwqdhXUQ48FAcjG6xvJha3sO0qo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-rchl7obOPLyFgedU5MXjhQ-1; Thu, 09 Jul 2020 11:52:16 -0400 X-MC-Unique: rchl7obOPLyFgedU5MXjhQ-1 Received: by mail-wr1-f70.google.com with SMTP id b8so2290769wro.19 for ; Thu, 09 Jul 2020 08:52:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version; bh=JBC6YN/HJvZioNSIml9zdPDy3/jFHAUUUcCUJ9242uw=; b=EhA8VHyTX1LHiPqaLx1dBLQxXaurJMzZPYaMii7VW7tULT3aYB0/GmxSziMKLN2XVB 2QSu1n+m/sgxMjoUTa/UUO6lRPg3JGZC6GKBf4C6MLySrh15gAaP+5RX4vylkhBPJJxZ 4M6+iSWWsUY2DScY8Rfc5uMWBnOLPcWRZNp+WzHkKhwOIPXyGyNHGqNKyEGV137GwMcL M86Y7lAyKMvBCKg5Gbz8NTtA3TPe6JGh5BYGSStaobhQQ7xhrP5Y4UmRZOgFOescWwVX vcbeFcbirR1Krd1ZQ2SiK7JVtQwoF+tAiMuVKDqGxGz5BP+pcXA7ZmZeRHWFAe7Heoi4 cI3g== X-Gm-Message-State: AOAM533imvxioPjGZ8h9A+8sD6Aa4uAFDXITy/GPwoAx6vLyPSb7Jw8m BgVe27bt6u1gxyaTtrw4HFqluLEs3Ixu/D9Mvo5zgGPXbFkwGSmfDsbnM1WTkteGh3nmCNtj++z tccM= X-Received: by 2002:a5d:6452:: with SMTP id d18mr63337851wrw.284.1594309935299; Thu, 09 Jul 2020 08:52:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRwr7LSoVus3/t48KnCpRULyRB0rDAkuamEPkUhuFPU49oUnPpUYLeVR3l0DEZ4d+GGnSciQ== X-Received: by 2002:a5d:6452:: with SMTP id d18mr63337835wrw.284.1594309935011; Thu, 09 Jul 2020 08:52:15 -0700 (PDT) Received: from localhost (91-166-131-130.subs.proxad.net. [91.166.131.130]) by smtp.gmail.com with ESMTPSA id 12sm5089075wmg.6.2020.07.09.08.52.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2020 08:52:13 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id DECB1180092E; Thu, 9 Jul 2020 17:52:11 +0200 (CEST) From: Dodji Seketeli To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Ray Kinsella , Neil Horman Organization: Red Hat / France References: <20200708102212.3311-1-david.marchand@redhat.com> X-Operating-System: Red Hat Enterprise Linux Workstation 7.8 Beta X-URL: http://www.redhat.com Date: Thu, 09 Jul 2020 17:52:11 +0200 In-Reply-To: <20200708102212.3311-1-david.marchand@redhat.com> (David Marchand's message of "Wed, 8 Jul 2020 12:22:12 +0200") Message-ID: <87r1tkptxw.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dodji@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, David Marchand writes: > abidiff can provide some more information about the ABI difference it > detected. > In all cases, a discussion on the mailing must happen but we can give > some hints to know if this is a problem with the script calling abidiff, > a potential ABI breakage or an unambiguous ABI breakage. > > Signed-off-by: David Marchand For what it's worth, the change looks good to me, at least from an abidiff perspective. Thanks. Cheers. -- Dodji