From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26B3CA0548; Thu, 2 Jun 2022 16:21:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AC1640691; Thu, 2 Jun 2022 16:21:35 +0200 (CEST) Received: from mail-108-mta159.mxroute.com (mail-108-mta159.mxroute.com [136.175.108.159]) by mails.dpdk.org (Postfix) with ESMTP id 9FE284021E for ; Thu, 2 Jun 2022 16:21:33 +0200 (CEST) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta159.mxroute.com (ZoneMTA) with ESMTPSA id 18124caf775000c327.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 02 Jun 2022 14:21:30 +0000 X-Zone-Loop: 535b722a37799c5e5ea6bb0f3fe3c02f863a853be5c8 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:In-reply-to:Date:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GOR2Lr9z91dJQ/9iVh0ShcpiB5Y08ip+Oqkv9TxuQrU=; b=Zf3hlr7eMXB9HKwKLLOQccu+dM TfzKWlKu1g2qK53nmS7OPEkyq5Kf9Tt7wWUcn8oKwNSqSozdCS3oU4rNEAMMVULlawPlaDS/l+cV5 AyE1yjGYpOPPtIznqg1y0J7tpTlVDbeMItkOCmJqOSzZSUOzI/AK2OGe7hmYmYLJX4hFXOlZg9If+ 6BILqCq9ykH3/5rvPP7fg3HgMgEeH/b0QQbsWxoKRuIYHDAZ+FULf9RLklEhtB7128bP2v+XmbM7C +EcvbIab8k222Xi8XhKA+CKKUr57XDzFzqhnX08rLIlLI1RwslMi+yc2kwCRTLXCVngOL5P+z0Pfj VsyBaHsg==; References: <20220601090249.86865-1-arkadiuszx.kusztal@intel.com> <20220601090249.86865-7-arkadiuszx.kusztal@intel.com> User-agent: mu4e 1.6.10; emacs 27.1 From: Ray Kinsella To: Akhil Goyal Cc: Arek Kusztal , "dev@dpdk.org" , "roy.fan.zhang@intel.com" Subject: Re: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman Date: Thu, 02 Jun 2022 15:21:16 +0100 In-reply-to: Message-ID: <87y1yfp2mw.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Akhil Goyal writes: >> - Added elliptic curve Diffie-Hellman parameters. >> Point multiplication allows the user to process every phase of >> ECDH, but for phase 1, user should not really care about the generator. >> The user does not even need to know what the generator looks like, >> therefore setting ec xform would make this work. >> >> Signed-off-by: Arek Kusztal >> --- >> devtools/libabigail.abignore | 3 +++ >> doc/guides/cryptodevs/features/default.ini | 1 + >> doc/guides/prog_guide/cryptodev_lib.rst | 7 +++--- >> doc/guides/rel_notes/release_22_07.rst | 2 ++ >> lib/cryptodev/rte_crypto_asym.h | 38 >> ++++++++++++++++++++++++++++++ >> 5 files changed, 48 insertions(+), 3 deletions(-) >> >> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore >> index 79ff15dc4e..6d174b291f 100644 >> --- a/devtools/libabigail.abignore >> +++ b/devtools/libabigail.abignore >> @@ -27,6 +27,9 @@ >> ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is >> experimental >> [suppress_type] >> name = rte_crypto_asym_op >> +; Ignore changes to rte_crypto_asym_xform_type, asymmetric crypto API is >> experimental >> +[suppress_type] >> + name = rte_crypto_asym_xform_type >> > This exception does not seem to work. > Thomas and I are getting ABI issues even with this suppress rule. > > [C] 'function void rte_cryptodev_info_get(uint8_t, rte_cryptodev_info*)' at rte_cryptodev.c:1582:1 has some indirect sub-type changes: > parameter 2 of type 'rte_cryptodev_info*' has sub-type changes: > in pointed to type 'struct rte_cryptodev_info' at rte_cryptodev.h:503:1: > type size hasn't changed > 1 data member change: > type of 'const rte_cryptodev_capabilities* capabilities' changed: > in pointed to type 'const rte_cryptodev_capabilities': > in unqualified underlying type 'struct rte_cryptodev_capabilities' at rte_cryptodev.h:198:1: > type size hasn't changed > 1 data member change: > type of 'anonymous data member union {rte_cryptodev_symmetric_capability sym; rte_cryptodev_asymmetric_capability asym;}' changed: > type size hasn't changed > 1 data member change: > type of 'rte_cryptodev_asymmetric_capability asym' changed: > type size hasn't changed > 1 data member change: > type of 'rte_cryptodev_asymmetric_xform_capability xform_capa' changed: > type size hasn't changed > 1 data member change: > type of 'rte_crypto_asym_xform_type xform_type' changed: > type size hasn't changed > 1 enumerator insertion: > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECDH' value '8' > 2 enumerator changes: > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_ECPM' from value '8' to '9' at rte_crypto_asym.h:80:1 > 'rte_crypto_asym_xform_type::RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END' from value '9' to '10' at rte_crypto_asym.h:80:1 Ok - will take a look see. -- Regards, Ray K