From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12879A0548; Sun, 7 Feb 2021 19:40:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AF581606BB; Sun, 7 Feb 2021 19:40:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id AE46D40147 for ; Sun, 7 Feb 2021 19:40:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612723254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/648Ru7wot4FdkxuQeAo1YngQNobf8Daa8LyLWxCjY=; b=IHTLjZNMz7py20LOZO+oy0VfPFt1Ko7mkKVenusAV/hOwas1dvGoSK5mkeEzR6dmkTV5IS DC+8qktDaRCuZtepqU3hlGxHMMsI8SuyRml2jvwCJ1YpOX4jh5GP+cP9/KJWtoEDTx//ev lbSgHlq+tIFppoDSCIUIoim6csatR6o= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-jd06OAyPN5uqBHt7vrQKjQ-1; Sun, 07 Feb 2021 13:40:52 -0500 X-MC-Unique: jd06OAyPN5uqBHt7vrQKjQ-1 Received: by mail-wr1-f69.google.com with SMTP id n18so11429965wrm.8 for ; Sun, 07 Feb 2021 10:40:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=9/648Ru7wot4FdkxuQeAo1YngQNobf8Daa8LyLWxCjY=; b=eUATehLmZKXn5MTbqJs1+IZ11rgQF91YlYz1HQgi9ad7IiZI87qDQ4YJtsDNVkngZN lh7EUOKO8TKfGALPyX9yxEWzfwDy2ANNi5x4QyPU4YZKac2zChbCQn7sPEF3CysQ8cZB McEkUBo7LpD+YRxLDFQZhF8PxkuRlcAJ1mlgWYzKEWx/3PnnSHp7/SDf9v5v3sQ6I+Ym dW0mcgsg8Xi7XPntjl0XJnM7vawMn0q+C1mRJ4qJ5jr/DXuZG3jZLsB7MNQx7qm/odtn RTIHXQQVl4CXYn1VGbHxofpVtxOYttVsVlsIsonx6In32Yx4iB2noiITjn5OgSH3vLQW J0Rg== X-Gm-Message-State: AOAM530TVZaRAkvw7sHWszXQoqt85iuFvRFcr2fLkSK6UCamID+Zn4tb F6U1yzcfmgq67Ru4OTVZaFGnMgl+bMRH4EJvRQb4fxL2G9eLx66y2+2z1Unu30UG8DP4Lyuhd5L mypM= X-Received: by 2002:adf:e5c6:: with SMTP id a6mr16383111wrn.400.1612723251695; Sun, 07 Feb 2021 10:40:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJwW4N7u5tt7nlXCinprxnwCpxda00V7sfH7hVwGSq3XDx3hEFL5moYc7+UP4OLHFk1tlYkSfA== X-Received: by 2002:adf:e5c6:: with SMTP id a6mr16383095wrn.400.1612723251522; Sun, 07 Feb 2021 10:40:51 -0800 (PST) Received: from localhost (net-37-116-32-78.cust.vodafonedsl.it. [37.116.32.78]) by smtp.gmail.com with ESMTPSA id v6sm23750660wrx.32.2021.02.07.10.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Feb 2021 10:40:50 -0800 (PST) From: Paolo Valerio To: Haiyue Wang , dev@dpdk.org Cc: aconole@redhat.com, david.marchand@redhat.com, qi.z.zhang@intel.com, leyi.rong@intel.com, Lijuan.Tu@intel.com, Ruifeng.Wang@arm.com, Feifei.Wang2@arm.com, Haiyue Wang , stable@dpdk.org, Jeff Guo , Bruce Richardson , Konstantin Ananyev Cc: In-Reply-To: <20210204143949.22827-1-haiyue.wang@intel.com> References: <20210202070652.145861-1-haiyue.wang@intel.com> <20210204143949.22827-1-haiyue.wang@intel.com> Date: Sun, 07 Feb 2021 19:40:45 +0100 Message-ID: <87y2fz202a.fsf@fed.void> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pvalerio@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix UDP zero checksum error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Haiyue Wang writes: > There is an 82599 errata that UDP frames with a zero checksum are > incorrectly marked as checksum invalid by the hardware. This was > leading to misleading PKT_RX_L4_CKSUM_BAD flag. > > This patch changes the bad UDP checksum to PKT_RX_L4_CKSUM_UNKNOWN, > so the software application will then have to recompute the checksum > itself if needed. > > Bugzilla ID: 629 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Reported-by: Paolo Valerio > Signed-off-by: Haiyue Wang > --- > v3: Update the hardware errata doc name and session > v2: Change the always GOOD checksum to UNKOWN if BAD. > --- > doc/guides/nics/ixgbe.rst | 10 ++++++++ > drivers/net/ixgbe/ixgbe_rxtx.c | 30 ++++++++++++++++++++---- > drivers/net/ixgbe/ixgbe_rxtx.h | 2 ++ > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 32 +++++++++++++++++++++++--- > 4 files changed, 67 insertions(+), 7 deletions(-) > Missed the tag in my previous email Tested-by: Paolo Valerio