DPDK patches and discussions
 help / color / mirror / Atom feed
From: Paolo Valerio <pvalerio@redhat.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>
Cc: "Guo, Jia" <jia.guo@intel.com>, Aaron Conole <aconole@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] ixgbe and UDP with zero checksum
Date: Fri, 29 Jan 2021 15:19:42 +0100
Message-ID: <87zh0rlta9.fsf@fed.void> (raw)
In-Reply-To: <BN8PR11MB379502BA74F4D745AAFDE567F7B99@BN8PR11MB3795.namprd11.prod.outlook.com>

"Wang, Haiyue" <haiyue.wang@intel.com> writes:

> Hi Paolo,
>
>> -----Original Message-----
>> From: Wang, Haiyue
>> Sent: Friday, January 29, 2021 10:02
>> To: Paolo Valerio <pvalerio@redhat.com>
>> Cc: Guo, Jia <jia.guo@intel.com>; Aaron Conole <aconole@redhat.com>; dev@dpdk.org
>> Subject: RE: ixgbe and UDP with zero checksum
>> 
>> > -----Original Message-----
>> > From: Paolo Valerio <pvalerio@redhat.com>
>> > Sent: Thursday, January 28, 2021 05:35
>> > To: Wang, Haiyue <haiyue.wang@intel.com>
>> > Cc: Guo, Jia <jia.guo@intel.com>; Aaron Conole <aconole@redhat.com>; dev@dpdk.org
>> > Subject: RE: ixgbe and UDP with zero checksum
>> >
>> > "Wang, Haiyue" <haiyue.wang@intel.com> writes:
>> >
>> > > Hi Paolo,
>> > >
>> > >> -----Original Message-----
>> > >> From: Paolo Valerio <pvalerio@redhat.com>
>> > >> Sent: Wednesday, January 27, 2021 21:50
>> > >> To: dev@dpdk.org
>> > >> Cc: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Aaron Conole
>> > >> <aconole@redhat.com>
>> > >> Subject: ixgbe and UDP with zero checksum
>> > >>
>> > >> Hi,
>> > >>
>> > >> performing some tests, I noticed that on ixgbe when receiving UDP
>> > >> packets with zero checksum (no checksum) over IPv4, the corresponding
>> > >> ol_flag for the l4 checksum is set to PKT_RX_L4_CKSUM_BAD.
>> > >>
>> > >> In particular, this apparently has an impact on OvS using ct() action
>> > >> where UDP packets with zero checksum are not tracked because of that.
>> > >
>> > >
>> > >>
>> > >> [1]
>> > >>
>> >
>> https://patchwork.ozlabs.org/project/netdev/patch/20090724040031.30202.1531.stgit@localhost.localdomai
>> > >> n/
>> > >
>> > > About 12 years old patch, it is hardware errata. For fixing this,
>> > > have to always disable vector Rx path for 82599, it seems not a
>> > > good idea to bring in this workaround. :(
>> > >
>> >
>> > Thanks for the answer.
>> > Yes, as I mentioned, the patch is old although still meaningful.
>> > I linked it mostly because it mentions the hw errata.
>> >
>> 
>> What's your PCI device ID ? My worked ixgbe:
>> 
>
> Sorry, I missed the PKT_RX_L4_CKSUM_BAD information, yes, my NIC have the issue.
>
>> 86:00.0 Ethernet controller [0200]: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection
>> [8086:10fb] (rev 01)
>> 
>> I'm wondering if people will complain that the patch will mark the real bad checksum UDP as
>
> Zero checksum is more popular case, please file a bug on https://bugs.dpdk.org/ to trace the fix.
>
> Thanks for pointing it out.
>

ack, I'm going to file it.

Thanks,
Paolo

>> GOOD. For handling this correctly, looks like driver needs to check the UDP's checksum value,
>> if zero, then skip the error information, but this makes driver do the network stack things ...
>> 
>> 


  reply	other threads:[~2021-01-29 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 13:49 Paolo Valerio
2021-01-27 17:26 ` Wang, Haiyue
2021-01-27 18:21   ` Aaron Conole
2021-01-27 21:35   ` Paolo Valerio
2021-01-29  2:02     ` Wang, Haiyue
2021-01-29  2:59       ` Wang, Haiyue
2021-01-29 14:19         ` Paolo Valerio [this message]
2021-02-02  7:41           ` Wang, Haiyue
2021-02-02  9:33             ` [dpdk-dev] 回复: " Feifei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh0rlta9.fsf@fed.void \
    --to=pvalerio@redhat.com \
    --cc=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=jia.guo@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git