From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id 7F8F91B776 for ; Tue, 15 May 2018 19:53:02 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 841D11435; Tue, 15 May 2018 10:53:01 -0700 (PDT) Received: from localhost (U203169.usa.Arm.com [10.118.105.159]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 513123F25D; Tue, 15 May 2018 10:53:01 -0700 (PDT) References: <1526372924-28411-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-1-git-send-email-gavin.hu@arm.com> <1526376227-25534-2-git-send-email-gavin.hu@arm.com> User-agent: mu4e 0.9.18; emacs 25.2.2 From: Sirshak Das To: Yongseok Koh Cc: Gavin Hu , "dev\@dpdk.org" , Sirshak Das , =?utf-8?Q?N=C3=A9lio?= Laranjeiro , Adrien Mazarguil , Shahaf Shuler In-reply-to: Date: Tue, 15 May 2018 12:52:56 -0500 Message-ID: <87zi10rekn.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Tue, 15 May 2018 22:50:01 +0200 Subject: Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 17:53:02 -0000 Hi Yongseok, We will make the commit message more verbose. As for the error: This is a clang compiler issue: drivers/net/mlx5/mlx5_rxtx_vec.c:37: /home/sirdas/code/commitc/dpdk-stable-18.02.1/drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments provided to function-like macro invocation (uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), Thank you Sirshak Das. Yongseok Koh writes: >> On May 15, 2018, at 2:23 AM, Gavin Hu wrote: > > The title should start from 'net/mlx5: ...' and please be more specific why > that pair of parentheses is needed. Add more commit messages and it'd be > better to add the error messages like you do in the other commit. > > To me, it still looks unnecessary. > > Thanks, > Yongseok > >> Signed-off-by: Gavin Hu >> Signed-off-by: Sirshak Das >> Reviewed-by: Phil Yang >> Reviewed-by: Honnappa Nagarahalli >> --- >> drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h >> index 2673d6b..71a5eaf 100644 >> --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h >> +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h >> @@ -167,8 +167,8 @@ txq_scatter_v(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, >> vst1q_u8((void *)t_wqe, ctrl); >> /* Fill ESEG in the header. */ >> vst1q_u16((void *)(t_wqe + 1), >> - (uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), >> - 0, 0, 0, 0 }); >> + ((uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len), >> + 0, 0, 0, 0 })); >> txq->wqe_ci = wqe_ci; >> } >> if (!n) >> @@ -300,10 +300,10 @@ txq_burst_v(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, uint16_t pkts_n, >> vst1q_u8((void *)t_wqe, ctrl); >> /* Fill ESEG in the header. */ >> vst1q_u8((void *)(t_wqe + 1), >> - (uint8x16_t) { 0, 0, 0, 0, >> - cs_flags, 0, 0, 0, >> - 0, 0, 0, 0, >> - 0, 0, 0, 0 }); >> + ((uint8x16_t) { 0, 0, 0, 0, >> + cs_flags, 0, 0, 0, >> + 0, 0, 0, 0, >> + 0, 0, 0, 0 })); >> #ifdef MLX5_PMD_SOFT_COUNTERS >> txq->stats.opackets += pkts_n; >> #endif >> -- >> 2.1.4 >>