From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C5DE02904 for ; Wed, 28 Jun 2017 17:51:33 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 08:51:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,276,1496127600"; d="scan'208";a="1165701110" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2017 08:51:32 -0700 To: Shreyansh Jain , dev@dpdk.org Cc: hemant.agrawal@nxp.com References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com> <1497591668-3320-39-git-send-email-shreyansh.jain@nxp.com> From: Ferruh Yigit Message-ID: <880c1d09-bb6f-bca4-13c7-cde1ccd28ac7@intel.com> Date: Wed, 28 Jun 2017 16:51:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1497591668-3320-39-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 38/38] net/dpaa: add packet dump for debugging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 15:51:34 -0000 On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain Is there a driver documentation, I haven't see any in net/dpaa patches? <...> > +CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER_DISPLAY=n > +CONFIG_RTE_LIBRTE_DPAA_CHECKING=n This config option is not used at all, can be removed. <...> > +#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER > + dpaa_debug_queue_init(&dpaa_intf->debug_queues[ > + DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err); Out of curiosity, what exactly done here. Is this a special queue, what is does? It can be useful if documented more in commit log. > + dpaa_intf->debug_queues[DPAA_DEBUG_FQ_RX_ERROR].dpaa_intf = dpaa_intf; > + dpaa_debug_queue_init(&dpaa_intf->debug_queues[ > + DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err); > + dpaa_intf->debug_queues[DPAA_DEBUG_FQ_TX_ERROR].dpaa_intf = dpaa_intf; > +#endif > + <...>