From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 993E31B33E for ; Fri, 19 Jan 2018 18:38:05 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF839D7136; Fri, 19 Jan 2018 17:38:04 +0000 (UTC) Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B0AC35D760; Fri, 19 Jan 2018 17:38:03 +0000 (UTC) To: Jonas Pfefferle , dev@dpdk.org Cc: anatoly.burakov@intel.com References: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> From: Maxime Coquelin Message-ID: <8831fc88-0f0d-b89e-5d19-a12983b243cf@redhat.com> Date: Fri, 19 Jan 2018 18:37:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1509465586-7436-1-git-send-email-jpf@zurich.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 19 Jan 2018 17:38:04 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 17:38:06 -0000 On 10/31/2017 04:59 PM, Jonas Pfefferle wrote: > Check and report errors on open/read in noiommu check. > > Signed-off-by: Jonas Pfefferle > --- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 29 +++++++++++++++++++++-------- > 1 file changed, 21 insertions(+), 8 deletions(-) I agree with the fix, Kernels v4.4 and earlier does have vfio, but not the noiommu mode, so the file does not exist. Acked-by: Maxime Coquelin Maxime