From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"Guo, Jia" <jia.guo@intel.com>
Subject: Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs
Date: Mon, 12 Nov 2018 00:12:32 +0100 [thread overview]
Message-ID: <8836207.prvfxQgvAd@xps> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611532E16FB@SHSMSX103.ccr.corp.intel.com>
08/11/2018 18:12, Zhang, Qi Z:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 08/11/2018 12:25, Stojaczyk, Dariusz:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > >
> > > > The devargs of a device can be replaced by a newly allocated one
> > > > when trying to probe again the same device (multi-process or
> > > > multi-ports scenarios). This is breaking some pointer references.
> > > >
> > > > It can be avoided by copying the new content, freeing the new
> > > > devargs, and returning the already inserted pointer.
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > >
> > > Tested-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> >
> > Is it fixing any use case?
>
> Tested-by: Qi Zhang <qi.z.zhang@intel.com>
>
> The patch also fix below scenario
>
> attach net_af_packet,iface=enp50s0f0
> attach net_af_packet,iface=enp50s0f0 (failed as expected)
> detach net_af_packet (failed)
Applied
next prev parent reply other threads:[~2018-11-11 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:21 Thomas Monjalon
2018-11-08 11:25 ` Stojaczyk, Dariusz
2018-11-08 12:26 ` Thomas Monjalon
2018-11-08 12:35 ` Stojaczyk, Dariusz
2018-11-08 12:53 ` Thomas Monjalon
2018-11-08 17:12 ` Zhang, Qi Z
2018-11-11 23:12 ` Thomas Monjalon [this message]
2018-11-08 14:02 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8836207.prvfxQgvAd@xps \
--to=thomas@monjalon.net \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).