From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 868A47CF5 for ; Thu, 19 Apr 2018 16:17:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 07:17:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="33796437" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.50]) ([163.33.230.50]) by fmsmga008.fm.intel.com with ESMTP; 19 Apr 2018 07:17:34 -0700 To: Ferruh Yigit , Zijie Pan , dev@dpdk.org, Beilei Xing , Qi Zhang , Helin Zhang References: <1521193010-25050-1-git-send-email-zijie.pan@6wind.com> <1521630379-9554-1-git-send-email-zijie.pan@6wind.com> Cc: Thomas Monjalon , Wenzhuo Lu , Konstantin Ananyev From: Remy Horton Organization: Intel Shannon Limited Message-ID: <884965cf-aa49-44e2-99b6-ea5f906c0203@intel.com> Date: Thu, 19 Apr 2018 15:17:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/5] get the information and data of EEPROM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 14:17:36 -0000 On 19/04/2018 14:36, Ferruh Yigit wrote: [..] >> Zijie Pan (5): >> ethdev: add access to eeprom >> examples/ethtool: add a new command module-eeprom >> net/ixgbe: add module EEPROM callbacks for ixgbe >> net/e1000: add module EEPROM callbacks for e1000 >> net/i40e: add module EEPROM callbacks for i40e > > This patch is waiting for a while without comment, please share if there is any > concern about patch. Wasn't able to test the e1000/i40e callbacks but that aside the patchset looks good to me. Extend my previous ack to the whole series.