From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7C53A0526; Tue, 21 Jul 2020 22:25:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF56B1C06B; Tue, 21 Jul 2020 22:25:48 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 3B3561C068 for ; Tue, 21 Jul 2020 22:25:47 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8D6BBBA1; Tue, 21 Jul 2020 16:25:45 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 21 Jul 2020 16:25:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JnCjPm8MlytSTj8RbfPv2KJvzVMo/2sReCVdwO8F5zo=; b=CAjuTZCbkX0UBkX7 SUBPSJZ2sMzVt0luge9iQULzZteDoXCoPX3T/mzjwzrXUs1tDyBLVjNSESNS/zPr cLqq96qII91s7jl1aEQdxnqIzBH6lCfxaP7Lj4cqpJSLUDFEn9iJrm9CQfGa8ON+ 2YJLNhQqvxPBti1EyLwmnRBdxKxtL7Kqemcr/qQTSIzqQfYdtVC7n/8f7wmHsGgQ QKGBarGhFy5tHcAHr3QCH42dC00UsKdecTI9Am8ei4wX9Zi0JuUoLXpbHvvV+Gln PXYWNHs+oMCoFrQYKPzDuwl+ooVX+6ocTBtyx1LMB0fN65jWRTUKnYBw8CSUSWBS pKB4VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=JnCjPm8MlytSTj8RbfPv2KJvzVMo/2sReCVdwO8F5 zo=; b=no9WGJNCRm5Pc2weQiZX3GPs5ZO0xm2z03BO2f9bQUYPoDaMycSjsaHrX VZmPjH8ua33uUbPyB6vY8Kbi/aVHgBiNj1sSUoxdNDkM1sV2jW4uBq7d8TjspuOt CdSUD1lDWNGpBs67o2UUAhCHvxEz8RTmjMoJTNPdq+mffsebFWUMDaCay8Prjw00 RtAIizaAW1OxlT1USPrtJXoedfhtVwfxcUVeSJz2qiyEu9OHLHkFPTHmka/DUEJi doGrdtXCqEdPBKV6hjrFXxQBcWOrkRJOdfL+rcU5qcoGBr4yqC8jKRTai0k3kAOB Q3nhyinUZH7RlAUVo7Vz8a5ewOjUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeejgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7E54430600A6; Tue, 21 Jul 2020 16:25:43 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , Robin Jarry , Louise Kilheeney , david.marchand@redhat.com, Bruce Richardson Cc: dev@dpdk.org Date: Tue, 21 Jul 2020 22:25:41 +0200 Message-ID: <88633594.3mM1yyiDgs@thomas> In-Reply-To: <20200717162417.GC719@bricha3-MOBL.ger.corp.intel.com> References: <20200710101055.33671-1-louise.kilheeney@intel.com> <20200717080623.24ba9d1d@hermes.lan> <20200717162417.GC719@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I vote for applying this patch series, because it does not change what we have, except printing a warning in case python3 is neither explicitly called, nor the default. I consider it is a good step, and I don't see the extra warning as a severe annoyance. 17/07/2020 18:24, Bruce Richardson: > On Fri, Jul 17, 2020 at 08:06:23AM -0700, Stephen Hemminger wrote: > > On Fri, 17 Jul 2020 13:42:09 +0100 > > Bruce Richardson wrote: > > > I think we have covered a number of options, but I'm not sure we have > > > converged on an agreed solution. Here are the options I would consider: > > > > > > 0. Do nothing to the code, and just print deprecation notice in docs. This > > > will violate the previously documented plan, but won't break anything for > > > anyone. > > > 1. Just add deprecation notice but leave shebang lines unchanged, meaning > > > lots of people see the notice but don't need to care since they just call > > > the script. > > > 2. As #1, but check if python3 is available and only print deprecation > > > notice if not > > > 3. Add deprecation notice, and change shebang lines to use python3. This > > > means that anyone who does not have python3 installed will see a breaking > > > change > > > 4. Change shebangs to use python3 and detect at "make" build time if > > > python3 is available. If py3 is unavailable, adjust shebang and add > > > deprecation warning on "make install". > > > 5. Use shell-hack above. > > > > > > Any other options I'm missing? > > > > > > For me, I think I can live with all options bar #1. Probably my top > > > preference would be #4 or #2, with #0 and #4 next best thereafter. > > > > > > > 6. Change shebangs to use python3 and don't bother detecting. > > Since distributions will have python3. > > > > This was what our originally patch submission was to do, but it was pointed > out that we said we would have deprecation notices in the scripts in 20.08 > and only remove fully in 20.11 > > > 7. Change shebangs and keep the python2 compat imports > > This is pretty much the same as #3. The python2 compat imports etc. will be > removed in 20.11 anyway, so we can ignore those I think. > > > > > 8. Other alternative I have seen in code is to use > > try block in the import section: > > > > try: > > # for Python2 > > from Tkinter import * > > except ImportError: > > # for Python3 > > from tkinter import * > > > > But supporting python2 for a longer time makes no sense.a > > This is already done in DPDK. All scripts already support both python2 and > python3 AFAIK. If any don't, it's a bug. > > > > > I would go for #0 for 20.08 and full python3 in 20.11 (#3) > > > > Full python3 in 20.11 is indeed the already agreed plan. All python2 > compatibility will be removed then.