From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FF8FA0543; Wed, 12 Oct 2022 17:13:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9079643027; Wed, 12 Oct 2022 17:13:08 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 5EB1142EF7 for ; Wed, 12 Oct 2022 17:13:07 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A9B63320079B; Wed, 12 Oct 2022 11:13:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 12 Oct 2022 11:13:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665587583; x= 1665673983; bh=XRv03TSSq4VvqfWD2ZSiugI/6Go1nNgKvTBnvI3/0cY=; b=e Yj6LuM05u8JoGXplTw6SF239U7ZeEl3kYCHOMaDUs5W2yJxW8dMx7eZoXG7tcOC0 PK7gap16MTdM7oNFwLVn2sQye7mWJbukhraapjDCMv0UCki3uPrSrwAQVnGtKu9h uBSDkIY1CL8J0Dx7wdnaxT4bBDAXmO8vlKsWReL6MTS8qCKDWWMtL4Okm8SWgbcZ 7kTCI6dtjqY89ysLzmeI4Ty37mTCYZObwvlyyEGNYhPiJCgd4nx/p2BwbLs07s0R qTWxRqTYBJxvohtw4VRrVmUZyS8eUpfRrHcFvXt8robgMKFr3DY1kXMeOgomdnRt jayaPNDoaza1gy0hWR1aA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665587583; x= 1665673983; bh=XRv03TSSq4VvqfWD2ZSiugI/6Go1nNgKvTBnvI3/0cY=; b=E 3N4OGFk9ozTpbKZaU2i3+ZtlzQrfSmTCCfVUgYOCzzQOpsXhWKioUoHqt5hVzKBx qx1ONqaS8v0v1xUIjpeTlCJ1AzUG0HH03RQ8mlfXx+sJtjRybrzC9AWUo97uTTcB /EBI2yd45cYODaxY34yqoGkEmwMpsWHaqHDYwrlyXq6D3wkW7/+M+3/UQEVB6E5B qNVlsfZUd4MDtIlCrENaR/xOW186maKsk2Ce0zX2CsHx3FwEHKfz0ckx7IwOij4D RC1fXpWBcUHp0NlwzdDeqoSg5+z2HyliOY4QSA8kmA5u5zmeTttnfWAaKVxoVExB pZ8RmuS8rbO2Tjrd/aOSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejkedgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Oct 2022 11:13:01 -0400 (EDT) From: Thomas Monjalon To: Morten =?ISO-8859-1?Q?Br=F8rup?= , Jerin Jacob , "Van Haaren, Harry" Cc: Jerin Jacob , "dev@dpdk.org" , "Li, WeiyuanX" , Ferruh Yigit , Andrew Rybchenko , david.marchand@redhat.com Subject: Re: rte_event_dev_xstats_reset id type Date: Wed, 12 Oct 2022 17:13:00 +0200 Message-ID: <8864071.MhkbZ0Pkbq@thomas> In-Reply-To: References: <98CBD80474FA8B44BF855DF32C47DC35D873D4@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D873D6@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/10/2022 14:14, Van Haaren, Harry: > From: Morten Br=F8rup > > From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com] > > > From: Jerin Jacob > > > > On Wed, Oct 12, 2022 at 1:40 PM Morten Br=F8rup wrote: > > > > > > > > > > Hi Jerin (eventdev maintainer), > > > > > > > > + harry.van.haaren@intel.com as the changes in drivers/event/sw. > > > > > > Thanks Jerin. > > > > > > > > > > > While looking into bug #1101 [1], I noticed a mix of unsigned int > > > and uint32_t in > > > > the test code, which will fail on 64-bit big endian CPUs. > > > > > > Aha; that we can fix. I am curious why this isn't found in CI/reported > > > before. > >=20 > > We probably don't test any 64-bit *big endian* architectures. Just a gu= ess. >=20 > Seems so yes. >=20 > > > > > Specifically, rte_event_dev_xstats_reset() is called with the "id= s" > > > parameter > > > > pointing to an unsigned int [2], but that parameter is a pointer to > > > an uint32_t. > > > > > > > > > > I think the type of the ids array parameter to > > > rte_event_dev_xstats_reset() should > > > > be changed to unsigned int array, like in the other > > > rte_event_dev_xxx() functions. > > > > > > In this case, we have the option to change the type of a variable in a > > > test-case, or change API and cause API/ABI breakage. > >=20 > > Well.. yes, but I would phrase that last option: Change the API/ABI, so= related > > functions consistently use the same type for the same variable, instead= of randomly > > mixing uint64_t, uint32_t and unsigned int, depending on function. >=20 > Aah ok; I see your point now; there is inconsistent usage of uint32_t/uns= igned int > between the Eventdev APIs itself. Agree this is sub-optimal, and would ha= ve been > nice to have spotted before the Eventdev API was stabilized. >=20 >=20 > > Unfortunately, these functions are not marked experimental, so breaking= API/ABI is > > hard to do. :-( >=20 > Agreed again. 22.11 is a breaking release, and changing type in the API is not much impactful, so that's something you can change now, or be quiet forever :)