From: "Min, JiaqiX" <jiaqix.min@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size
Date: Wed, 30 Oct 2019 06:34:54 +0000 [thread overview]
Message-ID: <88691F3C94B94D4584B3478B96DE5B740B06C61E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191029050705.GE12923@intel.com>
Hi, Xiaolong
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Tuesday, October 29, 2019 1:07 PM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size
>
> On 10/29, Min, JiaqiX wrote:
> >Hi Xiaolong,
> >
> >> -----Original Message-----
> >> From: Ye, Xiaolong
> >> Sent: Monday, October 28, 2019 4:46 PM
> >> To: Min, JiaqiX <jiaqix.min@intel.com>
> >> Cc: dev@dpdk.org; stable@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame
> >> size
> >>
> >> On 10/28, Min JiaqiX wrote:
> >> >Max frame size is not set to HW, so packets above the MTU do not get
> >> >dropped by HW. The patch fixed the issue.
> >> >
> >> >Fixes: ae2bdd0219cb ("net/ice: support MTU setting")
> >>
> >> We should set max frame size to HW in the beginning when the driver
> >> was introduced, so the fix commit should be 50370662b727 ("net/ice:
> >> support device and queue ops")
> >Modify commit message in patch v3.
> >>
> >> Fix this while merging.
> >>
> >> >Cc: stable@dpdk.org
> >> >
> >> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >> >---
> >> >v2:
> >> >* Changed commit message.
> >> >---
> >> > drivers/net/ice/ice_ethdev.c | 4 ++++
> >> > 1 file changed, 4 insertions(+)
> >> >
> >> >diff --git a/drivers/net/ice/ice_ethdev.c
> >> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
> >> >--- a/drivers/net/ice/ice_ethdev.c
> >> >+++ b/drivers/net/ice/ice_ethdev.c
> >> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
> >> >
> >> > pf->adapter_stopped = false;
> >> >
> >> >+ /* Set the max frame size */
> >> >+ ice_aq_set_mac_cfg(hw,
> >> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
> >> >+
> >>
> >> Why set the max frame size to HW in start ops, not in init stage like in i40e?
> >> and what if max_rx_pkt_len hasn't been set?
> >>
> >max_rx_pkt_len need to be set to HW when set mtu , init stage won't be
> called when open port again.
>
> Agree, I think it makes sense to set max frame size to hw in start ops, but
> what if user doesn't set mtu, then the max_rx_pkt_len would be 0, do we
> need a default max frame value in this case?
Agree, we should set a default max frame size value to HW.
>
> And since i40e doesn't update max frame size to HW in start ops, do you
> think it needs a fix?
It can't fix the issue to set max frame size to HW in start ops in i40e, I don't know the cause.
It is ok to set max frame size to HW in link_update ops in i40e,
however when user opens port, link_update ops will be called three times,
so I don't think it makes sense to set max frame size to hw in link_update ops too.
Where to set the maximum frame size to HW in i40e is a problem.
>
> Thanks,
> Xiaolong
>
>
> >
> >Appendix:
> >Steps for using Example/ethtool to set mtu:
> >EthApp>stop 0
> >EthApp>mtu 0 200
> >EthApp>open 0
> >
> >>
> >> Thanks,
> >> Xiaolong
> >>
> >>
> >> > return 0;
> >> >
> >> > /* stop the started queues if failed to start all queues */
> >> >--
> >> >2.17.1
> >> >
> >>
> >> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
> >>
> >> Applied to dpdk-next-net-intel. Thanks.
next prev parent reply other threads:[~2019-10-30 6:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:08 [dpdk-dev] [PATCH] net/ice: set " Min JiaqiX
2019-10-25 3:06 ` Ye Xiaolong
2019-10-25 3:39 ` Min, JiaqiX
2019-10-25 9:43 ` Kevin Traynor
2019-10-28 5:29 ` Ye Xiaolong
2019-10-28 15:54 ` [dpdk-dev] [PATCH v2] net/ice: fix setting " Min JiaqiX
2019-10-28 8:46 ` Ye Xiaolong
2019-10-29 2:05 ` Ye Xiaolong
2019-10-29 3:12 ` Min, JiaqiX
2019-10-29 5:07 ` Ye Xiaolong
2019-10-30 6:34 ` Min, JiaqiX [this message]
2019-10-29 12:54 ` [dpdk-dev] [PATCH v3] " Min JiaqiX
2019-10-30 5:21 ` Ye Xiaolong
2019-10-30 6:40 ` Min, JiaqiX
2019-10-30 10:04 ` [dpdk-dev] [PATCH v4] " Min JiaqiX
2019-11-04 2:56 ` Ye Xiaolong
2019-11-04 7:05 ` Min, JiaqiX
2019-11-04 15:33 ` [dpdk-dev] [PATCH v5] " Min JiaqiX
2019-11-05 2:22 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88691F3C94B94D4584B3478B96DE5B740B06C61E@SHSMSX101.ccr.corp.intel.com \
--to=jiaqix.min@intel.com \
--cc=dev@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).