From: "Min, JiaqiX" <jiaqix.min@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size
Date: Mon, 4 Nov 2019 07:05:59 +0000 [thread overview]
Message-ID: <88691F3C94B94D4584B3478B96DE5B740B06E583@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191104025630.GS11315@intel.com>
Hi, Xiaolong
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, November 4, 2019 10:57 AM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size
>
> On 10/30, Min JiaqiX wrote:
> >Max frame size is not set to HW, so packets above the MTU do not get
> >dropped by HW. The patch fixed the issue.
> >
> >Fixes: 50370662b727 ("net/ice: support device and queue ops")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >
> >---
> >v4:
> >* Removed Reviewed-by
> >* Checked and set defaut max frame size to HW in start ops.
> >v3:
> >* Changed Fixes line.
> >v2:
> >* Changed commit message.
> >---
> > drivers/net/ice/ice_ethdev.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index d74675842..d8aa68f07 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2724,6 +2724,16 @@ ice_dev_start(struct rte_eth_dev *dev)
> >
> > pf->adapter_stopped = false;
> >
> >+ /* Set the max frame size to default value*/
> >+ if (pf->dev_data->dev_conf.rxmode.max_rx_pkt_len == 0) {
> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len =
> >+ RTE_ETHER_MAX_LEN;
>
> I think ICE_FRAME_SIZE_MAX is more suitable here.
Agree. Will be modified in Patch v5.
>
> >+ }
> >+
> >+ /* Set the max frame size to HW*/
> >+ ice_aq_set_mac_cfg(hw,
> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>
> What about
>
> max_frame_size = pf->dev_data-
> >dev_conf.rxmode.max_rx_pkt_len ?
> pf->dev_data->dev_conf.rxmode.max_rx_pkt_len :
> ICE_FRAME_SIZE_MAX;
Agree. Will be modified in Patch v5.
>
> /* Set the max frame size to HW*/
> ice_aq_set_mac_cfg(hw, max_frame_size, NULL);
>
>
> Thanks,
> Xiaolong
> >+
> > return 0;
> >
> > /* stop the started queues if failed to start all queues */
> >--
> >2.17.1
> >
next prev parent reply other threads:[~2019-11-04 7:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:08 [dpdk-dev] [PATCH] net/ice: set " Min JiaqiX
2019-10-25 3:06 ` Ye Xiaolong
2019-10-25 3:39 ` Min, JiaqiX
2019-10-25 9:43 ` Kevin Traynor
2019-10-28 5:29 ` Ye Xiaolong
2019-10-28 15:54 ` [dpdk-dev] [PATCH v2] net/ice: fix setting " Min JiaqiX
2019-10-28 8:46 ` Ye Xiaolong
2019-10-29 2:05 ` Ye Xiaolong
2019-10-29 3:12 ` Min, JiaqiX
2019-10-29 5:07 ` Ye Xiaolong
2019-10-30 6:34 ` Min, JiaqiX
2019-10-29 12:54 ` [dpdk-dev] [PATCH v3] " Min JiaqiX
2019-10-30 5:21 ` Ye Xiaolong
2019-10-30 6:40 ` Min, JiaqiX
2019-10-30 10:04 ` [dpdk-dev] [PATCH v4] " Min JiaqiX
2019-11-04 2:56 ` Ye Xiaolong
2019-11-04 7:05 ` Min, JiaqiX [this message]
2019-11-04 15:33 ` [dpdk-dev] [PATCH v5] " Min JiaqiX
2019-11-05 2:22 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88691F3C94B94D4584B3478B96DE5B740B06E583@SHSMSX101.ccr.corp.intel.com \
--to=jiaqix.min@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).