From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 22C6CA0096 for ; Thu, 6 Jun 2019 10:06:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11BEF1B957; Thu, 6 Jun 2019 10:06:27 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B352E5424 for ; Thu, 6 Jun 2019 10:06:25 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43A4D3082E03; Thu, 6 Jun 2019 08:06:22 +0000 (UTC) Received: from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 226A12E19D; Thu, 6 Jun 2019 08:06:20 +0000 (UTC) To: Stephen Hemminger , dev@dpdk.org Cc: Rami Rosen , Andrew Rybchenko References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605180948.22414-1-stephen@networkplumber.org> <20190605180948.22414-2-stephen@networkplumber.org> From: Maxime Coquelin Message-ID: <888a0bec-995d-a60f-e8ec-2355d1ae9aab@redhat.com> Date: Thu, 6 Jun 2019 10:06:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190605180948.22414-2-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Thu, 06 Jun 2019 08:06:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v4 1/8] net/rte_ether: deinline non-critical functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/5/19 8:09 PM, Stephen Hemminger wrote: > Formatting Ethernet address and getting a random value are > not in critical path so they should not be inlined. > > Signed-off-by: Stephen Hemminger > Acked-by: Rami Rosen > Reviewed-by: Andrew Rybchenko > --- > lib/librte_net/Makefile | 1 + > lib/librte_net/meson.build | 2 +- > lib/librte_net/rte_ether.c | 29 +++++++++++++++++++++++++++++ > lib/librte_net/rte_ether.h | 25 ++++--------------------- > lib/librte_net/rte_net_version.map | 7 +++++++ > 5 files changed, 42 insertions(+), 22 deletions(-) > create mode 100644 lib/librte_net/rte_ether.c > Reviewed-by: Maxime Coquelin