From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5FA4CFFA for ; Tue, 12 Sep 2017 20:28:27 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 11:28:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,383,1500966000"; d="scan'208";a="150522844" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga005.fm.intel.com with ESMTP; 12 Sep 2017 11:28:25 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Ivan Malov References: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com> <1504880151-15394-2-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <888cc02a-07f9-204a-c59a-8bd35431e49b@intel.com> Date: Tue, 12 Sep 2017 19:28:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504880151-15394-2-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/sfc: free mbufs in bulks on simple EF10 Tx datapath reap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 18:28:27 -0000 On 9/8/2017 3:15 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > --- > doc/guides/nics/sfc_efx.rst | 4 +++- > drivers/net/sfc/sfc_dp_tx.h | 2 ++ > drivers/net/sfc/sfc_ef10_tx.c | 15 ++++++++++++++- > drivers/net/sfc/sfc_ethdev.c | 6 ++++++ > drivers/net/sfc/sfc_tx.c | 17 +++++++++++++++++ > 5 files changed, 42 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst > index 973a4a0..028b980 100644 > --- a/doc/guides/nics/sfc_efx.rst > +++ b/doc/guides/nics/sfc_efx.rst > @@ -245,12 +245,14 @@ boolean parameters value. > features available and required by the datapath implementation. > **efx** chooses libefx-based datapath which supports VLAN insertion > (full-feature firmware variant only), TSO and multi-segment mbufs. > + Mbuf segments may come from different mempools, and mbuf reference > + counters are treated responsibly. This is also the case for ef10 native, right? Does it make sense to document it in below too? > **ef10** chooses EF10 (SFN7xxx, SFN8xxx) native datapath which is > more efficient than libefx-based but has no VLAN insertion and TSO > support yet. > **ef10_simple** chooses EF10 (SFN7xxx, SFN8xxx) native datapath which > is even more faster then **ef10** but does not support multi-segment > - mbufs. > + mbufs, disallows multiple mempools and neglects mbuf reference counters. > > - ``perf_profile`` [auto|throughput|low-latency] (default **throughput**) > <...> > --- a/drivers/net/sfc/sfc_ef10_tx.c > +++ b/drivers/net/sfc/sfc_ef10_tx.c > @@ -401,14 +401,25 @@ struct sfc_ef10_txq { > pending += sfc_ef10_tx_process_events(txq); > > if (pending != completed) { > + struct rte_mbuf *bulk[SFC_TX_REAP_BULK_SIZE]; > + unsigned int nb = 0; > + > do { > struct sfc_ef10_tx_sw_desc *txd; > > txd = &txq->sw_ring[completed & ptr_mask]; > > - rte_pktmbuf_free_seg(txd->mbuf); > + if (nb == RTE_DIM(bulk)) { > + rte_mempool_put_bulk(bulk[0]->pool, > + (void *)bulk, nb); same warning here, again false positive I think: error #3656: variable "bulk" may be used before its value is set The patch to ignore the warning will take care of this one too. > + nb = 0; > + } > + > + bulk[nb++] = txd->mbuf; > } while (++completed != pending); > > + rte_mempool_put_bulk(bulk[0]->pool, (void *)bulk, nb); > + > txq->completed = completed; > } <...>