From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DCB7423FB; Tue, 17 Jan 2023 11:49:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70ABC40A84; Tue, 17 Jan 2023 11:49:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 06F0342D0B for ; Tue, 17 Jan 2023 11:49:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673952592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PoCWWALZ2Ps7EXpPzksVDyw3dlh0ryAWYnzBexZPY6o=; b=a557yaAhzbPJhD2yEv7uZAVK1Lwwq3DZLwEZ20xmJRfodvARHiJb71xgLPCZVFc5Rg28on 325Ltjx7Bddm8zxWrV4ZPslw2c/yUG3SobMG7MeAg7xOitQSJwVnZxP5i+2OorWZBycQSl QHz54A02Vay20VeubkbGxeyrZBk62hY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-SJykHL3PO_a7__oBXMHvMg-1; Tue, 17 Jan 2023 05:49:51 -0500 X-MC-Unique: SJykHL3PO_a7__oBXMHvMg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DF3E5802D1B; Tue, 17 Jan 2023 10:49:50 +0000 (UTC) Received: from [10.39.208.23] (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9936540C6EC4; Tue, 17 Jan 2023 10:49:49 +0000 (UTC) Message-ID: <88984c1c-0bfb-6d38-5ae3-67e001ca0749@redhat.com> Date: Tue, 17 Jan 2023 11:49:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 3/7] baseband/acc: acc100 fix multiplexing multiple ops To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230112193609.273578-1-hernan.vargas@intel.com> <20230112193609.273578-4-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230112193609.273578-4-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/12/23 20:36, Hernan Vargas wrote: > Function to check if multiplexing is possible for multiple operations in > one descriptor returns number of enqueued ops. > > Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index a00314c957..eb18cc2215 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -3421,9 +3421,9 @@ acc100_enqueue_ldpc_enc_cb(struct rte_bbdev_queue_data *q_data, > } > avail--; > enq = RTE_MIN(left, ACC_MUX_5GDL_DESC); > - if (check_mux(&ops[i], enq)) { > - ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i], > - desc_idx, enq); > + enq = check_mux(&ops[i], enq); > + if (enq > 1) { > + ret = enqueue_ldpc_enc_n_op_cb(q, &ops[i], desc_idx, enq); > if (ret < 0) { > acc_enqueue_invalid(q_data); > break; Reviewed-by: Maxime Coquelin Thanks, Maxime