From: "Wiles, Keith" <keith.wiles@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pascal Mazon <pascal.mazon@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] net/tap: fix isolation mode toggling
Date: Mon, 14 May 2018 22:46:18 +0000 [thread overview]
Message-ID: <88FE23C0-E7DB-4BB8-844B-4E77EC4D809F@intel.com> (raw)
In-Reply-To: <1526336787-28457-1-git-send-email-ophirmu@mellanox.com>
> On May 14, 2018, at 5:26 PM, Ophir Munk <ophirmu@mellanox.com> wrote:
>
> Running testpmd command "flow isolae <port> 0" (i.e. disabling flow
> isolation) followed by command "flow isolate <port> 1" (i.e. enabling
> flow isolation) may result in a TAP error:
> PMD: Kernel refused TC filter rule creation (17): File exists
>
> Root cause analysis: when disabling flow isolation we keep the local
> rule to redirect packets on TX (TAP_REMOTE_TX index) while we add it
> again when enabling flow isolation. As a result this rule is added
> two times in a row which results in "File exists" error.
> The fix is to identify the "File exists" error and silently ignore it.
>
> Another issue occurs when enabling isolation mode several times in a
> row in which case the same tc rules are added consecutively and
> rte_flow structs are added to a linked list before removing the
> previous rte_flow structs.
> The fix is to act upon isolation mode command only when there is a
> change from "0" to "1" (or vice versa).
>
> Fixes: f503d2694825 ("net/tap: support flow API isolated mode")
> Cc: stable@dpdk.org
>
> Reviewed-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> —
Acked by: Keith Wiles<keith.wile@intel.com>
Regards,
Keith
next prev parent reply other threads:[~2018-05-14 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 8:36 [dpdk-dev] [PATCH v1] " Ophir Munk
2018-05-14 12:32 ` Wiles, Keith
2018-05-14 22:20 ` Ophir Munk
2018-05-14 22:28 ` Wiles, Keith
2018-05-14 22:11 ` [dpdk-dev] [PATCH v2] " Ophir Munk
2018-05-14 22:18 ` Wiles, Keith
2018-05-14 22:19 ` Ophir Munk
2018-05-14 22:26 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2018-05-14 22:46 ` Wiles, Keith [this message]
2018-05-17 14:13 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88FE23C0-E7DB-4BB8-844B-4E77EC4D809F@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).