From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E3E943ACE; Fri, 9 Feb 2024 19:07:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B80934067A; Fri, 9 Feb 2024 19:07:10 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id AB883402AF for ; Fri, 9 Feb 2024 19:07:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S2yc+6BmHrDBiQQh1tWkLitnHSAvv0LjIidtPUHM6sQv3FFrEm8ifT8dCK4Ls99Nt2hZM9ZoaQoScrNd6k9wg1vljafnfyAsFzt2umiTNUTqSA2EIivqWlAhoP7HnRYFIs0Cogsh1XJzWOBUY+a/aejB9u1zXCvDf396+h/sP2TAXzqxa9KzpxbuI+qyrfDCYc8T9LINmvA6XlgC9Q8uF10IwK1o71J2/fHrKlU3DfdzxBCoJs76Zg+APMNcnj2CaPsjFN8bVhu/yuXi4gG9Cb6dHgkYUlxNRn55HDE1bXkzE2rQudFAzQYJe6gzG16nL8C27p9+gPaVkJ8C6XFixQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=is3YuyYXb97QziK6CSnpB6vGqyD8LizvS/pFOS7YZmA=; b=J+425i3u22Ds2KY+LEqLmkoYIqKr8MGb87/qNqmuUoe45HZMzfjxYp7KPqF4kE+9v6W1ezZ+3CtZHly1WfOjD2Sfa6wi/kyXNGN/7PCbGPawS3Z3J86oFXqvbigTWtqnkaLPEvuqHn77r9w+KI4r6EwoFNJDLB96ZnOoCXjBR97uLiobZTG67mQLtugmiQ7fvT2nEc4kdD2zP1YBzwy6MpS+85lyGc2XeaOPJTP4E4fTelJK/whxidlILZIEIiNYwksPgYSwSvYk/15YNbZ9BLMXgO4ruIF5iS2ESsY3klOprkBxBPqXqYNv76l/cmRprW6pDAV+eUPVfKhlrQDYcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=is3YuyYXb97QziK6CSnpB6vGqyD8LizvS/pFOS7YZmA=; b=DcdE91JMOKiTiTLNeuaZqVK6PyZvULV6KE4+CRo2tf7eVzpCQ8CH0jQQEVrhtfBF+0aF8UuLuvi5n6IQmVc5nktlEBmW2gtCghB7cUS8YPm5rJD8vtlqdAsMLSOBd84Ul8kcMgdIaWF7nzLAbZqoX7s2L/0d54RGsTm0G/sNgHU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ1PR12MB6313.namprd12.prod.outlook.com (2603:10b6:a03:458::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.11; Fri, 9 Feb 2024 18:07:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7292.009; Fri, 9 Feb 2024 18:07:06 +0000 Message-ID: <88afb4d7-4a2b-4cd0-bb9b-2e565354fa23@amd.com> Date: Fri, 9 Feb 2024 18:07:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s Content-Language: en-US To: Maryam Tahhan , "Loftus, Ciara" , "stephen@networkplumber.org" , "lihuisong@huawei.com" , "fengchengwen@huawei.com" , "liuyonglong@huawei.com" , "Marchand, David" Cc: "dev@dpdk.org" , "Koikkara Reeny, Shibin" , Kevin Traynor , Luca Boccassi References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> <8a667d69-8543-4dd0-bc90-9929b670a261@amd.com> <37ebae5b-cfb0-48f9-bafb-855e59b6bdc9@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0156.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::24) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ1PR12MB6313:EE_ X-MS-Office365-Filtering-Correlation-Id: 060c5dc5-2691-4049-860f-08dc2999ed19 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iGgApRwDDgIYhWhWAkjiBkJtkZcSO06Yz5N+o5y1OtEBwWehCUyQ8J+DEqhJMZB3nMUM4Tsz60S+wnioVU+N9T51otKDQGudGI44Gn/zkt+kqdFN9zGqhQYFZ4Z9IaiopWGL2XdJQ5zHxAIHxrauTZD2E/kqWPV9vzeOE8HehU2/5f5BqSHjzhP/Gsbr2aRWQxmu2o6DIPVUJVQXQtsADhEHrjDUE+SpqQJr4YZB6wP5ZrHGWePE8lbjNVjW2tb3qh5xIEzpOlVgzJxitBKJUGg2wJxPBK6Ljo5X3GPE0yxuaHrvj+zApfpgddxD20s14U8JChlu76goR6HSj7RcYfnVuuchlm/ZBwpGz11IJh+8RAjwDzLFnlrDJKqNZlT3opcBRsNmnT01dbLbIOco2ycTnWsBmvzovok7njR1vcXi9noTbljdcKECeCsa1Pr628e5/DDiS8t1oKbaY9OV5m7MVTxVAyt4exwsberzLN+WGMnfN5+Xxs3KJi9cLdhjtiD07qQd5/9aJgmwI9xTRhafl9fdP4rN0sBQr355QH800PTwOHHzPnZ1ticRdVFb X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(396003)(136003)(346002)(366004)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(478600001)(6486002)(31686004)(41300700001)(6506007)(54906003)(7416002)(2906002)(5660300002)(44832011)(316002)(110136005)(36756003)(66476007)(53546011)(6666004)(66556008)(8676002)(8936002)(4326008)(26005)(2616005)(6512007)(86362001)(66946007)(31696002)(38100700002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHRCYStpaW84cTNQK3R1WVpNQ1YrRGVNdmd4bE81UlIwYnVINzY5SW54WWUy?= =?utf-8?B?cEpPY1V5aHFnZFJMQ3ZHbXM2U0Z6aDRDWE1QdTJMUUxtSzIxNXhLRVh6djQv?= =?utf-8?B?TkxtbU9BNEVIQUl5M2Y3UlNzY2NjNTA4d1g1dmNBKzVUZTdiVUdvNjRvWUM3?= =?utf-8?B?YmszNVR4OEFLZXNXdUh4dHlrS3RJM2FqVkl3cVdjYW1wRmhGWUtWOXFQR1E5?= =?utf-8?B?blp1MDNvYzdMek4rUWVLL1huS29CL3FiUWN2c290RndUVWRzZFNtd0cwTHUv?= =?utf-8?B?ZTJDa0FWeGxJZTRuU0VPeW0xMjJWdkNGMEJxWFlCeWlXaUM5dkhWcXllZWFM?= =?utf-8?B?anZjNisrVFBoaXkzcUlBREV2Y3lxT2k1SWxBMzZiMVJxVm1MbUZnOEpZY3J5?= =?utf-8?B?ZFM3TFVWNlV0ZlIzYmUwOElyUWd3MWZJMzhmd1I1UjhxNnZNZG8wZFZLVFRl?= =?utf-8?B?Yk5tUWZEbGFIS3ZNNk9YcXBBMG1xZDVVNzR1ckVBUlhHYkdYVjloaExETnMz?= =?utf-8?B?TFl6MFRhaFNkRWd1bnNsRmhDZmZNY1Y0NkM5M3o3b1hYVFhITVgzY1NwRGdC?= =?utf-8?B?R0wzdTZsTFpjNmJ5RzdabTlnVHlnSzFOSFhOK3kwNVNNMFFJbXUvK3JISzFY?= =?utf-8?B?bCtmcmp6SDdYc00xc3ZBKzBDTkdmamdvL2VnaEZvbXVKQzZrNHhhZjh6U1BO?= =?utf-8?B?ZTkwclNSbk44SWtCK0d4SmxiamNjOHpwRGN6NWlYa2RWbkF2TUNiWWVkV3VN?= =?utf-8?B?VS8yZGxybEFqVVkyM1Fvb0N1QkJHU2VEWnQvcU00QWRkRUozM2ZWalRkZzNW?= =?utf-8?B?KzVVTEcyOUZneUo1YytMUWVBQVFMOTNzbW11YnR5ZFgvZTQ1Q25NSS9sajho?= =?utf-8?B?a1g2Kyt6NHZnbTR6VHF0eE93VjNBUnkwNFBQaTBCQjR6d1FXNHhGUmE2b3dF?= =?utf-8?B?Z2cvMjF4ZDAydzRsSklqbTBJTXdWVllTdTZQOVl1SE15SEVJMDFMd25KRFJO?= =?utf-8?B?TWhhd1J4Wi8xTzFFMEN3OWFJM2Jvay9nUVFjZXJ6czlURjlDV2lMaVdSVkdM?= =?utf-8?B?U3RFMnlNWmcxZEZPZ3NsNmcrZHdLZUExYWViNFkyU2ZJTEtuSmVKL05JUVdG?= =?utf-8?B?dmtQMjcyWElydG5WS2hpelNUMlhrMWtOVjZVMkxXUEdDNVNwUzVmZ3RyRUUw?= =?utf-8?B?Y0R0SDVlSWllVjJwVG1wc0JjMis1VWVLNnRpTklVVWFxZnBCOXBSYTFlOWNx?= =?utf-8?B?TVlXSlU4RGdHWldyVmlON0lHSHRDRDVqekdTVWd0M2l5ZVR6Z2QyaWJnRm1l?= =?utf-8?B?aFd6M0g2bG1hNHlWV3FwV1JOdzdrL3kvUTIvdlJQQ1B1TmlySGJVQzVZMnIy?= =?utf-8?B?WkFxNitlRlpUTjFEaUM2ODZubmkyaWhDZmFFYVc5WS9KSGxLM1g3eE5nZWpl?= =?utf-8?B?a0Y5MmZZbmVaK2oyZE40LzZubDdJQ2JZYkVEcEQ0aFFYb0tod3greTRmTmZU?= =?utf-8?B?UmhPekpRcm1kaURpKy9OSDk3ajlzYWc3cUErUnRXYnk4eWFaU2ZBWmxSLzYv?= =?utf-8?B?dDJib1RGZGpadG9JcVdvQnMzQnJ4YXVuRVJhdUtuS0d2M0dHRktaY0xPbUsy?= =?utf-8?B?Um1ydXhNd0ZDcGM3WlVaenJGZ2VTaFMzUTEzRm1jbUV4NlZqOThYRzNjMnNV?= =?utf-8?B?aytaZUROazkzd3dtUXRRaFJNS0RnMmZ1cTkxT3paT2JuVjIyNyt5SERPRXA5?= =?utf-8?B?enJTODE2N3o2T0FIcm1ubkVxNklteHZwTVdKenI4NStqWUZtdnFkdXB1UndG?= =?utf-8?B?Qjl6MlVzYmZsRWZpRDRLVFFTbTdKazdReER1Wm5HTElEQkszRk9UbENNYWtG?= =?utf-8?B?aklzdms1K2hEL3M1S0JDaE1nK3hBVHUrOU9hQ3lyK2ZLTEhVL092SHZhNnFz?= =?utf-8?B?K21hVlgycklxVC9OQjE5Wmt6aCs4eW5FS0VwS3JtOEM2QnVMY3AvdmpSNWZJ?= =?utf-8?B?ZG1CbmN2c2dEWFd5NmxQM3U0MHh1VUZWQmlCbFl5WDlvNjh3WmxKNGp5b0Va?= =?utf-8?B?dkR2azVGZWxndHB6L2NlWTMzVitsd1QrSXJrN29jOVY4Uno0ZTJsRmcrZ3No?= =?utf-8?Q?Q9SDvdT+oSPbyzYGCXbTZYKYw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 060c5dc5-2691-4049-860f-08dc2999ed19 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2024 18:07:06.6451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GL6OF2gtocEm6wHFY4YT2kXcqJBUsHpqzzNLq55Jh7tI6chm4un6y3y9N2WVCHv6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6313 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2024 4:52 PM, Maryam Tahhan wrote: > On 09/02/2024 12:40, Loftus, Ciara wrote: >>> Hi Maryam, >>> >>> How do you want to continue with the patch, I think options we considered: >>> >>> 1. Fix 'use_cni' documentation (which we can backport to LTS) and >>> overload the argument for new purpose. This will enable new feature by >>> keeping backward compatibility. And requires new version of this patch. >>> >>> 2. If the 'use_cni' is completely broken in the 23.11 LTS, which means >>> there is no user or backward compatibility to worry about, we can merge >>> this patch and backport it to LTS. >>> >>> 3. Don't backport this fix to LTS, merge only to current release, which >>> means your new feature won't be available to some users as long as a few >>> years. >>> >>> >>> (1.) is most user friendly, but if 'use_cni' already broken in LTS we >>> can go with option (2.). What do you think? >>> >>> >>> >>> btw, @Ciara, @Maryam, if (2.) is true, how we end up having a feature >>> ('use_cni' dev_args) completely broken in an LTS release? >> My understanding is that the use_cni implementation that is available in the 23.11 LTS is compatible with a particular version of the afxdp-plugins-for-kubernetes source. Maryam's change makes it compatible with the latest version. @Maryam can you confirm this? >> If my understanding is correct then I think we should include the version/tag/commit-id of afxdp-plugins-for-kubernetes that the code is compatible with. Including backporting a patch to LTS to specify what version that code is comaptible with. > > > Yeah that's correct, the existing use_cni implementation would work with > a particular version of the AF_XDP Device Plugin (with the limitation > that the DPDK pod cannot request multiple interfaces from different > device pools). From a deployment POV - I would consider this a broken > behaviour. Non the less we can document it more explicitly. > Thanks for the clarifications. If feature in LTS works with a particular version of the AF_XDP Device Plugin (the version it is developed against), with its designed feature set, I wouldn't call that feature is broken. Technically an LTS user can be using the feature with that specific version of the AF_XDP Device Plugin, in that case I agree approach (1.) that keeps backward compatibility is better. > The use_cni changes I'm making now will enable multi interface support > (for a DPDK pod, keeping backward compatibility in mind). It will also > still work with the older version of the AF_XDP device plugin (with the > 1 interface limitation for the DPDK pod). I will document all of these > in the next revision.  > > In addition to the changes mentioned above, I'm also extending the > AF_XDP PMD to support retrieving the xskmap FD from a pinned BPF map (A > new feature in the AF_XDP Device Plugin). > > All the above will be pushed in another revision of the patchset shortly > (in addition to documentation changes). I'm just running tests and > breaking down the patches into (hopefully) logical chunks. > > And lastly there's one other issue that I'm trying to also > investigate/resolve - which is the AF_XDP Device Plugin integration > under AF_XDP PMD doesn't support busy polling. That's probably another > feature to add. >>> this might be a separate patch >