From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id AA722A04B7;
Mon, 21 Sep 2020 04:06:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 5AA9D1D17C;
Mon, 21 Sep 2020 04:06:42 +0200 (CEST)
Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32])
by dpdk.org (Postfix) with ESMTP id C83A91C127
for <dev@dpdk.org>; Mon, 21 Sep 2020 04:06:40 +0200 (CEST)
Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59])
by Forcepoint Email with ESMTP id 6DBAB5C79F222D5D6E0B;
Mon, 21 Sep 2020 10:06:39 +0800 (CST)
Received: from [127.0.0.1] (10.65.81.238) by DGGEMS406-HUB.china.huawei.com
(10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Mon, 21 Sep 2020
10:06:30 +0800
To: Stephen Hemminger <stephen@networkplumber.org>, <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>
References: <1592483709-7076-1-git-send-email-tangchengchang@huawei.com>
<1599296854-56620-1-git-send-email-tangchengchang@huawei.com>
<1599296854-56620-4-git-send-email-tangchengchang@huawei.com>
<20200905095859.743243bb@hermes.lan>
<975a84de-1455-737d-25a0-cc5f37cf31d8@huawei.com>
<20200918151117.59037ea6@hermes.lan>
CC: <dev@dpdk.org>, <linuxarm@huawei.com>
From: Chengchang Tang <tangchengchang@huawei.com>
Message-ID: <88b4cc70-5e8a-b3b8-82eb-3e8a97279fff@huawei.com>
Date: Mon, 21 Sep 2020 10:06:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <20200918151117.59037ea6@hermes.lan>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.65.81.238]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to
--show-port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi, All
These Patches improved procinfo was stuck in patchwork:
https://patchwork.dpdk.org/patch/74960/
These patches look good for me. Will these be applied?
I'm not sure what to do next. If these will be applied, I need modified
the code.
On 2020/9/19 6:11, Stephen Hemminger wrote:
> On Mon, 7 Sep 2020 17:14:48 +0800
> Chengchang Tang <tangchengchang@huawei.com> wrote:
>
>> On 2020/9/6 0:59, Stephen Hemminger wrote:
>>> On Sat, 5 Sep 2020 17:07:32 +0800
>>> Chengchang Tang <tangchengchang@huawei.com> wrote:
>>>
>>>> printf("\t -- queue %d rx scatter %d"
>>>> " descriptors %d"
>>>> + " rx buffer size %d"
>>>> " offloads 0x%"PRIx64
>>>> " mempool socket %d\n",
>>>> j,
>>>> queue_info.scattered_rx,
>>>> queue_info.nb_desc,
>>>> + queue_info.rx_buf_size,
>>>> queue_info.conf.offloads,
>>>> queue_info.mp->socket_id);
>>>> }
>>>
>>> These should be using %u and need space after " for PRIx64
>>> Why not:
>>> printf("\t -- queue %u rx scatter %u"
>>> " descriptors %u"
>>> " rx buffer size %u"
>>> " offloads %#" PRIx64
>>> " mempool socket %d\n",
>>>
>>
>> OK, I will fix these in next version.
>>
>> Thanks
>
> NAK, these is superseded by.
>
> Please look at the new improved procinfo still stuck in patchwork
> https://patchwork.dpdk.org/patch/74960/
>
> Let's put the buffer size there.
>
> .
>