From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF1D9A0547; Tue, 26 Oct 2021 22:31:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E022440E0F; Tue, 26 Oct 2021 22:31:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 20663407FF for ; Tue, 26 Oct 2021 22:31:13 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="316212708" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="316212708" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 13:30:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="724299003" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga005.fm.intel.com with ESMTP; 26 Oct 2021 13:30:55 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 13:30:55 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 13:30:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 13:30:54 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 13:30:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etjt6laPPuCJWhEAYlB+RIAaWmYIeROV8XB0lylMbcxoTFTzfxj0ShjSxHUn7jS8Z3etLaMOCumlhS7jV/vLaUDnUSnX6ydwM33YtgDzSae6ruXN4i71kdhpV4Rtw5wibmRypBV3XCG0RzsR0237K7+/YXGWGRV6R9YK5uV6whdHydXwlSFLhXUt1RUJNoQ+Q14v2DEj1OPf9p7MCFH3AP5XAbZltUhd+FoMZwct0kdhsfEt0//AjN/D0wqnIoJ+XcQ37/fqD56Eqt0aWmxQA/4cfq67/wel2r+C1vQpZknYd33WITSRrbyfoPRFfsVgjFwd5AyScJlKTMjLMmrkqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqIUcJ6mWTeM5EuLBXAW3gwqTTNYkdqPKGlt3FMhNog=; b=Yng3DQjToifh8rqhnuMnjgspS4br7mFCAzCcrQCFvcC2mdVbe1RgSXqloSbbSfBzMJNVHaTjSRQVG6Z55tC09Hq5qZfXPRvrMPs8bq03bRZojWPnPyr06/oANVuE6UZ2UDWHGInzvXNaHODO2TZ/HYi4qOEijKWNzy7na9H632R9PBujgtQW3oOEqWm0+ktANzE1xU+kHVUbUl/zoiO3bou7fhiEcC/UAA9Y6MUc9NH3wRw5tbQbYys1yqK+TpamcpsqFr63v9q4/dY3w7hEHlxQkY5jcchdnn9/HN9/wQc1dAul0XYb61/IGvjTp5gvL2PoI2a3O7Qxs3GR29uiqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqIUcJ6mWTeM5EuLBXAW3gwqTTNYkdqPKGlt3FMhNog=; b=SCiW+YuDSur/LEqrsxdUOrSpiC0p2jq4BvPp7zGQI6y7ruyAvUEAREM6iLgiWenKoDMbeh2I4UOlb2fXplnCp2HxY0449B/ecN0et2w69jmBeou1ubDwmbaoWF2ZlcpIGtoRr0fVQJiiBI2UEbzQ1j/zq+MWDi/EKlVuxH27fA8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5020.namprd11.prod.outlook.com (2603:10b6:806:11f::16) by SN6PR11MB3054.namprd11.prod.outlook.com (2603:10b6:805:ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Tue, 26 Oct 2021 20:30:47 +0000 Received: from SA2PR11MB5020.namprd11.prod.outlook.com ([fe80::e54d:4547:c437:dfe]) by SA2PR11MB5020.namprd11.prod.outlook.com ([fe80::e54d:4547:c437:dfe%7]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 20:30:47 +0000 To: Thomas Monjalon CC: , , References: <1630943759-362969-1-git-send-email-vladimir.medvedkin@intel.com> <8937505.KMVrHqqNeC@thomas> From: "Medvedkin, Vladimir" Message-ID: <88c45098-747c-6267-049c-5569b8cf5e96@intel.com> Date: Tue, 26 Oct 2021 22:30:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <8937505.KMVrHqqNeC@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR07CA0200.eurprd07.prod.outlook.com (2603:10a6:6:42::30) To SA2PR11MB5020.namprd11.prod.outlook.com (2603:10b6:806:11f::16) MIME-Version: 1.0 Received: from [192.55.54.51] (192.55.54.51) by DB6PR07CA0200.eurprd07.prod.outlook.com (2603:10a6:6:42::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.11 via Frontend Transport; Tue, 26 Oct 2021 20:30:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37e9f044-0c84-40ce-c39f-08d998bf7e35 X-MS-TrafficTypeDiagnostic: SN6PR11MB3054: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0ZMvMni+SVn3NJs18yO6HVqf7hl9pHRKcO00QQzcBGcH9Zn1adyZF8IAB1QNQXpQX1hIwO/zz7bQKpL12dv6m2oXr5nxWc8axjvcfRS19J/TLGgcfTWsMqcnXJkieMYcqQPmzYRrzoGsS3OHPjrCRBs2yskFLWCsJUlyUzVBBXGEJTJb/W43lT4HCclF2ZZx5nSrtn3KLn97zo7LXstiIFNEdYA+klA3O+vrm3o4Bp8rB/w+Qw+aPYifR+iCwH16DVfhQHcG2bV+UY1K6uerD5tntVCibVNE4i/sZ0nRm4/euZNk4w2lLb+NgnN3GGa+pDewLPhVqdz028PubiK29lKtFMGx084kFxqdS8QCMhqNI3Yej7qsKWqA009PCF/4fEvjoh2s4DOigcj4dLZqc62nIkWzyt6TGsWwR/4b1SsEs7aH6UXIohtG1W/tiaRNg2QklgGHViTF6KdzSc8u7SKpirJyiP2BtsnQTvbJtFljmZUaDx4mW1UykgJcE9X14dGTzPA3HHDIGQHVAvPKoCfiM0rEMlJnIGuHLtYeqgiYIqRNGa2bhXPkf9Jbuj3VJcgKwYcYpe32h13MiK0/qhNztj45GV1KGtHR3vaSTZkIl5YgCA2FtYvEebGwqOG32XmVJtBIc0cCr0dgm1jYK9o5FIIiVE7Z2oe1tbA5OD3azIQ3RZwyobDWouk6OIxwKNN45jZLkVokQ9wcAd8VKQn9YhjsA1DWeaMhPhiWshq4pGB9G2ACmyxSXZdhwtZyQLEHXLnvEMHlOiGXEmDqiZV3kOf3ZaVoT7nsBFBSuHFY4LjzagRSmeo3RovAU0Tzae0vzZ0lM31my5Nm74Ky76JJyxzDwAlfbIS52BHONtA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5020.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(107886003)(8676002)(6486002)(8936002)(66476007)(6916009)(6706004)(66946007)(66556008)(31696002)(6666004)(966005)(86362001)(38100700002)(31686004)(508600001)(2616005)(956004)(4326008)(53546011)(16576012)(186003)(2906002)(316002)(5660300002)(26005)(82960400001)(83380400001)(36756003)(3940600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEx4aUp6aE5BelY3eGdZcDB6TE8zQTZ3MUdWcEF3WDV3MWNMZ0UweU5wRVZC?= =?utf-8?B?RGJybnY4bDNTcnVrekpMZFcrY3RUZmJZVHE2TUduNkdidXo1d3RQRTFwclFE?= =?utf-8?B?RzR6ZCtrNmptWGlOQjhDckhIT01YRkR6cmxSNjZVSFQ2SXZKcktQNGRPWHJz?= =?utf-8?B?MXZoN1Jld2tEYlZNZlA1U0ZTaG9XaVk1c29SVmpzSUdBRTlFZU84RDhQN2RU?= =?utf-8?B?ejU4MnpSUk8xa2NiTGdIU1lxSHZLSkxiYnppKzQ0Y0I4MTQ1QWhyeFlIdmJl?= =?utf-8?B?STJZNGRtYWRNSFBCNWFPMGwrUGdDWFVOMHpLZ0NDNllRc3F4WjkvU2R3Q3BJ?= =?utf-8?B?dXNwWE1GbzlsYnR3elVKcHllTUcxckpIY1hiTGUwVTFSd3FWck9VK0M0enE4?= =?utf-8?B?MzUzTk1QK0FBTS9aSEhrSHZVK3F1U09UT2FMaWVOZWc0UmhReU1HODJ0U3hG?= =?utf-8?B?VGhIU0oxQzZIU1BURGNsREdRZklTL3MrVmJ6QmkzQnlHeFEvOSsyeW1PTk01?= =?utf-8?B?ZDJCV0lBNlFWak9BakQ2STV5ekRrZ3JnWlIraVlBSG9CR0NDcStNZTFCY2RJ?= =?utf-8?B?amdvSUkzdkIxaGNkVHZoeGpvbDUzTEZWWnU3eFVwekg0QnI3S1hHejFtSmRp?= =?utf-8?B?L0JQNXBMd0RpOUpQbDRzcXZRNE1sRVBia2VxUEFIVnZyUXBZQ3ZCdzJlUjV1?= =?utf-8?B?VzJXbDRnbXc5MldmMXhqTk9ldDkyaTMrVWxwYnVJZlUreDB6bnErbjJpRllt?= =?utf-8?B?cDQ0ckxLaW15bzN3bGRqN2lSVTNUUmpLbVlrSnZZcE55TGVvZHRHeWw3Q3lx?= =?utf-8?B?YlFxY1dxMlJJT1ZiZzgrSytHSlUvUnJOdWU2T3k2N2xhMGowYUEvQnpWOWhw?= =?utf-8?B?ZjE5dVRVQXFWaUdaZmRNb25GQlQ5cU9GaVlpWE0ydmxmKzFGdmxTWDRSdXli?= =?utf-8?B?a3FuNGpGVUZnd3Nvc1BxNTQ0SUxOakVnck5ROU5mWTQzbzJOYU9pRFZFV3hB?= =?utf-8?B?dWVnUWZOK3V3VGlHaTk4dkZmRHB6bThBcUE0b1gyTFF6WUpad0FGaUZya0pH?= =?utf-8?B?bVpwUC9zbmpaTzY5ZzBiek5IRnNmMElMNFVDK0cxVUZCUHB5WXJ1ZUNmekl3?= =?utf-8?B?NVVrV1o2OGdKVWY2VzhsdCtBckxCZjllaGF1NlorakZDRU5KZGIxVUt3TE1B?= =?utf-8?B?NEhjWnYyWnBTcmE4cFBXSmh5Mk9yQ1lUNnhnbHA4SFdjRW83TWk3Zk5WQ1A0?= =?utf-8?B?SU5LbUF6ajRWOFdSMy94TDRBOUJ4U2tHOWdCQ1RRMnZaektjaFlJSCs2N2c0?= =?utf-8?B?L1d2dDVUNzdhMzNyemdMZ0crZlBjdVRkZUZvOXNianplNjE1Z2gyaGRwMjZ5?= =?utf-8?B?K2NXYkkxZXY4OHVvWGliVEwyNXhaVE9tYXFPRjUrOThnUitDT2pEZGIrSTEx?= =?utf-8?B?RldkOWhRalNLNTRWSGtBc1Q1eTdQQzBIOVU0aGZYTlE0Vkp3eG1UZDNrWUQ1?= =?utf-8?B?SFNZN3JGMXVaQksyOXVoc3gvdmljd2EwU2cyRDd1ak9RWGFCcFVJTHBvVXpa?= =?utf-8?B?dDl5VTdkRmoyRy9VVlhaVy9YSzdoSjRZUFpvU2EzWmxWclljaE5nRHFUSzBF?= =?utf-8?B?b1BlQmNaMVhZdXl4eUl0MzE4b0FTZTRtcWs1QTlHbEEydGVBWVpOZTVGSmx3?= =?utf-8?B?dU14cGRYOGdxZkdsSWpsZm4ya1pGNXAvZHRNaHVKNnZsQ2pjQjlSMktyU1hF?= =?utf-8?B?S2lOYzhqZkdxVnVQcDJ6RUF6bHJGb3NYekQxRlB1TCtpMWp6d1dmTlJRLzNv?= =?utf-8?B?ZWdBMGZnMVRIcnNvaGx5dkFLcjhWQ3FxSjZHZy9hc0pETFdVaXRNSnJkRWVn?= =?utf-8?B?R1UyN25HQ1hDMlRhSkhYWkN2M0hxUXV4NmFSdXJ6bDllZnQvVy9NS3J6dGxI?= =?utf-8?B?V3EvUXB0NUdvNGo3N3J1YWprYXJUc1d2bmlKMkhnNnFlOFNaM2NOcGx2Sklq?= =?utf-8?B?M1lXTStoRWN4SjNuMlM5dG16VForQTFHcUJKdSt6U1N0Q21NeS9KN01XcU9a?= =?utf-8?B?S296ZVlDN3gwRUpsTUl4Z2ZsSzFmU2VYWDNReDAzU09UZGRjOGNzemliaWtH?= =?utf-8?B?dk5qUW11UDFDZlgvR0FGdmUweXZRd1lITTFWV21hYUV1VUhSV2dyWmJtTnQ1?= =?utf-8?B?clY1Mit1TXJhOFlMQVFkTHpEZE4zVmZuWDF0Q3RrTy9PNDhWL3ZsRTBTVlJD?= =?utf-8?B?UjBYSmtPUTA0SjdBdzM1NmVhMFBnPT0=?= X-MS-Exchange-CrossTenant-Network-Message-Id: 37e9f044-0c84-40ce-c39f-08d998bf7e35 X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 20:30:47.4782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O66JmkDDaNOqEyjdVFFtYm5kBqLlgmmDz528GCekMopEr+COVeYY0NqHo2eZGlTgbQdHf4h07zn9aRdbXmwYYdfWbrO/R5NUHQ6c8K8HJ3c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3054 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] fib: add rib extension size parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 25/10/2021 19:23, Thomas Monjalon wrote: > 06/09/2021 17:55, Vladimir Medvedkin: >> This patch adds a new parameter to the fib configuration to specify >> the size of the extension for internal RIB structure. > > It looks to be an announced API change. > What happens if the new field is not initialized in the app? > At least it would deserve a note in the release notes in API changes I think. > This patch was sent for an experimental library, so no update was required. In the patch about the promotion of the FIB API to stable: https://patches.dpdk.org/project/dpdk/patch/1630944075-363524-1-git-send-email-vladimir.medvedkin@intel.com/ I put a note about this patch and mentioned that it should be applied before promotion API to stable. Can we accept it now or we have to wait for next LTS release? >> --- a/examples/l3fwd/l3fwd_fib.c >> +++ b/examples/l3fwd/l3fwd_fib.c >> @@ -426,6 +426,7 @@ setup_fib(const int socketid) >> /* Create the fib IPv4 table. */ >> config_ipv4.type = RTE_FIB_DIR24_8; >> config_ipv4.max_routes = (1 << 16); >> + config_ipv4.rib_ext_sz = 0; >> config_ipv4.default_nh = FIB_DEFAULT_HOP; >> config_ipv4.dir24_8.nh_sz = RTE_FIB_DIR24_8_4B; >> config_ipv4.dir24_8.num_tbl8 = (1 << 15); >> @@ -475,6 +476,7 @@ setup_fib(const int socketid) >> >> config.type = RTE_FIB6_TRIE; >> config.max_routes = (1 << 16) - 1; >> + config.rib_ext_sz = 0; >> config.default_nh = FIB_DEFAULT_HOP; >> config.trie.nh_sz = RTE_FIB6_TRIE_4B; >> config.trie.num_tbl8 = (1 << 15); >> diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c >> index b354d4b..6ca180d 100644 >> --- a/lib/fib/rte_fib.c >> +++ b/lib/fib/rte_fib.c >> @@ -164,7 +164,7 @@ rte_fib_create(const char *name, int socket_id, struct rte_fib_conf *conf) >> return NULL; >> } >> >> - rib_conf.ext_sz = 0; >> + rib_conf.ext_sz = conf->rib_ext_sz; >> rib_conf.max_nodes = conf->max_routes * 2; >> >> rib = rte_rib_create(name, socket_id, &rib_conf); >> diff --git a/lib/fib/rte_fib.h b/lib/fib/rte_fib.h >> index acad209..570b4b6 100644 >> --- a/lib/fib/rte_fib.h >> +++ b/lib/fib/rte_fib.h >> @@ -84,6 +84,8 @@ struct rte_fib_conf { >> /** Default value returned on lookup if there is no route */ >> uint64_t default_nh; >> int max_routes; >> + /** Size of the node extension in the internal RIB struct */ >> + unsigned int rib_ext_sz; >> union { >> struct { >> enum rte_fib_dir24_8_nh_sz nh_sz; > > > -- Regards, Vladimir