DPDK patches and discussions
 help / color / mirror / Atom feed
From: oulijun <oulijun@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Qi Zhang <qi.z.zhang@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] Questions Questions about hash function enum
Date: Wed, 3 Jun 2020 16:11:02 +0800	[thread overview]
Message-ID: <88c50d79-b278-2f7f-7e4f-1dc35f682654@huawei.com> (raw)
In-Reply-To: <ef024750-a05e-b9fc-71a6-4012983f40db@intel.com>



在 2020/6/3 1:13, Ferruh Yigit 写道:
> On 6/1/2020 2:31 AM, oulijun wrote:
>> Hi Ferruh Yigit and others
>>
>>      I am learning data structure defined by dpdk framework and I noticed
>> a data structure definition below:
>>
>> enum rte_eth_hash_function {
>>       RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
>>       RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
>>       RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
>>       /**
>>        * Symmetric Toeplitz: src, dst will be replaced by
>>        * xor(src, dst). For the case with src/dst only,
>>        * src or dst address will xor with zero pair.
>>        */
>>       RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>>       RTE_ETH_HASH_FUNCTION_MAX,
>> };
>>
>> I have a little difficulty understanding that for the comment:
>>
>>      /**
>>        * Symmetric Toeplitz: src, dst will be replaced by
>>        * xor(src, dst). For the case with src/dst only,
>>        * src or dst address will xor with zero pair.
>>        */
>>
>> if user configure rss func for symmetric toeplitz, Rss type must be
>> updated at the same time?
>>
>> if user configure rss func for xor, rss type must be empty and the queue
>> number is zero?
>>
>> Must it be restricted like this? If so, what is his benefit?
>>
>> Looking forward to your reply
> 
> cc'ed Qi & Andrew
> 
> As far as I understand that comment is only describing the Symmetric Toeplitz
> behavior. I don't see any rss type or queue number limitation.
> 
Hi Qi & Andrew
    if user configure rss func for symmetric toeplitz, RSS types must be 
updated at the same time?
flow create 0 ingress pattern end actions rss func symmetric_toepilitz 
types tcp end / end

if use the following cmd:
flow create 0 ingress pattern end actions rss func symmetric_toepilitz 
types end / end

it is wrong and the driver will print the error info.
How to understand this limitation?

Thanks
Lijun Ou

> 
> .
> 


      reply	other threads:[~2020-06-03  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  1:31 oulijun
2020-06-02 17:13 ` Ferruh Yigit
2020-06-03  8:11   ` oulijun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88c50d79-b278-2f7f-7e4f-1dc35f682654@huawei.com \
    --to=oulijun@huawei.com \
    --cc=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).