DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Questions Questions about hash function enum
@ 2020-06-01  1:31 oulijun
  2020-06-02 17:13 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: oulijun @ 2020-06-01  1:31 UTC (permalink / raw)
  To: Ferruh Yigit, Burakov, Anatoly; +Cc: dev

Hi Ferruh Yigit and others

    I am learning data structure defined by dpdk framework and I noticed 
a data structure definition below:

enum rte_eth_hash_function {
     RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
     RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
     RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
     /**
      * Symmetric Toeplitz: src, dst will be replaced by
      * xor(src, dst). For the case with src/dst only,
      * src or dst address will xor with zero pair.
      */
     RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
     RTE_ETH_HASH_FUNCTION_MAX,
};

I have a little difficulty understanding that for the comment:

    /**
      * Symmetric Toeplitz: src, dst will be replaced by
      * xor(src, dst). For the case with src/dst only,
      * src or dst address will xor with zero pair.
      */

if user configure rss func for symmetric toeplitz, Rss type must be 
updated at the same time?

if user configure rss func for xor, rss type must be empty and the queue 
number is zero?

Must it be restricted like this? If so, what is his benefit?

Looking forward to your reply


Thanks

Lijun Ou



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] Questions Questions about hash function enum
  2020-06-01  1:31 [dpdk-dev] Questions Questions about hash function enum oulijun
@ 2020-06-02 17:13 ` Ferruh Yigit
  2020-06-03  8:11   ` oulijun
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-06-02 17:13 UTC (permalink / raw)
  To: oulijun, Burakov, Anatoly; +Cc: dev, Qi Zhang, Andrew Rybchenko

On 6/1/2020 2:31 AM, oulijun wrote:
> Hi Ferruh Yigit and others
> 
>     I am learning data structure defined by dpdk framework and I noticed 
> a data structure definition below:
> 
> enum rte_eth_hash_function {
>      RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
>      RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
>      RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
>      /**
>       * Symmetric Toeplitz: src, dst will be replaced by
>       * xor(src, dst). For the case with src/dst only,
>       * src or dst address will xor with zero pair.
>       */
>      RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>      RTE_ETH_HASH_FUNCTION_MAX,
> };
> 
> I have a little difficulty understanding that for the comment:
> 
>     /**
>       * Symmetric Toeplitz: src, dst will be replaced by
>       * xor(src, dst). For the case with src/dst only,
>       * src or dst address will xor with zero pair.
>       */
> 
> if user configure rss func for symmetric toeplitz, Rss type must be 
> updated at the same time?
> 
> if user configure rss func for xor, rss type must be empty and the queue 
> number is zero?
> 
> Must it be restricted like this? If so, what is his benefit?
> 
> Looking forward to your reply

cc'ed Qi & Andrew

As far as I understand that comment is only describing the Symmetric Toeplitz
behavior. I don't see any rss type or queue number limitation.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] Questions Questions about hash function enum
  2020-06-02 17:13 ` Ferruh Yigit
@ 2020-06-03  8:11   ` oulijun
  0 siblings, 0 replies; 3+ messages in thread
From: oulijun @ 2020-06-03  8:11 UTC (permalink / raw)
  To: Ferruh Yigit, Burakov, Anatoly; +Cc: dev, Qi Zhang, Andrew Rybchenko



在 2020/6/3 1:13, Ferruh Yigit 写道:
> On 6/1/2020 2:31 AM, oulijun wrote:
>> Hi Ferruh Yigit and others
>>
>>      I am learning data structure defined by dpdk framework and I noticed
>> a data structure definition below:
>>
>> enum rte_eth_hash_function {
>>       RTE_ETH_HASH_FUNCTION_DEFAULT = 0,
>>       RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */
>>       RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */
>>       /**
>>        * Symmetric Toeplitz: src, dst will be replaced by
>>        * xor(src, dst). For the case with src/dst only,
>>        * src or dst address will xor with zero pair.
>>        */
>>       RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,
>>       RTE_ETH_HASH_FUNCTION_MAX,
>> };
>>
>> I have a little difficulty understanding that for the comment:
>>
>>      /**
>>        * Symmetric Toeplitz: src, dst will be replaced by
>>        * xor(src, dst). For the case with src/dst only,
>>        * src or dst address will xor with zero pair.
>>        */
>>
>> if user configure rss func for symmetric toeplitz, Rss type must be
>> updated at the same time?
>>
>> if user configure rss func for xor, rss type must be empty and the queue
>> number is zero?
>>
>> Must it be restricted like this? If so, what is his benefit?
>>
>> Looking forward to your reply
> 
> cc'ed Qi & Andrew
> 
> As far as I understand that comment is only describing the Symmetric Toeplitz
> behavior. I don't see any rss type or queue number limitation.
> 
Hi Qi & Andrew
    if user configure rss func for symmetric toeplitz, RSS types must be 
updated at the same time?
flow create 0 ingress pattern end actions rss func symmetric_toepilitz 
types tcp end / end

if use the following cmd:
flow create 0 ingress pattern end actions rss func symmetric_toepilitz 
types end / end

it is wrong and the driver will print the error info.
How to understand this limitation?

Thanks
Lijun Ou

> 
> .
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-03  8:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01  1:31 [dpdk-dev] Questions Questions about hash function enum oulijun
2020-06-02 17:13 ` Ferruh Yigit
2020-06-03  8:11   ` oulijun

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git