From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05F9DA0C48; Wed, 7 Jul 2021 04:33:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6870C4140A; Wed, 7 Jul 2021 04:33:17 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by mails.dpdk.org (Postfix) with ESMTP id 25F2F41403; Wed, 7 Jul 2021 04:33:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgxeJrINXdIwczZYP5NnC9O1DAjquzwoFTVfrhH5ySc4BIcjhx1ute5amAhg/k8cIgCQRJJf+2anMTMawIGqKib5RsrAfIoEWQUsv599xnCWJ8uFh4H75g5FrOnUa7yP516/eD4VUm2acYEixBdsLVAsjH+e4HT1FIk9ogLKePiVuJOSGegSHO90Uk0rokAVxyglmdJoeWVCNsJjYo9iAIQ6sqd6LWUDrEYgkd+Cl52SNuxbRwoE4HerbiEUxrgGt6TS3a/an4IaOg0HDTX5RnkHw8rCU6KDTmJ5JqN3o8uHxvwA6PN+Aa/pmRIkRZlolS6+Z3APvvOdZyrFzGwyDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+3AOWTcHudvCui6S2UldUrlH7JmA/rtQufsxGN0Lc8=; b=KsrZnhDUHJlJR7L7cNi6fDNqOflK1lb+yDFqtka1SbKZTkvC+gZ2rk2XSrvU0yVt1PjK8hH8GZt69kY781u3aEagltjvJQ1X3VHtgRj/AG3FFvg9JG9heWkKYt+0gXs+7dYnz9h6uuxXc7xtZvf8Y2ZcaoV5X4HMpHpkJkY6PlqvQkXLiyLN3a9Oi4lg3v7gQzhqu0lNo/JCvuKv/UzNO2rQQicP0Z8QA28/GdsmkaDDQv2HRaQrp6gGXj9hFuCsfUla6jmcYxgRxqqCeB9uju+sStztkPi8afICFdIb0Kx3Wm6akT8GLi4Kw/vPraAZat/RVRe2Sds/2Dbpc28IHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y+3AOWTcHudvCui6S2UldUrlH7JmA/rtQufsxGN0Lc8=; b=S8wykd8SOsq9S4Us4D811EeHd6WOPFaGXauRRlSPkSmQxgstXIR3x6Js5AbwHpSjQHi/1OH8kv9soMkQ1E1RVhtiUe6g+//cMFQsxveqHuu2557DBaaTLPNZsQe/r7CX06P2PkSxq7ytyUGvkzeYBnHzpO5Zh8rmXxfMMcn2S0DbC00Y/SWjQGJtRkbkWqXfv1NOmMMe+142fWYBhcClnBqT7BKbU1O0NcDqyIq5CV2z8ModZcmuPO/ca7HQPB2pl5ssh3/MKJpwz2nlRZfYKOdDRiEu5mEczBWHadA60WeTZeGj7HH98TJ48w4n5aJOBMlZb5CH9IxHyRllrjiNuQ== Received: from BN6PR19CA0119.namprd19.prod.outlook.com (2603:10b6:404:a0::33) by BN6PR12MB1698.namprd12.prod.outlook.com (2603:10b6:404:106::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Wed, 7 Jul 2021 02:33:13 +0000 Received: from BN8NAM11FT037.eop-nam11.prod.protection.outlook.com (2603:10b6:404:a0:cafe::5c) by BN6PR19CA0119.outlook.office365.com (2603:10b6:404:a0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 7 Jul 2021 02:33:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT037.mail.protection.outlook.com (10.13.177.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 7 Jul 2021 02:33:13 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Jul 2021 02:33:10 +0000 From: Xiaoyu Min To: Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Dekel Peled , Ori Kam CC: , Date: Wed, 7 Jul 2021 10:32:47 +0800 Message-ID: <88ccba94f213b6715f34038b6b400a5bab889aa3.1625624590.git.jackmin@nvidia.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05b5e3ba-a68a-47d0-64f7-08d940ef91d3 X-MS-TrafficTypeDiagnostic: BN6PR12MB1698: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OWAoaGQdezd82p9TvfNBXC5drISqh9ZpPM0L+Hew5tOndGz3+slg5wWpk4yL985HOnP09llDXt4KU1TioZBPxR88NJgbSMHGZxgcNsiq0Z6Vkbwq11H1sKlzP8LUUwqdAjvLh6qPj6PqchiY8asJjkwk2QC1quhdCT34VPe9xQTlbKQbhin8iLKC3SE6NPZita/rgTXoEudXEX5xQ5sfcNetEhc37/xG0NWOlradHder8Bg+HWJIFPBRbkcKZPzCvUBJPKq/afJKeOuBuDd+n6BP+ZsRriNAuXZQnfiisFOA96MZ/m1VrrTUxdhASZKDN68ntzNWvj5MFUxeuBunIbxkSuNfWWDrcmeyik8ssOG+yjBLWd3ahExJflrrQ2Lod9VIUYWy+4c2ID37mP3bnKtCyNnbkQhwQPTxm5FNgbA80/q4fi+omxEdxaLUO2/930vJx4vzeRw/EgmfWfZoeln1OO8B7H41rUaHjfApKWsV5DC3UTH6d4TcUiP6HinZB+6ZbMY6nMF1wmjV4VUwd9G2lXMY/gZSU3duXNAr2zNG2JFd+v+h9OIXNInbAah5jX6NEnXE6da0xhgOBLA5HzR0kiKv385a3cFCXimdZ1999VJkPKc+fqSBnDOUS9Ht1/ObC2tkSfkXwEFrLWBIIQxyUIIUHc/MNVQT3VxR3laFJSdTp7DsBJ03lZCgVDibiXyadghJkOy+Bqvqe8jS9Q== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(36840700001)(46966006)(7696005)(426003)(55016002)(70206006)(2616005)(8936002)(70586007)(16526019)(6666004)(336012)(6286002)(7636003)(186003)(8676002)(478600001)(356005)(450100002)(86362001)(36860700001)(83380400001)(4326008)(5660300002)(316002)(47076005)(54906003)(110136005)(36906005)(82310400003)(36756003)(2906002)(26005)(82740400003)(6636002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 02:33:13.5738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05b5e3ba-a68a-47d0-64f7-08d940ef91d3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT037.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1698 Subject: [dpdk-dev] [PATCH 2/2] net/mlx5: fix missing RSS expansion of IPv6 frag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" IPV6_FRAG_EXT item is missed for RSS expansion which causes flows like [1] are wrongly expanded. Different from other items, IPV6_FRAG_EXT hasn't next field because HW only support to do hash of UDP/TCP for non-fragment. This MLX5_EXPANSION_IPV6_FRAG_EXT node in RSS expansion graph only helps RSS expansion function to locate right node in graph from which start to expand. Fixes: 0e5a0d8f7556 ("net/mlx5: support match on IPv6 fragment extension") Cc: stable@dpdk.org [1]: flow create 0 ingress pattern eth / ipv6 / udp dst is 250 / vxlan-gpe / ipv6 / ipv6_frag_ext / end actions rss level 2 types ip end / end Signed-off-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 1b682ac8ed..90b8cf6692 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -134,6 +134,7 @@ mlx5_flow_is_rss_expandable_item(const struct rte_flow_item *item) case RTE_FLOW_ITEM_TYPE_MPLS: case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: case RTE_FLOW_ITEM_TYPE_GRE_KEY: + case RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT: return true; default: break; @@ -453,6 +454,7 @@ enum mlx5_expansion { MLX5_EXPANSION_IPV6, MLX5_EXPANSION_IPV6_UDP, MLX5_EXPANSION_IPV6_TCP, + MLX5_EXPANSION_IPV6_FRAG_EXT, }; /** Supported expansion of items. */ @@ -607,7 +609,8 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = { }, [MLX5_EXPANSION_IPV6] = { .next = MLX5_FLOW_EXPAND_RSS_NEXT(MLX5_EXPANSION_IPV6_UDP, - MLX5_EXPANSION_IPV6_TCP), + MLX5_EXPANSION_IPV6_TCP, + MLX5_EXPANSION_IPV6_FRAG_EXT), .type = RTE_FLOW_ITEM_TYPE_IPV6, .rss_types = ETH_RSS_IPV6 | ETH_RSS_FRAG_IPV6 | ETH_RSS_NONFRAG_IPV6_OTHER, @@ -620,6 +623,9 @@ static const struct mlx5_flow_expand_node mlx5_support_expansion[] = { .type = RTE_FLOW_ITEM_TYPE_TCP, .rss_types = ETH_RSS_NONFRAG_IPV6_TCP, }, + [MLX5_EXPANSION_IPV6_FRAG_EXT] = { + .type = RTE_FLOW_ITEM_TYPE_IPV6_FRAG_EXT, + }, }; static struct rte_flow_action_handle * -- 2.32.0