From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by dpdk.org (Postfix) with ESMTP id 8E1347D5B for ; Wed, 31 May 2017 10:34:50 +0200 (CEST) Received: from [IPv6:2001:67c:1220:80c:f8f4:f055:211e:fe80] (unknown [IPv6:2001:67c:1220:80c:f8f4:f055:211e:fe80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 3685F20008; Wed, 31 May 2017 10:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2; t=1496219690; bh=ardB6R8xcyOb5nBBklm4Q11UOsuYo7zfV5kFBCoP/YY=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=bvFE19AVnnooEE9XHK8LSCxYaDTXfhHTKKI+8eprS+Wgr7NmLua60dgjmNXwoV2bS K2tGJtY5314mkbW+r4NOOxXhBe+s0EQm6JMxpO7Z+RoAWfs6KcmPB2HTEBtp+Ccr+r jfiPaqG7v0q+xjC6jO3JONdyLGUGFVjYgrMP0BqQ= To: Ferruh Yigit References: <1495821956-5050-1-git-send-email-vido@cesnet.cz> <1495821956-5050-5-git-send-email-vido@cesnet.cz> <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com> Cc: dev@dpdk.org From: Matej Vido Message-ID: <88d126a8-1575-c478-2810-d5dec0f9a96f@cesnet.cz> Date: Wed, 31 May 2017 10:34:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <671d38c4-1c27-c7f0-5aa7-678f6731b6ca@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 08:34:50 -0000 On 29.05.2017 14:42, Ferruh Yigit wrote: > On 5/26/2017 7:05 PM, Matej Vido wrote: >> Add IBUF and OBUF offsets definitions for new firmwares. > just to double check, is it required to add new pci device ids to > support these new cards? > > Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be updated? > > Can you please update release notes to announce new cards support? Hi Ferruh, This patch set adds mainly the support of new firmwares for the cards that are already supported. But you are right, there is also one new card which would need to add new pci device id. We have to check if we want to add the card in this patch set and I will update v2 accordingly. > >> Signed-off-by: Matej Vido > <...> > >> +#elif RTE_LIBRTE_PMD_SZEDATA2_AS == 5 >> + >> +const uint32_t szedata2_ibuf_base_table[] = { >> + 0x8000, >> + 0x8200, >> + 0x8400, >> + 0x8600, >> + 0x8800 >> +}; >> +const uint32_t szedata2_obuf_base_table[] = { >> + 0x9000, >> + 0x9200, >> + 0x9400, >> + 0x9600, >> + 0x9800 >> +}; > AS = 5 is not documented in both documentation and source code comment, > can you please add this one too? 5 is for future use and experimental firmwares. Would it make sense to write this note in the comments but not in the documentation to avoid confusion or should it be mentioned in the documentation too? Thanks, Matej >> + >> #else >> #error "RTE_LIBRTE_PMD_SZEDATA2_AS has wrong value, see comments in config file" >> #endif >>